New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1502244:  Null pointer dereferences  (NULL_RETURNS)
/pimd/pim_nb_config.c: 2414 in lib_interface_pim_address_family_mroute_oif_modify()


________________________________________________________________________________________________________
*** CID 1502244:  Null pointer dereferences  (NULL_RETURNS)
/pimd/pim_nb_config.c: 2414 in lib_interface_pim_address_family_mroute_oif_modify()
2408     			snprintf(args->errmsg, args->errmsg_len,
2409     				 "%% Enable PIM and/or IGMP on this interface first");
2410     			return NB_ERR_VALIDATION;
2411     		}
2412     
2413     #ifdef PIM_ENFORCE_LOOPFREE_MFC
>>>     CID 1502244:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing "oif", which is known to be "NULL".
2414     		if (iif->ifindex == oif->ifindex) {
2415     			strlcpy(args->errmsg,
2416     				"% IIF same as OIF and loopfree enforcement is enabled; rejecting",
2417     				args->errmsg_len);
2418     			return NB_ERR_VALIDATION;
2419     		}

** CID 1502243:  Error handling issues  (CHECKED_RETURN)
/bgpd/bgp_evpn_mh.c: 1704 in bgp_evpn_local_es_activate()


________________________________________________________________________________________________________
*** CID 1502243:  Error handling issues  (CHECKED_RETURN)
/bgpd/bgp_evpn_mh.c: 1704 in bgp_evpn_local_es_activate()
1698     		/* generate EAD-EVI */
1699     		bgp_evpn_local_type1_evi_route_add(bgp, es);
1700     
1701     		/* generate EAD-ES */
1702     		build_evpn_type1_prefix(&p, BGP_EVPN_AD_ES_ETH_TAG, &es->esi,
1703     					es->originator_ip);
>>>     CID 1502243:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "bgp_evpn_type1_route_update" without checking return value (as is done elsewhere 4 out of 5 times).
1704     		bgp_evpn_type1_route_update(bgp, es, NULL, &p);
1705     	}
1706     }
1707     
1708     /* Process ES link oper-up by generating ES-EAD and ESR */
1709     static void bgp_evpn_local_es_up(struct bgp *bgp, struct bgp_evpn_es *es,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DWae4_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTxmf0StKklWBVucmlmQOewQJ7nWTxo-2F4idD7T63zdzlWRegsOY8eiRjXoE5Dh7HYrOibJocPuMjv5oUO8h59jRW0R-2Batt217m8gpYtiGpy-2BlrYdLZPPOSjHYvWTtqtBLaj-2FfyIr4BKOexofT-2Fxu-2BlP4BlNM-2Fs2W9jnYSUQ2kn07yiPts3PF-2FBmcoxMs9EVo00A-3D