New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1500604:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_updgrp_adv.c: 521 in bgp_adj_out_set_subgroup()


________________________________________________________________________________________________________
*** CID 1500604:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_updgrp_adv.c: 521 in bgp_adj_out_set_subgroup()
515     	adv = adj->adv;
516     	adv->dest = dest;
517     	assert(adv->pathi == NULL);
518     	/* bgp_path_info adj_out reference */
519     	adv->pathi = bgp_path_info_lock(path);
520     
>>>     CID 1500604:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "attr" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
521     	if (attr)
522     		adv->baa = bgp_advertise_intern(subgrp->hash, attr);
523     	else
524     		adv->baa = baa_new();
525     	adv->adj = adj;
526     	adj->attr_hash = attr_hash;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DtbpG_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTwZGGWCZCmmfb12UQ6U6zzwroQmoFQWyuBsi09Oz4n-2Fpna7eAH1TKhnOhYbh82zToqUogWLgkHwsc6jvy-2FyBjt1iQy-2B9MGYPu88tyFGz5mYcnfUZRcqGv4W82TJgINZmsibCn0LKjzue5332gMmNvJ7f9q2fBdKNoGrfvKwEFRSGpy0-2FewJCW2kIPP2AfFZTps-3D