New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1501000:    (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1501000:    (NULL_RETURNS)
/bgpd/bgp_route.c: 3519 in bgp_attr_add_no_advertise_community()
3513     	struct community *noadv;
3514     
3515     	old = attr->community;
3516     	noadv = community_str2com("no-advertise");
3517     
3518     	if (old) {
>>>     CID 1501000:    (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "noadv" when calling "community_merge".
3519     		merge = community_merge(community_dup(old), noadv);
3520     
3521     		if (!old->refcnt)
3522     			community_free(&old);
3523     
3524     		new = community_uniq_sort(merge);
/bgpd/bgp_route.c: 3527 in bgp_attr_add_no_advertise_community()
3521     		if (!old->refcnt)
3522     			community_free(&old);
3523     
3524     		new = community_uniq_sort(merge);
3525     		community_free(&merge);
3526     	} else {
>>>     CID 1501000:    (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "noadv" when calling "community_dup".
3527     		new = community_dup(noadv);
3528     	}
3529     
3530     	community_free(&noadv);
3531     
3532     	attr->community = new;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DV2ji_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTwf1pZzd19gwS6fT33FiQr7WPi76j14ZtqmMPtgZ0mx8REZ26P5y5BC-2BnlNcGDlXe-2Bi51lKwV-2BYt6vcPVFOsb7-2FW7T3ITIgdZ6ev-2BtdS0ul6PeHUkBkZZb5jOjz-2BrSMQQV3FT57viG1fba3f-2BNXk27XQKCCXezNjtPPCcwW2dR2D9A-2FSTxHuW6ElVCNyj6gYbc-3D