New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1505177:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1505177:  Null pointer dereferences  (FORWARD_NULL)
/ospf6d/ospf6_top.c: 290 in ospf6_top_route_hook_remove()
284     	else if (route->table->scope_type == OSPF6_SCOPE_TYPE_AREA) {
285     		oa = (struct ospf6_area *)route->table->scope;
286     		ospf6 = oa->ospf6;
287     	}
288     
289     	route->flag |= OSPF6_ROUTE_REMOVE;
>>>     CID 1505177:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "ospf6" to "ospf6_abr_originate_summary", which dereferences it.
290     	ospf6_abr_originate_summary(route, ospf6);
291     	ospf6_zebra_route_update_remove(route, ospf6);
292     }
293     
294     static void ospf6_top_brouter_hook_add(struct ospf6_route *route)
295     {

** CID 1505176:  Error handling issues  (CHECKED_RETURN)
/ospf6d/ospf6_nssa.c: 1096 in ospf6_abr_task_timer()


________________________________________________________________________________________________________
*** CID 1505176:  Error handling issues  (CHECKED_RETURN)
/ospf6d/ospf6_nssa.c: 1096 in ospf6_abr_task_timer()
1090     
1091     	ospf6->t_abr_task = NULL;
1092     
1093     	if (IS_OSPF6_DEBUG_ABR)
1094     		zlog_debug("Running ABR task on timer");
1095     
>>>     CID 1505176:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "ospf6_is_router_abr" without checking return value (as is done elsewhere 12 out of 13 times).
1096     	ospf6_is_router_abr(ospf6);
1097     	ospf6_abr_nssa_check_status(ospf6);
1098     	ospf6_abr_task(ospf6);
1099     	/* if nssa-abr, then scan Type-7 LSDB */
1100     	ospf6_abr_nssa_task(ospf6);
1101     	ospf6_asbr_nssa_redist_task(ospf6);

** CID 1505175:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1505175:  Null pointer dereferences  (FORWARD_NULL)
/ospf6d/ospf6_top.c: 273 in ospf6_top_route_hook_add()
267     		ospf6 = route->table->scope;
268     	else if (route->table->scope_type == OSPF6_SCOPE_TYPE_AREA) {
269     		oa = (struct ospf6_area *)route->table->scope;
270     		ospf6 = oa->ospf6;
271     	}
272     
>>>     CID 1505175:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "ospf6" to "ospf6_abr_originate_summary", which dereferences it.
273     	ospf6_abr_originate_summary(route, ospf6);
274     	ospf6_zebra_route_update_add(route, ospf6);
275     }
276     
277     static void ospf6_top_route_hook_remove(struct ospf6_route *route)
278     {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3Dblc2_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTwBh2LbGUnwGDkJXh4hrUVnuZ5htFwW-2BVWnIWmKDHz6y3nADhH5tUfMcyZ2nweNeGZ776ELShEThZjiwZYxzkxK-2F6-2FE15-2F7Jo6jINTQflQ-2BSZp8KqgfvWHUL5lZEs2ki0XnGLQ7ZghOS6RLzFtnvkZxi6BYCMpKiS-2FubeNrIQpZGg-3D-3D