New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1504895:  Possible Control flow issues  (DEADCODE)
/lib/northbound.c: 2434 in nb_init()


________________________________________________________________________________________________________
*** CID 1504895:  Possible Control flow issues  (DEADCODE)
/lib/northbound.c: 2434 in nb_init()
2428     		DEBUGD(&nb_dbg_events, "northbound: loading %s.yang",
2429     		       modules[i]->name);
2430     		*loadedp++ = yang_module_load(modules[i]->name);
2431     	}
2432     
2433     	if (explicit_compile)
>>>     CID 1504895:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "yang_init_loading_complete();".
2434     		yang_init_loading_complete();
2435     
2436     	/* Initialize the compiled nodes with northbound data */
2437     	for (size_t i = 0; i < nmodules; i++) {
2438     		yang_snodes_iterate(loaded[i]->info, nb_node_new_cb, 0, NULL);
2439     		nb_load_callbacks(modules[i]);

** CID 1504894:    (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1504894:    (NULL_RETURNS)
/lib/northbound.c: 610 in nb_config_diff()
604     				/* Skip rest of sub-tree, move to next sibling
605     				 */
606     				LYD_TREE_DFS_continue = 1;
607     				break;
608     			case 'd': /* delete */
609     				target = yang_dnode_get(config1->dnode, path);
>>>     CID 1504894:    (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "target" when calling "nb_config_diff_deleted".
610     				nb_config_diff_deleted(target, &seq, changes);
611     
612     				/* Skip rest of sub-tree, move to next sibling
613     				 */
614     				LYD_TREE_DFS_continue = 1;
615     				break;
/lib/northbound.c: 602 in nb_config_diff()
596     				   * dnode from the diff instead of the
597     				   * candidate config node we get failures when
598     				   * looking up default values, etc, based on
599     				   * the diff tree.
600     				   */
601     				target = yang_dnode_get(config2->dnode, path);
>>>     CID 1504894:    (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "target" when calling "nb_config_diff_created".
602     				nb_config_diff_created(target, &seq, changes);
603     
604     				/* Skip rest of sub-tree, move to next sibling
605     				 */
606     				LYD_TREE_DFS_continue = 1;
607     				break;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3D4rdy_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTyiXFrART-2BCVRNSyTNBDD-2F1jeKN2ADTpoRFOZ9xuScWV1XA8xO9R0MzvMGk1glh9O-2FWGv5ACFFReHk34FWwkAC1PKMGxnEJy5MFMQXpknBwdSImp5-2FQjeKdAF2hIn3Vt-2FsGUjAOl2xUnpzQ0jayy2tuM2pn8dah41tdbpbZ45dtqQ-3D-3D