New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1510738:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1510738:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty.c: 4243 in bgp_shutdown_msg_magic()
4237     	if (msgstr && strlen(msgstr) > BGP_ADMIN_SHUTDOWN_MSG_LEN) {
4238     		vty_out(vty, "%% Shutdown message size exceeded %d\n",
4239     			BGP_ADMIN_SHUTDOWN_MSG_LEN);
4240     		return CMD_WARNING_CONFIG_FAILED;
4241     	}
4242     
>>>     CID 1510738:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "msgstr" to "bgp_shutdown_enable", which dereferences it.
4243     	bgp_shutdown_enable(bgp, msgstr);
4244     	XFREE(MTYPE_TMP, msgstr);
4245     
4246     	return CMD_SUCCESS;
4247     }
4248     

** CID 1510737:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgpd.c: 4344 in bgp_shutdown_enable()


________________________________________________________________________________________________________
*** CID 1510737:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgpd.c: 4344 in bgp_shutdown_enable()
4338     		/* continue, if peer is already in administrative shutdown. */
4339     		if (CHECK_FLAG(peer->flags, PEER_FLAG_SHUTDOWN))
4340     			continue;
4341     
4342     		/* send a RFC 4486 notification message if necessary */
4343     		if (BGP_IS_VALID_STATE_FOR_NOTIF(peer->status)) {
>>>     CID 1510737:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "msg" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
4344     			if (msg)
4345     				bgp_notify_send_with_data(
4346     					peer, BGP_NOTIFY_CEASE,
4347     					BGP_NOTIFY_CEASE_ADMIN_SHUTDOWN, data,
4348     					datalen + 1);
4349     			else


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DMb4x_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTzoffqjlY8xBIUJcCn1-2FpeXA2-2FMs0SNSpQ7dV9hQ0pnpQvr0q2svatpT1PwZvDPFR3-2BLSnvH7Kh7qAWuYc-2B9OLe6aZznrmtHdC6HDDAI2DugZQuOCgWhvAuGP2CVGDlaHbhpT3wpbT7GH5NnA6ddDKKfwYfaleW3DkfZLK2fnqrMQ-3D-3D