New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1527358:  Memory - illegal accesses  (USE_AFTER_FREE)
/zebra/zebra_srte.c: 395 in zebra_srte_client_close_cleanup()


________________________________________________________________________________________________________
*** CID 1527358:  Memory - illegal accesses  (USE_AFTER_FREE)
/zebra/zebra_srte.c: 395 in zebra_srte_client_close_cleanup()
389     	int sock = client->sock;
390     	struct zebra_sr_policy *policy;
391     
392     	if (!sock)
393     		return 0;
394     
>>>     CID 1527358:  Memory - illegal accesses  (USE_AFTER_FREE)
>>>     Passing freed pointer "policy" as an argument to "zebra_sr_policy_instance_head_RB_NEXT".
395     	RB_FOREACH (policy, zebra_sr_policy_instance_head,
396     		    &zebra_sr_policy_instances) {
397     		if (policy->sock == sock)
398     			zebra_sr_policy_del(policy);
399     	}
400     	return 1;

** CID 1527357:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_evpn_vty.c: 2571 in evpn_show_route_vni_macip()


________________________________________________________________________________________________________
*** CID 1527357:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_evpn_vty.c: 2571 in evpn_show_route_vni_macip()
2565     	}
2566     
2567     	/*
2568     	 * MAC is per-path, we have to walk the path_info's and look for it
2569     	 * first here.
2570     	 */
>>>     CID 1527357:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "ip" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
2571     	if (ip && mac) {
2572     		for (pi = bgp_dest_get_bgp_path_info(dest); pi; pi = pi->next) {
2573     			if (memcmp(mac, evpn_type2_path_info_get_mac(pi),
2574     				   sizeof(*mac)) == 0)
2575     				break;
2576     		}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DTOz__O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTwQY5iMdyTAMTVdAzCH1TWBnGzdZaHcRtokqsYx66vKEuA-2Fa202G5IKq3tcUo-2B9TBFFXTy2Ou2l-2F3L1kjv997fkpXR9jNVzk2n12Ah0iddairwGjm-2FmoKQK9epsuSPEbUsJBKrC5tkeZ67vm6vv0zNJzWWGShV3M6UyJ12b-2FnHDUw-3D-3D