New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1568217:  Memory - illegal accesses  (RETURN_LOCAL)
/bgpd/bgpd.h: 2604 in timestamp_string()


________________________________________________________________________________________________________
*** CID 1568217:  Memory - illegal accesses  (RETURN_LOCAL)
/bgpd/bgpd.h: 2604 in timestamp_string()
2598     static inline char *timestamp_string(time_t ts)
2599     {
2600     	time_t tbuf;
2601     	char timebuf[32];
2602     
2603     	tbuf = time(NULL) - (monotime(NULL) - ts);
>>>     CID 1568217:  Memory - illegal accesses  (RETURN_LOCAL)
>>>     Returning result of calling "ctime_r".
2604     	return ctime_r(&tbuf, timebuf);
2605     }
2606     
2607     static inline bool peer_established(struct peer_connection *connection)
2608     {
2609     	return connection->status == Established;

** CID 1568216:  Integer handling issues  (NEGATIVE_RETURNS)


________________________________________________________________________________________________________
*** CID 1568216:  Integer handling issues  (NEGATIVE_RETURNS)
/lib/vty.c: 2416 in vtysh_read()
2410     
2411     				/* warning: watchfrr hardcodes this result write
2412     				 */
2413     				header[3] = ret;
2414     				buffer_put(vty->obuf, header, 4);
2415     
>>>     CID 1568216:  Integer handling issues  (NEGATIVE_RETURNS)
>>>     "vty->pass_fd" is passed to a parameter that cannot be negative.
2416     				if (!vty->t_write && (vtysh_flush(vty) < 0))
2417     					/* Try to flush results; exit if a write
2418     					 * error occurs. */
2419     					return;
2420     			}
2421     		}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3Djgma_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTziIq-2BT-2FislCZ6lQyfpHp5jVsj1Bm-2FTQScE9ivkYlysnzp8EgF-2BFHd0me6CCFDmTt0yHtCUx8084fOkLfHgCMEyI4hwitAUV3l9CsGRyArr5QxjC-2BxAZthzPc7TRSZh-2BqF4I0MBYY3gMWe9ePDwqYIL8F8v0pbzGrvcS3O2iiw9-2Bw-3D-3D