New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1585206:  Error handling issues  (CHECKED_RETURN)
/bgpd/bgp_fsm.c: 1804 in bgp_connect_in_progress_update_connection()


________________________________________________________________________________________________________
*** CID 1585206:  Error handling issues  (CHECKED_RETURN)
/bgpd/bgp_fsm.c: 1804 in bgp_connect_in_progress_update_connection()
1798     
1799     /* after connect is called(), getpeername is able to return
1800      * port and address on non established streams
1801      */
1802     static void bgp_connect_in_progress_update_connection(struct peer *peer)
1803     {
>>>     CID 1585206:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "bgp_getsockname" without checking return value (as is done elsewhere 5 out of 6 times).
1804     	bgp_getsockname(peer);
1805     	if (!peer->su_remote && !BGP_CONNECTION_SU_UNSPEC(peer->connection)) {
1806     		/* if connect initiated, then dest port and dest addresses are well known */
1807     		peer->su_remote = sockunion_dup(&peer->connection->su);
1808     		if (sockunion_family(peer->su_remote) == AF_INET)
1809     			peer->su_remote->sin.sin_port = htons(peer->port);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4jkWudbux5UNqYsSt9ZXO3s9m3KMDrlSX-2Bp41IzjejfmdC2hinnLY-2BZ6PvlTenLZs-3D7rDz_t0zeZlCsA34Fiw17aIfmh-2F3kFs1q7rysihvAefHXY78UQkur1prhJVJhGzORa03B9PiStfIvRtEn8xS3pUKnaQ4G2YI5vAprORaso8LdLxgNGpk9b-2Bir2uKfvEOglhGflNjh5jgNVuvKMFUDHtgPF9mkFS2h-2Bbe-2FEUnGsAjnfoYustZasySnv-2FMSQlV-2FYdVogAy6-2BSen2XHaaWAJrTIz5w-3D-3D