Supporting Graceful Restart for more SAFIs (e.g. EVPN)

[Lukas Stockner]

Hi all,

I've been looking into using FRR as a RR for EVPN with Graceful Restart
enabled and found that this currently does not work
since FOREACH_AFI_SAFI_NSF only goes through the unicast, multicast and
MPLS-VPN SAFIs, so EVPN routes aren't preserved and peers which only
negotiate EVPN are deleted on disconnect.

However, I can't see any reason why such a limitation would be necessary,
and simply removing it and using the general FOREACH_AFI_SAFI in the GH
code appears to work just fine.

>From what I can tell through git blame, it seems like the GH code predates
these SAFIs, its loop boundaries weren't updated when e.g. EVPN was added,
and when the FOREACH #define was introduced to clean the code up, it was
assumed that the difference is intentional.

I'd be happy to open a PR to change this, just wanted to check if anyone is
aware of a reason to keep this as-is.

Cheers,
Lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.frrouting.org/pipermail/dev/attachments/20241212/b195ceb4/attachment.htm>