New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1576001:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
/sharpd/sharp_zebra.c: 1020 in ()


________________________________________________________________________________________________________
*** CID 1576001:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
/sharpd/sharp_zebra.c: 1020 in ()
1014     	if (!ifp) {
1015     		zlog_debug("Failed to lookup interface for neighbor entry: %u for %u",
1016     			   api.index, vrf_id);
1017     		return 0;
1018     	}
1019     
>>>     CID 1576001:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
>>>     use of "=" where "==" may have been intended
1020     	zlog_debug("Received: %s %pSU dev %s lladr %pSU",
1021     		   (cmd = ZEBRA_NEIGH_ADDED) ? "NEW" : "DEL", &addr, ifp->name,
1022     		   &lladdr);
1023     
1024     	return 0;
1025     }

** CID 1576000:  Parse warnings  (PW.PARAM_SET_BUT_NOT_USED)
/sharpd/sharp_zebra.c: 992 in ()


________________________________________________________________________________________________________
*** CID 1576000:  Parse warnings  (PW.PARAM_SET_BUT_NOT_USED)
/sharpd/sharp_zebra.c: 992 in ()
986     	}
987     
988     	zlog_err("%s: can't get locator_chunk!!", __func__);
989     	return 0;
990     }
991     
>>>     CID 1576000:  Parse warnings  (PW.PARAM_SET_BUT_NOT_USED)
>>>     parameter "cmd" was set but never used
992     static int sharp_zebra_process_neigh(ZAPI_CALLBACK_ARGS)
993     {
994     	union sockunion addr = {}, lladdr = {};
995     	struct zapi_neigh_ip api = {};
996     	struct interface *ifp;
997     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BoAJF92cCodBN9BBnDbw-2FFg-3D0bFQ_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTy-2BTHaQLFqFk5TEM0GgGpQMUtwQxiQQPEGBoxJRIAXmN-2F6pur-2FPkfAMqZ72Jf5BwWUZH-2FhFjtAFTu6mz9F6re348hpn6vKV5wiJhXGSKwyk9rlZ5xHYkOWBGszzPo5dcapgv33H333AMh1ZXsdSZg3iwooRzvYIoZkI5K0R-2FzVOeg-3D-3D