New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1584308:  Concurrent data access violations  (MISSING_LOCK)
/zebra/zserv.c: 328 in zserv_read()


________________________________________________________________________________________________________
*** CID 1584308:  Concurrent data access violations  (MISSING_LOCK)
/zebra/zserv.c: 328 in zserv_read()
322     	size_t already;
323     	struct stream_fifo *cache;
324     	uint32_t p2p;	    /* Temp p2p used to process */
325     	uint32_t p2p_orig;  /* Configured p2p (Default-1000) */
326     	int p2p_avail;	    /* How much space is available for p2p */
327     	struct zmsghdr hdr;
>>>     CID 1584308:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "client->ibuf_fifo" without holding lock "zserv.ibuf_mtx". Elsewhere, "zserv.ibuf_fifo" is written to with "zserv.ibuf_mtx" held 2 out of 2 times.
328     	size_t client_ibuf_fifo_cnt = stream_fifo_count_safe(client->ibuf_fifo);
329     
330     	p2p_orig = atomic_load_explicit(&zrouter.packets_to_process,
331     					memory_order_relaxed);
332     	p2p_avail = p2p_orig - client_ibuf_fifo_cnt;
333     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4jkWudbux5UNqYsSt9ZXO3s9m3KMDrlSX-2Bp41IzjejfmdC2hinnLY-2BZ6PvlTenLZs-3DHtta_t0zeZlCsA34Fiw17aIfmh-2F3kFs1q7rysihvAefHXY783jFnhaG85eIayevrcivvaUDN1739zcpa2bRoDegIIEO7eR0H7rOj439eW159FGklZaXYoyd3DoRodgmaTJQ66-2FTCylLbCOAK0E4McwN-2BtjUSadkDM3yaAhA12yPiTj96S49iT8k28UBIgy5rrZkeOc-2FLQUQyOi1ysvYC4P3eyXg-3D-3D