New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1602058:  Incorrect expression  (COPY_PASTE_ERROR)
/bgpd/bgpd.c: 5706 in peer_update_source_addr_set()


________________________________________________________________________________________________________
*** CID 1602058:  Incorrect expression  (COPY_PASTE_ERROR)
/bgpd/bgpd.c: 5706 in peer_update_source_addr_set()
5700     		SET_FLAG(member->flags, PEER_FLAG_UPDATE_SOURCE);
5701     		member->update_source = sockunion_dup(su);
5702     		XFREE(MTYPE_PEER_UPDATE_SOURCE, member->update_if);
5703     		member->last_reset = PEER_DOWN_UPDATE_SOURCE_CHANGE;
5704     
5705     		/* Send notification or reset peer depending on state. */
>>>     CID 1602058:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "peer" in "peer->connection" looks like a copy-paste error.
5706     		if (!peer_notify_config_change(peer->connection))
5707     			bgp_session_reset(member);
5708     
5709     		/* Apply new source configuration to BFD session. */
5710     		if (member->bfd_config)
5711     			bgp_peer_bfd_update_source(member);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4jkWudbux5UNqYsSt9ZXO3s9m3KMDrlSX-2Bp41IzjejfmdC2hinnLY-2BZ6PvlTenLZs-3D_S8J_t0zeZlCsA34Fiw17aIfmh-2F3kFs1q7rysihvAefHXY7-2F6erBswj3nhxzyirza2k30Ub1-2BZBwIgEoAYAtewWo4NJUTy5H6G1z9sLtmcMk6O-2FzFaFCeOR93lIWQfHwofU5zA2Anb3EclyHB8oLOr-2BNsGhR9QcGvQaVeV5-2B8GLIHykXIHL6VAZmAw03ozXj6nmm-2Fu4D4Wv-2BasAq2Yz-2FDlUm7vg-3D-3D