[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[Chirag Shah]

I will take care of this in my next patch.

Regards,
Chirag 


From: scan-admin at coverity.com
Sent: Monday, April 24, 2017 1:38 PM
To: frr at lists.nox.tf
Subject: [dev] New Defects reported by Coverity Scan for freerangerouting/frr


Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1430487:  Possible Control flow issues  (DEADCODE)
/pimd/pim_nht.c: 303 in pim_update_rp_nh()


________________________________________________________________________________________________________
*** CID 1430487:  Possible Control flow issues  (DEADCODE)
/pimd/pim_nht.c: 303 in pim_update_rp_nh()
297                           __PRETTY_FUNCTION__, rp_str,
298                           rp_info->rp.source_nexthop.interface->name);
299             }
300         }
301     
302       if (ret)
>>>     CID 1430487:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "return 0;".
303         return 0;
304     
305       return 1;
306     
307     }
308     

** CID 1399390:  Security best practices violations  (STRING_OVERFLOW)
/pimd/pim_register.c: 193 in pim_register_send()


________________________________________________________________________________________________________
*** CID 1399390:  Security best practices violations  (STRING_OVERFLOW)
/pimd/pim_register.c: 193 in pim_register_send()
187         return;
188       }
189     
190       if (PIM_DEBUG_PIM_REG)
191         {
192           char rp_str[INET_ADDRSTRLEN];
>>>     CID 1399390:  Security best practices violations  (STRING_OVERFLOW)
>>>     You might overrun the 16-character fixed-size string "rp_str" by copying the return value of "inet_ntoa" without checking the length.
193           strcpy (rp_str, inet_ntoa (rpg->rpf_addr.u.prefix4));
194           zlog_debug ("%s: Sending %s %sRegister Packet to %s on %s",
195                   __PRETTY_FUNCTION__, up->sg_str,
196                   null_register ? "NULL " : "", rp_str, ifp->name);
197         }
198     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmtKHBmrggQsmQ1wRxSAkKp605MA3Ubb6KaJgA7PHUY9nHXRnq5WSc1srjMQBQg4odBhXXoJ44WdRaY6T0BbK3cTZ93VxR-2BRY675i5N7khwYSAZiMnj69VqNo-2BIQ3cG-2FIJXMyXwGoWBgNmkJ0TAudPCXOkllvLB0US1NlmRDyQEdg-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmtKHBmrggQsmQ1wRxSAkKp8LdK6KIKPaxrr-2FGdwNZ87N8YVJplSMz29-2BtvLyIKy1cIg3WvmDaRQ-2BfxldMSXlOqkyBOVZTUhWbyTnnWii4a1dexsJanRVWL4z1Ro-2FSYtrzYf49fKkvL5OBmTSAEsNoJrXHC6EhzxihVmX753lgDcw-3D-3D


_______________________________________________
dev mailing list
dev at lists.frrouting.org
https://lists.frrouting.org/listinfo/dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.frrouting.org/pipermail/dev/attachments/20170424/aad0949e/attachment.html>