[frr] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1413930:  Uninitialized variables  (UNINIT)
/zebra/rt_netlink.c: 268 in netlink_route_change_read_unicast()


________________________________________________________________________________________________________
*** CID 1413930:  Uninitialized variables  (UNINIT)
/zebra/rt_netlink.c: 268 in netlink_route_change_read_unicast()
262         }
263     
264       if (IS_ZEBRA_DEBUG_KERNEL)
265         {
266           char buf[PREFIX_STRLEN];
267           char buf2[PREFIX_STRLEN];
>>>     CID 1413930:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "src_p.prefixlen".
268           zlog_debug ("%s %s%s%s vrf %u",
269                       nl_msg_type_to_str (h->nlmsg_type),
270                       prefix2str (&p, buf, sizeof(buf)),
271                       src_p.prefixlen ? " from " : "",
272                       src_p.prefixlen ? prefix2str(&src_p, buf2, sizeof(buf2)) : "",
273                       vrf_id);

** CID 1413929:    (RESOURCE_LEAK)
/bgpd/bgp_encap.c: 609 in show_bgp_ipv4_encap_neighbor_routes()
/bgpd/bgp_encap.c: 612 in show_bgp_ipv4_encap_neighbor_routes()


________________________________________________________________________________________________________
*** CID 1413929:    (RESOURCE_LEAK)
/bgpd/bgp_encap.c: 609 in show_bgp_ipv4_encap_neighbor_routes()
603         }
604     
605       peer = peer_lookup (NULL, su);
606       if (! peer || ! peer->afc[AFI_IP][SAFI_ENCAP])
607         {
608           vty_out (vty, "%% No such neighbor or address family%s", VTY_NEWLINE);
>>>     CID 1413929:    (RESOURCE_LEAK)
>>>     Variable "su" going out of scope leaks the storage it points to.
609           return CMD_WARNING;
610         }
611     
612       return bgp_show_encap (vty, AFI_IP, NULL, bgp_show_type_neighbor, su, 0);
613     }
614     
/bgpd/bgp_encap.c: 612 in show_bgp_ipv4_encap_neighbor_routes()
606       if (! peer || ! peer->afc[AFI_IP][SAFI_ENCAP])
607         {
608           vty_out (vty, "%% No such neighbor or address family%s", VTY_NEWLINE);
609           return CMD_WARNING;
610         }
611     
>>>     CID 1413929:    (RESOURCE_LEAK)
>>>     Variable "su" going out of scope leaks the storage it points to.
612       return bgp_show_encap (vty, AFI_IP, NULL, bgp_show_type_neighbor, su, 0);
613     }
614     
615     DEFUN (show_bgp_ipv6_encap_neighbor_routes,
616            show_bgp_ipv6_encap_neighbor_routes_cmd,
617            "show [ip] bgp ipv6 encap neighbors A.B.C.D routes",


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlpnaXHLnKlBPJgUArP4v0CWT67YVIAMXaB-2B8VN6QI0PpaIgU4tMXEeu7h4n6-2BEtlesUwqQJJWwv021x-2BNhsJhbHZ21GK6XYPc4FOmdfm29dtPE06VMAxhVSrnAZzWoFzXc7SNLpKmNPOUzLUS-2BkU-2FcOB7s9Ri2otP-2FHlGddb4-2B3Q-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlpnaXHLnKlBPJgUArP4v0Ck7lygXr0Z2pzDMZ9-2BJN5SfLbyd9HNx4ivYvTTcDZNOmxmu0we72wNx1g9WFJ6k7dbWpDEIYVsmukCAcui2Zz7HL4euGM3MLOp0HGJPaakfL-2Bo4BvKKGzNUq92ALlb8BMuc7jfw09DscWeTH-2FteveeQ-3D-3D