[frr] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1414724:  Code maintainability issues  (UNUSED_VALUE)
/ldpd/address.c: 89 in send_address()


________________________________________________________________________________________________________
*** CID 1414724:  Code maintainability issues  (UNUSED_VALUE)
/ldpd/address.c: 89 in send_address()
83     		if ((buf = ibuf_open(size)) == NULL)
84     			fatal(__func__);
85     
86     		err |= gen_ldp_hdr(buf, size);
87     		size -= LDP_HDR_SIZE;
88     		err |= gen_msg_hdr(buf, msg_type, size);
>>>     CID 1414724:  Code maintainability issues  (UNUSED_VALUE)
>>>     Assigning value from "size - 8" to "size" here, but that stored value is overwritten before it can be used.
89     		size -= LDP_MSG_SIZE;
90     		err |= gen_address_list_tlv(buf, af, addr_list, tlv_addr_count);
91     		if (err) {
92     			address_list_clr(addr_list);
93     			ibuf_free(buf);
94     			return;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlupfyoqz-2F8NjNhSUqZseOJRHx08Hn7fMQo-2B5fST7fwGHjEf551OujV5qnw5AqWGtOenZ-2F3qwkXxlzXAEE2d3ljxVVsUH-2B3sSZAHn91mOdaVwA76i1OCR-2Bv297eoRwaCE9C2ND39l7N9LKPodETLTSb-2Bv6aLJmnrpjlHvUEmLSbJw-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlupfyoqz-2F8NjNhSUqZseOJ9AH8-2BQ1Zr6LK8X16L-2FCLx1e5M6Lqkli83tVwZOX1JF4pBKBJ3eBZkFEsIybCtMXoIbYq1Rl6W57hO439D3d7Q0B0HTZwxEO536Y32piL8q1AarTdMHmP-2FWslQEoKMKsFc95XK20MiGe3OeJlwlRXWw-3D-3D