[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1433544:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/rfapi/rfapi_vty.c: 2195 in register_add()


________________________________________________________________________________________________________
*** CID 1433544:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/rfapi/rfapi_vty.c: 2195 in register_add()
2189       struct cmd_token *carg_vni,      /* mac present=>mandatory Virtual Network ID */
2190       int        argc,
2191       struct cmd_token **argv)
2192     {
2193            const char *arg_prefix = carg_prefix ? carg_prefix->arg : NULL;
2194            const char *arg_vn = carg_vn ? carg_vn->arg : NULL;
>>>     CID 1433544:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "arg_un" = "NULL".
2195            const char *arg_un = carg_un ? carg_un->arg : NULL;
2196            const char *arg_cost = carg_cost ? carg_cost->arg : NULL;
2197            const char *arg_lifetime = carg_lifetime ? carg_lifetime->arg : NULL;
2198            const char *arg_macaddr = carg_macaddr ? carg_macaddr->arg : NULL;
2199            const char *arg_vni = carg_vni ? carg_vni->arg : NULL;
2200            struct rfapi_ip_addr vn_address;

** CID 1433543:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/rfapi/rfapi_vty.c: 2193 in register_add()


________________________________________________________________________________________________________
*** CID 1433543:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/rfapi/rfapi_vty.c: 2193 in register_add()
2187       struct cmd_token *carg_lifetime, /* optional */
2188       struct cmd_token *carg_macaddr,  /* optional */
2189       struct cmd_token *carg_vni,      /* mac present=>mandatory Virtual Network ID */
2190       int        argc,
2191       struct cmd_token **argv)
2192     {
>>>     CID 1433543:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "arg_prefix" = "NULL".
2193            const char *arg_prefix = carg_prefix ? carg_prefix->arg : NULL;
2194            const char *arg_vn = carg_vn ? carg_vn->arg : NULL;
2195            const char *arg_un = carg_un ? carg_un->arg : NULL;
2196            const char *arg_cost = carg_cost ? carg_cost->arg : NULL;
2197            const char *arg_lifetime = carg_lifetime ? carg_lifetime->arg : NULL;
2198            const char *arg_macaddr = carg_macaddr ? carg_macaddr->arg : NULL;

** CID 1433542:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/rfapi/rfapi_vty.c: 2194 in register_add()


________________________________________________________________________________________________________
*** CID 1433542:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/rfapi/rfapi_vty.c: 2194 in register_add()
2188       struct cmd_token *carg_macaddr,  /* optional */
2189       struct cmd_token *carg_vni,      /* mac present=>mandatory Virtual Network ID */
2190       int        argc,
2191       struct cmd_token **argv)
2192     {
2193            const char *arg_prefix = carg_prefix ? carg_prefix->arg : NULL;
>>>     CID 1433542:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "arg_vn" = "NULL".
2194            const char *arg_vn = carg_vn ? carg_vn->arg : NULL;
2195            const char *arg_un = carg_un ? carg_un->arg : NULL;
2196            const char *arg_cost = carg_cost ? carg_cost->arg : NULL;
2197            const char *arg_lifetime = carg_lifetime ? carg_lifetime->arg : NULL;
2198            const char *arg_macaddr = carg_macaddr ? carg_macaddr->arg : NULL;
2199            const char *arg_vni = carg_vni ? carg_vni->arg : NULL;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJn52IccwSoF-2Fn9ZyWlc3Ujl16RwGbhbTNIBSKa31i9g5-2Bu1MX8NEYQ1CgGp7L1EQQbwaTKWb78vlpjCwTFuPxUTHSVDG2TGET-2BN4DKgyF4YiDRxWHxisCbkpzLEkpz68-2B5cPC-2Fktegl6OCbOKcLwradsWKUCNC2sEFMMZNnMCX1Xg-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJn52IccwSoF-2Fn9ZyWlc3Ujl9-2F1Yva8zsWybGWf1K1wVy-2FCTcU77zLiA0FEzIuFvQ-2F0wMSyCO-2BqvkBfBxvAjxNUwmJhj2emrbgiC0tm-2F1m3Jc6MqxJckOhupdElQ1NPuKqSihnqk1ZRn9GwunmHPJBG1YRSYUirQbUqfs9-2FTmkjrfw-3D-3D