[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1433546:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
/tools/permutations.c: 90 in ()


________________________________________________________________________________________________________
*** CID 1433546:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
/tools/permutations.c: 90 in ()
84         }
85         else
86         {
87           bool skip = false;
88           if (stok->type == FORK_TKN && tok->type != FORK_TKN)
89             for (ALL_LIST_ELEMENTS_RO (position, ln, gnn))
>>>     CID 1433546:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
>>>     use of "=" where "==" may have been intended
90                if (gnn == gn && (skip = true))
91                  break;
92           if (!skip)
93             permute (gn);
94         }
95       }
96       list_delete_node (position, listtail(position));

** CID 1433545:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
/lib/command.c: 1626 in ()


________________________________________________________________________________________________________
*** CID 1433545:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
/lib/command.c: 1626 in ()
1620         }
1621         else
1622         {
1623           bool skip = false;
1624           if (stok->type == FORK_TKN && tok->type != FORK_TKN)
1625             for (ALL_LIST_ELEMENTS_RO (position, ln, gnn))
>>>     CID 1433545:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
>>>     use of "=" where "==" may have been intended
1626                if (gnn == gn && (skip = true))
1627                  break;
1628           if (!skip)
1629             permute (gn, vty);
1630         }
1631       }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlSVtBCH1FgBRzEyt8JaMjSw7XmrDdDT7H0XrjHgpZGRynheqZveAAtZCGAYAIGqKDQkdz3FI9ucH7WRqF2HaG27FS9mXfnqzr3LvT3Y7LaOruGvECrJkmbu0KrFBI4ySpsY-2B0wfbBpq9uLvJLWjnItzztpiwURvwaoGJrXaMRWjQ-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlSVtBCH1FgBRzEyt8JaMjSYkiLLOg02amjHlaErq-2FIkNttnqwag8l-2BPpkwqd7REUduiSsH-2BiyHjGjJ5NHghVG4hprve24-2BT2CoqTh-2FEP29mLWuLQMwMWla8QyV4I3mqzMiwDjLDi2iGjGFZ5fTOdieU13fBoW1skhid6xwZOLlYg-3D-3D