[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
18 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1436344:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_clist.c: 1175 in extcommunity_list_set()


________________________________________________________________________________________________________
*** CID 1436344:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_clist.c: 1175 in extcommunity_list_set()
1169       if (ecom)
1170         ecom->str = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_DISPLAY, 0);
1171     
1172       entry = community_entry_new ();
1173       entry->direct = direct;
1174       entry->style = style;
>>>     CID 1436344:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "str" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1175       entry->any = (str ? 0 : 1);
1176       if (ecom)
1177         entry->config = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_COMMUNITY_LIST, 0);
1178       else if (regex)
1179         entry->config = XSTRDUP (MTYPE_COMMUNITY_LIST_CONFIG, str);
1180     

** CID 1436343:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_clist.c: 1175 in extcommunity_list_set()


________________________________________________________________________________________________________
*** CID 1436343:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_clist.c: 1175 in extcommunity_list_set()
1169       if (ecom)
1170         ecom->str = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_DISPLAY, 0);
1171     
1172       entry = community_entry_new ();
1173       entry->direct = direct;
1174       entry->style = style;
>>>     CID 1436343:  Null pointer dereferences  (FORWARD_NULL)
>>>     Comparing "str" to null implies that "str" might be null.
1175       entry->any = (str ? 0 : 1);
1176       if (ecom)
1177         entry->config = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_COMMUNITY_LIST, 0);
1178       else if (regex)
1179         entry->config = XSTRDUP (MTYPE_COMMUNITY_LIST_CONFIG, str);
1180     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmq-2FvgFy-2BgK6sOm6KmVCXptZPcxRmLAUGS-2FXjxAfdPka8nDH6ypHQXYXLTSFZB1ADOsnCp6G7nM-2Bg-2FTXMdWXKmnOkM0RFG6f0zekmpPV7pYFVYLiHIfUAIz9Eay-2BAWLjVyU7OknxDNPdc5JrK2Oy4-2BuqoCSXvqZ8x1p2EgMi2ALbA-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmq-2FvgFy-2BgK6sOm6KmVCXptl9dG1R8-2F7cBKviNtJ6gxS7rl-2BjDqr-2FD3lI1-2BEatBcGLgzGIB4RKMdnoMRZiWTuT9z84abypD6GZTtdjM1KNQrDxepLuxZnC3IAjy0CtG4FYMkxH5uFkDkK126rnXUpBjswyDvJ7MBOUcHBu81fRjaA-3D-3D