[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1436535:    (RESOURCE_LEAK)
/bgpd/bgp_updgrp_packet.c: 454 in bpacket_reformat_for_peer()
/bgpd/bgp_updgrp_packet.c: 545 in bpacket_reformat_for_peer()


________________________________________________________________________________________________________
*** CID 1436535:    (RESOURCE_LEAK)
/bgpd/bgp_updgrp_packet.c: 454 in bpacket_reformat_for_peer()
448     		offset_nh += 8;
449     		break;
450     	      default:
451     		/* TODO: handle IPv6 nexthops */
452     		zlog_warn ("%s: %s: invalid MP nexthop length (AFI IP): %u",
453                     	   __func__, peer->host, nhlen);
>>>     CID 1436535:    (RESOURCE_LEAK)
>>>     Variable "s" going out of scope leaks the storage it points to.
454     		return NULL;
455     	    }
456     
457               stream_get_from (&v4nh, s, offset_nh, IPV4_MAX_BYTELEN);
458               mod_v4nh = &v4nh;
459     
/bgpd/bgp_updgrp_packet.c: 545 in bpacket_reformat_for_peer()
539     		offset_nhlocal += 8 * 2 + IPV6_MAX_BYTELEN;
540     		break;
541     	      default:
542     		/* TODO: handle IPv4 nexthops */
543     		zlog_warn ("%s: %s: invalid MP nexthop length (AFI IP6): %u",
544                     	   __func__, peer->host, nhlen);
>>>     CID 1436535:    (RESOURCE_LEAK)
>>>     Variable "s" going out of scope leaks the storage it points to.
545     		return NULL;
546     	    }
547     
548               stream_get_from (&v6nhglobal, s, offset_nhglobal, IPV6_MAX_BYTELEN);
549               if (route_map_sets_nh)
550                 {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlvt6KCggoys-2FpTrnXgLB11ITsR0sWQ6WqcBPODn6xsiG9hB-2FbAHagVk50mL-2BbZGnDrRU6-2Fv-2B98vNSpsDjYJ3co1zLU8mSAaNBNb-2FbipFW2Zgxeti-2BkD8ccFWNtMBVpvjeM3e1DBo-2FnTMDGkhPI87a4W-2F-2BTvwzzRYYaxB8GAGW7zA-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlvt6KCggoys-2FpTrnXgLB11950wryctyD8-2BH9LPlyhEvVrypQ2qXzk3rG1XIEQijnXhn2tJSFTSrKkH5HjfUpAvUOwQZTA60AEoShhasCmcgGURODr-2BPnncQy0bqzRoItW8bWbH-2B-2Fak1L-2BpAPrr1YhESsB07LrDqgF5yXMGRAWXrw-3D-3D