[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1472966:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_pbr.c: 1887 in bgp_pbr_policyroute_add_to_zebra_unit()


________________________________________________________________________________________________________
*** CID 1472966:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_pbr.c: 1887 in bgp_pbr_policyroute_add_to_zebra_unit()
1881     	}
1882     
1883     	/* ipset create */
1884     	if (bpm && !bpm->installed)
1885     		bgp_send_pbr_ipset_match(bpm, true);
1886     	/* ipset add */
>>>     CID 1472966:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "bpme" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1887     	if (bpme && !bpme->installed)
1888     		bgp_send_pbr_ipset_entry_match(bpme, true);
1889     
1890     	/* iptables */
1891     	if (bpm && !bpm->installed_in_iptable)
1892     		bgp_send_pbr_iptable(bpa, bpm, true);

** CID 1472965:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_pbr.c: 1884 in bgp_pbr_policyroute_add_to_zebra_unit()


________________________________________________________________________________________________________
*** CID 1472965:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_pbr.c: 1884 in bgp_pbr_policyroute_add_to_zebra_unit()
1878     		bgp_send_pbr_rule_action(bpa, true);
1879     		bgp_zebra_announce_default(bgp, nh,
1880     					   AFI_IP, bpa->table_id, true);
1881     	}
1882     
1883     	/* ipset create */
>>>     CID 1472965:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "bpm" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1884     	if (bpm && !bpm->installed)
1885     		bgp_send_pbr_ipset_match(bpm, true);
1886     	/* ipset add */
1887     	if (bpme && !bpme->installed)
1888     		bgp_send_pbr_ipset_entry_match(bpme, true);
1889     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJm6Tuvd1NizCpw6QGwU3ykMha7QwL4khSPfl8I1gfVMvQhX63gl-2FeDsn3K2olnEaA8kEnLomaQaPPhrQ8OWP0V5QHVscLRzFFL5vvF6y6hSR9iTySp4m9pmdpN2kZubOMUNsZ70-2BUYEXrB9bf00q2WNqhmyVunRF1iDfNxv2yzuDg-3D-3D