[dev] New Defects reported by Coverity Scan for freerangerouting/frr
scan-admin at coverity.com
scan-admin at coverity.com
Sat Aug 25 08:17:09 EDT 2018
Hi,
Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
10 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 10 of 10 defect(s)
** CID 1473047: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8683 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473047: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8683 in route_vty_out_detail_header()
8677 vty_out(vty,
8678 ", mark translated RTs for VPNv4 route filtering");
8679 else if (route_filter_v4)
8680 vty_out(vty,
8681 ", attach RT as-is for VPNv4 route filtering");
8682 else if (route_filter_translated_v6)
>>> CID 1473047: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", mark transl...".
8683 vty_out(vty,
8684 ", mark translated RTs for VPNv6 route filtering");
8685 else if (route_filter_v6)
8686 vty_out(vty,
8687 ", attach RT as-is for VPNv6 route filtering");
8688 else if (llgr_stale)
** CID 1473046: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8677 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473046: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8677 in route_vty_out_detail_header()
8671 vty_out(vty, ", no best path");
8672
8673 if (accept_own)
8674 vty_out(vty,
8675 ", accept own local route exported and imported in different VRF");
8676 else if (route_filter_translated_v4)
>>> CID 1473046: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", mark transl...".
8677 vty_out(vty,
8678 ", mark translated RTs for VPNv4 route filtering");
8679 else if (route_filter_v4)
8680 vty_out(vty,
8681 ", attach RT as-is for VPNv4 route filtering");
8682 else if (route_filter_translated_v6)
** CID 1473045: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8695 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473045: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8695 in route_vty_out_detail_header()
8689 vty_out(vty,
8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart");
8691 else if (no_llgr)
8692 vty_out(vty,
8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations");
8694 else if (accept_own_nexthop)
>>> CID 1473045: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", accept loca...".
8695 vty_out(vty,
8696 ", accept local nexthop");
8697 else if (blackhole)
8698 vty_out(vty, ", inform peer to blackhole prefix");
8699 else if (no_export)
8700 vty_out(vty, ", not advertised to EBGP peer");
** CID 1473044: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8689 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473044: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8689 in route_vty_out_detail_header()
8683 vty_out(vty,
8684 ", mark translated RTs for VPNv6 route filtering");
8685 else if (route_filter_v6)
8686 vty_out(vty,
8687 ", attach RT as-is for VPNv6 route filtering");
8688 else if (llgr_stale)
>>> CID 1473044: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", mark routes...".
8689 vty_out(vty,
8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart");
8691 else if (no_llgr)
8692 vty_out(vty,
8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations");
8694 else if (accept_own_nexthop)
** CID 1473043: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8680 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473043: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8680 in route_vty_out_detail_header()
8674 vty_out(vty,
8675 ", accept own local route exported and imported in different VRF");
8676 else if (route_filter_translated_v4)
8677 vty_out(vty,
8678 ", mark translated RTs for VPNv4 route filtering");
8679 else if (route_filter_v4)
>>> CID 1473043: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", attach RT a...".
8680 vty_out(vty,
8681 ", attach RT as-is for VPNv4 route filtering");
8682 else if (route_filter_translated_v6)
8683 vty_out(vty,
8684 ", mark translated RTs for VPNv6 route filtering");
8685 else if (route_filter_v6)
** CID 1473042: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8698 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473042: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8698 in route_vty_out_detail_header()
8692 vty_out(vty,
8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations");
8694 else if (accept_own_nexthop)
8695 vty_out(vty,
8696 ", accept local nexthop");
8697 else if (blackhole)
>>> CID 1473042: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", inform peer...".
8698 vty_out(vty, ", inform peer to blackhole prefix");
8699 else if (no_export)
8700 vty_out(vty, ", not advertised to EBGP peer");
8701 else if (no_advertise)
8702 vty_out(vty, ", not advertised to any peer");
8703 else if (local_as)
** CID 1473041: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8692 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473041: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8692 in route_vty_out_detail_header()
8686 vty_out(vty,
8687 ", attach RT as-is for VPNv6 route filtering");
8688 else if (llgr_stale)
8689 vty_out(vty,
8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart");
8691 else if (no_llgr)
>>> CID 1473041: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", mark routes...".
8692 vty_out(vty,
8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations");
8694 else if (accept_own_nexthop)
8695 vty_out(vty,
8696 ", accept local nexthop");
8697 else if (blackhole)
** CID 1473040: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8686 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473040: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8686 in route_vty_out_detail_header()
8680 vty_out(vty,
8681 ", attach RT as-is for VPNv4 route filtering");
8682 else if (route_filter_translated_v6)
8683 vty_out(vty,
8684 ", mark translated RTs for VPNv6 route filtering");
8685 else if (route_filter_v6)
>>> CID 1473040: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", attach RT a...".
8686 vty_out(vty,
8687 ", attach RT as-is for VPNv6 route filtering");
8688 else if (llgr_stale)
8689 vty_out(vty,
8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart");
8691 else if (no_llgr)
** CID 1473039: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8706 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473039: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8706 in route_vty_out_detail_header()
8700 vty_out(vty, ", not advertised to EBGP peer");
8701 else if (no_advertise)
8702 vty_out(vty, ", not advertised to any peer");
8703 else if (local_as)
8704 vty_out(vty, ", not advertised outside local AS");
8705 else if (no_peer)
>>> CID 1473039: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", inform EBGP...".
8706 vty_out(vty,
8707 ", inform EBGP peer not to advertise to their EBGP peers");
8708
8709 if (suppress)
8710 vty_out(vty,
8711 ", Advertisements suppressed by an aggregate.");
** CID 1473038: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8674 in route_vty_out_detail_header()
________________________________________________________________________________________________________
*** CID 1473038: Possible Control flow issues (DEADCODE)
/bgpd/bgp_route.c: 8674 in route_vty_out_detail_header()
8668 ? "Default-IP-Routing-Table"
8669 : bgp->name);
8670 } else
8671 vty_out(vty, ", no best path");
8672
8673 if (accept_own)
>>> CID 1473038: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, ", accept own ...".
8674 vty_out(vty,
8675 ", accept own local route exported and imported in different VRF");
8676 else if (route_filter_translated_v4)
8677 vty_out(vty,
8678 ", mark translated RTs for VPNv4 route filtering");
8679 else if (route_filter_v4)
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJn-2Fe-2FcYxwQRe92z94wJ9h2IeCiAHpT4qQ1H2xeFiHn9-2FHj3ajgFCUIpIbqf3DD2wq19-2FFlATDYrLxbl1LnDBYTjJ3hwcSbcO1xScaTLcHeUYe0p9et9PXhtHKhEfr7NexRHASEjXH8iMRLz8Xk5Pek6DJdfYUGWOOHeycphRzhBhA-3D-3D
More information about the dev
mailing list