[dev] New Defects reported by Coverity Scan for freerangerouting/frr
scan-admin at coverity.com
scan-admin at coverity.com
Thu Aug 30 05:34:02 EDT 2018
Hi,
Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1473090: Incorrect expression (NO_EFFECT)
/lib/frr_pthread.c: 335 in fpt_run()
________________________________________________________________________________________________________
*** CID 1473090: Incorrect expression (NO_EFFECT)
/lib/frr_pthread.c: 335 in fpt_run()
329 int sleeper[2];
330 pipe(sleeper);
331 thread_add_read(fpt->master, &fpt_dummy, NULL, sleeper[0], NULL);
332
333 fpt->master->handle_signals = false;
334
>>> CID 1473090: Incorrect expression (NO_EFFECT)
>>> Comparing an array to null is not useful: "fpt->os_name", since the test will always evaluate as true.
335 if (fpt->os_name)
336 frr_pthread_set_name(fpt, NULL, fpt->os_name);
337
338 frr_pthread_notify_running(fpt);
339
340 struct thread task;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlQ4qGCDMUwtzQwD7Q8AXiomJqakEviwurHlWbQTWkBj3o3CJpTUUuqx1WAo4Jyw7YifUPHrnxUiUoWrHC9VHQVNa6iqpLV3gq6p3NBgU-2BoOrmmKuPMfIt8-2BptigyBPKF0cvYC5pSF6b93uCNumyXZ7mLnGJIYyhNI6fu6Ae7gNug-3D-3D
More information about the dev
mailing list