New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1534374:  Control flow issues  (MISSING_BREAK)
/bgpd/bgp_mplsvpn_snmp.c: 1613 in mplsL3vpnRteTable()


________________________________________________________________________________________________________
*** CID 1534374:  Control flow issues  (MISSING_BREAK)
/bgpd/bgp_mplsvpn_snmp.c: 1613 in mplsL3vpnRteTable()
1607     
1608     	case MPLSL3VPNVRFRTEINETCIDRIFINDEX:
1609     		if (pi->nexthop && pi->nexthop->nexthop)
1610     			return SNMP_INTEGER(pi->nexthop->nexthop->ifindex);
1611     		else
1612     			return SNMP_INTEGER(0);
>>>     CID 1534374:  Control flow issues  (MISSING_BREAK)
>>>     The case for value "8" is not terminated by a "break" statement.
1613     	case MPLSL3VPNVRFRTEINETCIDRTYPE:
1614     		if (pi->nexthop && pi->nexthop->nexthop) {
1615     			switch (pi->nexthop->nexthop->type) {
1616     			case NEXTHOP_TYPE_IFINDEX:
1617     				return SNMP_INTEGER(
1618     					MPLSL3VPNVRFRTECIDRTYPELOCAL);

** CID 1534373:  Control flow issues  (DEADCODE)
/pimd/pim_zpthread.c: 57 in pim_mlag_zebra_fill_header()


________________________________________________________________________________________________________
*** CID 1534373:  Control flow issues  (DEADCODE)
/pimd/pim_zpthread.c: 57 in pim_mlag_zebra_fill_header()
51     		fill_msg_type = MLAG_MROUTE_ADD_BULK;
52     		break;
53     	case MLAG_MROUTE_DEL:
54     		data_len = sizeof(struct mlag_mroute_del);
55     		fill_msg_type = MLAG_MROUTE_DEL_BULK;
56     		break;
>>>     CID 1534373:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "case MLAG_MSG_NONE:".
57     	case MLAG_MSG_NONE:
58     	case MLAG_STATUS_UPDATE:
59     	case MLAG_DUMP:
60     	case MLAG_MROUTE_ADD_BULK:
61     	case MLAG_MROUTE_DEL_BULK:
62     	case MLAG_PIM_CFG_DUMP:

** CID 1534372:  Control flow issues  (DEADCODE)
/zebra/zebra_nhg.c: 2296 in nexthop_active()


________________________________________________________________________________________________________
*** CID 1534372:  Control flow issues  (DEADCODE)
/zebra/zebra_nhg.c: 2296 in nexthop_active()
2290     		break;
2291     	case AFI_IP6:
2292     		p.family = AF_INET6;
2293     		p.prefixlen = IPV6_MAX_BITLEN;
2294     		p.u.prefix6 = nexthop->gate.ipv6;
2295     		break;
>>>     CID 1534372:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "case AFI_UNSPEC:".
2296     	case AFI_UNSPEC:
2297     	case AFI_L2VPN:
2298     	case AFI_MAX:
2299     		assert(afi != AFI_IP && afi != AFI_IP6);
2300     		break;
2301     	}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DYz_J_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTw0XLjAcjKeegqJoPAyDey4FxicIfyuGOS4REZ1rdu2SRs7KWEMUWzI2KwnlRzpcyJfgMa9-2BQoqlEe30DTdHA9gtvqIUBFPpkLzhBHE7wwjoTgb6n0XqR19TfiPLUrdPhroEvtfIvJyzypUrSpqGJbCZMh-2Bq-2FEZIlSJ-2B1NoECYGEw-3D-3D