New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1534507:    (NULL_RETURNS)
/zebra/zebra_l2_bridge_if.c: 214 in zebra_l2_bridge_if_vlan_update()
/zebra/zebra_l2_bridge_if.c: 216 in zebra_l2_bridge_if_vlan_update()


________________________________________________________________________________________________________
*** CID 1534507:    (NULL_RETURNS)
/zebra/zebra_l2_bridge_if.c: 214 in zebra_l2_bridge_if_vlan_update()
208     	struct zebra_l2_bridge_vlan *bvlan;
209     
210     	zif = (struct zebra_if *)ifp->info;
211     	bvlan = zebra_l2_bridge_if_vlan_find(zif, bvl->vid);
212     
213     	if (chgflags & ZEBRA_BRIDGEIF_ACCESS_BD_CHANGE)
>>>     CID 1534507:    (NULL_RETURNS)
>>>     Dereferencing "bvlan", which is known to be "NULL".
214     		bvlan->access_bd = bvl->access_bd;
215     
216     	if (!bvlan->access_bd)
217     		return zebra_l2_bridge_if_vlan_del(ifp, bvl->vid);
218     
219     	return 0;
/zebra/zebra_l2_bridge_if.c: 216 in zebra_l2_bridge_if_vlan_update()
210     	zif = (struct zebra_if *)ifp->info;
211     	bvlan = zebra_l2_bridge_if_vlan_find(zif, bvl->vid);
212     
213     	if (chgflags & ZEBRA_BRIDGEIF_ACCESS_BD_CHANGE)
214     		bvlan->access_bd = bvl->access_bd;
215     
>>>     CID 1534507:    (NULL_RETURNS)
>>>     Dereferencing "bvlan", which is known to be "NULL".
216     	if (!bvlan->access_bd)
217     		return zebra_l2_bridge_if_vlan_del(ifp, bvl->vid);
218     
219     	return 0;
220     }
221     

** CID 1534506:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/zebra/rt_netlink.c: 1370 in _netlink_nexthop_encode_dvni_label()


________________________________________________________________________________________________________
*** CID 1534506:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/zebra/rt_netlink.c: 1370 in _netlink_nexthop_encode_dvni_label()
1364     					       mpls_lse_t *out_lse,
1365     					       size_t buflen, char *label_buf)
1366     {
1367     	struct in_addr ipv4;
1368     
1369     	if (!nl_attr_put64(nlmsg, buflen, LWTUNNEL_IP_ID,
>>>     CID 1534506:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "(_uint64_t)out_lse[0] >> 32" is 0 regardless of the values of its operands. This occurs as an argument to a function call.
1370     			   htonll((uint64_t)out_lse[0])))
1371     		return false;
1372     
1373     	if (nexthop->type == NEXTHOP_TYPE_IPV4_IFINDEX) {
1374     		if (!nl_attr_put(nlmsg, buflen, LWTUNNEL_IP_DST,
1375     				 &nexthop->gate.ipv4, 4))


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DoP3D_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTxDeK-2FyglLPD9-2BSBJQaaiZhEgOWVvHypkh-2BLrcU-2BkD3ZiWy1NKfLddP93438dUzf4movSFo4pI-2FlF0vsEzdQg02-2FCmZXTZkpR7Ej8YwT-2FVnYii9M65zfjimR6mnV7brq8qCuYK6rc92tbmh6Vf11SNxG9sw9wb7azdCV-2BzaxLlbXg-3D-3D