New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1534617:  Uninitialized variables  (UNINIT)
/bgpd/bgp_rpki.c: 1417 in show_rpki_prefix_magic()


________________________________________________________________________________________________________
*** CID 1534617:  Uninitialized variables  (UNINIT)
/bgpd/bgp_rpki.c: 1417 in show_rpki_prefix_magic()
1411     	}
1412     
1413     	struct pfx_record *matches = NULL;
1414     	unsigned int match_count = 0;
1415     	enum pfxv_state result;
1416     
>>>     CID 1534617:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "as" when calling "pfx_table_validate_r".
1417     	if (pfx_table_validate_r(rtr_config->pfx_table, &matches, &match_count,
1418     				 as, &addr, prefix->prefixlen,
1419     				 &result) != PFX_SUCCESS) {
1420     		if (!json)
1421     			vty_out(vty, "Prefix lookup failed\n");
1422     		return CMD_WARNING;

** CID 1534616:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_route.c: 6985 in bgp_static_set_safi()


________________________________________________________________________________________________________
*** CID 1534616:  Null pointer dereferences  (REVERSE_INULL)
/bgpd/bgp_route.c: 6985 in bgp_static_set_safi()
6979     		bgp_static->valid = 0;
6980     		bgp_static->igpmetric = 0;
6981     		bgp_static->igpnexthop.s_addr = INADDR_ANY;
6982     		bgp_static->label = label;
6983     		bgp_static->prd = prd;
6984     
>>>     CID 1534616:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "rd_str" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
6985     		if (rd_str)
6986     			bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str);
6987     		if (rmap_str) {
6988     			XFREE(MTYPE_ROUTE_MAP_NAME, bgp_static->rmap.name);
6989     			route_map_counter_decrement(bgp_static->rmap.map);
6990     			bgp_static->rmap.name =


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DWdzQ_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTwocXR-2FXexgMG98hvUFdOi3XgzxAuHNCKTmVVj-2B27YUfmopaBL768FhgvKAJXXk-2BXkO6-2BTFIkJlfCcUpke2pWq5K9TmhxvIFCdMao7HXHI9xf6uqOT5F6jA1y8AnKnH-2F8g0ysmRuRtZwgZhJMKdRGsM-2FZCF2-2B-2FEYpXTzR5KeUJM8g-3D-3D