New Defects reported by Coverity Scan for freerangerouting/frr

scan-admin at coverity.com scan-admin at coverity.com
Fri Feb 17 22:18:14 UTC 2023


Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1534606:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/bgpd/bgpd.c: 2766 in peer_group2peer_config_copy()


________________________________________________________________________________________________________
*** CID 1534606:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/bgpd/bgpd.c: 2766 in peer_group2peer_config_copy()
2760     	/* capability extended-nexthop apply */
2761     	if (!CHECK_FLAG(peer->flags_override, PEER_FLAG_CAPABILITY_ENHE))
2762     		if (CHECK_FLAG(conf->flags, PEER_FLAG_CAPABILITY_ENHE))
2763     			SET_FLAG(peer->flags, PEER_FLAG_CAPABILITY_ENHE);
2764     
2765     	/* capability software-version apply */
>>>     CID 1534606:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "peer->flags_override & (68719476736ULL /* 1ULL << 36 */)" is always 0 regardless of the values of its operands. This occurs as the logical operand of "!".
2766     	if (!CHECK_FLAG(peer->flags_override,
2767     			PEER_FLAG_CAPABILITY_SOFT_VERSION))
2768     		if (CHECK_FLAG(conf->flags, PEER_FLAG_CAPABILITY_SOFT_VERSION))
2769     			SET_FLAG(peer->flags,
2770     				 PEER_FLAG_CAPABILITY_SOFT_VERSION);
2771     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3Du0_m_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTwPlbRhNYlOJF6AbvCR8Wt4NtCsYw39MHdC6kXCUmidVaytQBxAod6ObhLABPl9kXBy036sWI5k1dZTlQpffDBAZSJfXHW07WU52X7f-2FPgZ3ak4VrYSvdAmUaIw2XZOtTRNzBqRLx5NCai5MWJGgpYeyFg9eUhW5uetesWJpjQYmg-3D-3D




More information about the dev mailing list