New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1602463:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_msdp_packet.c: 422 in pim_msdp_pkt_sa_gen()


________________________________________________________________________________________________________
*** CID 1602463:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_msdp_packet.c: 422 in pim_msdp_pkt_sa_gen()
416     
417     	sa_count = 0;
418     	if (PIM_DEBUG_MSDP_INTERNAL) {
419     		zlog_debug("  sa gen  %d", local_cnt);
420     	}
421     
>>>     CID 1602463:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "pim_get_all_mcast_group" without checking return value (as is done elsewhere 9 out of 10 times).
422     	pim_get_all_mcast_group(&group_all);
423     	pim_msdp_originator_id(pim, &group_all, &rp);
424     	local_cnt = pim_msdp_pkt_sa_fill_hdr(pim, local_cnt, rp);
425     
426     	for (ALL_LIST_ELEMENTS_RO(pim->msdp.sa_list, sanode, sa)) {
427     		if (!(sa->flags & PIM_MSDP_SAF_LOCAL)) {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4jkWudbux5UNqYsSt9ZXO3s9m3KMDrlSX-2Bp41IzjejfmdC2hinnLY-2BZ6PvlTenLZs-3DNR3S_t0zeZlCsA34Fiw17aIfmh-2F3kFs1q7rysihvAefHXY7-2BDIe2a6RJ-2FNF6wWxRDcRBlV2iRC3L3WWRq33DPaHWDR1S596dZhDKpXx180OldY3bFavkTv0Un1UO9fIilGL1VcDEtOYuYYNTkmtnoAPgbkwn-2FlUacKy0ezol3Eoy7f8oBt4GFMCVo8UeyTxBRZeK68Kg5IIes4Ka1XDoGZd5c6Q-3D-3D