New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1602521:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_rp.c: 1110 in pim_rp_g()


________________________________________________________________________________________________________
*** CID 1602521:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_rp.c: 1110 in pim_rp_g()
1104     		if (PIM_DEBUG_PIM_NHT_RP)
1105     			zlog_debug(
1106     				"%s: NHT Register RP addr %pPA grp %pFX with Zebra",
1107     				__func__, &nht_p, &rp_info->group);
1108     		pim_nht_find_or_track(pim, nht_p, NULL, rp_info, NULL);
1109     		pim_rpf_set_refresh_time(pim);
>>>     CID 1602521:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "pim_nht_lookup_ecmp" without checking return value (as is done elsewhere 9 out of 11 times).
1110     		pim_nht_lookup_ecmp(pim, &rp_info->rp.source_nexthop, nht_p, &rp_info->group, true);
1111     		return (&rp_info->rp);
1112     	}
1113     
1114     	// About to Go Down
1115     	return NULL;

** CID 1602520:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_tib.c: 38 in tib_sg_oil_setup()


________________________________________________________________________________________________________
*** CID 1602520:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_tib.c: 38 in tib_sg_oil_setup()
32     
33     	pim_addr_to_prefix(&grp, sg.grp);
34     
35     	up = pim_upstream_find(pim, &sg);
36     	if (up) {
37     		memcpy(&nexthop, &up->rpf.source_nexthop, sizeof(struct pim_nexthop));
>>>     CID 1602520:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "pim_nht_lookup_ecmp" without checking return value (as is done elsewhere 9 out of 11 times).
38     		pim_nht_lookup_ecmp(pim, &nexthop, vif_source, &grp, false);
39     		if (nexthop.interface)
40     			input_iface_vif_index = pim_if_find_vifindex_by_ifindex(
41     				pim, nexthop.interface->ifindex);
42     	} else
43     		input_iface_vif_index = pim_nht_lookup_ecmp_if_vif_index(pim, vif_source, &grp);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4jkWudbux5UNqYsSt9ZXO3s9m3KMDrlSX-2Bp41IzjejfmdC2hinnLY-2BZ6PvlTenLZs-3DVvqJ_t0zeZlCsA34Fiw17aIfmh-2F3kFs1q7rysihvAefHXY7-2BFvGW3759k7cZ3usDcmFRejiGbQLAi-2BCtOaZReXqF6lHhdkWD4I9bAUFbXCU01pkWE7aerC8dDvFw3PWj3uZaxWmMSdpeE9HiDjDhoizs2ntil1wem71bWZidbtHzY2X-2BxdkdwQVnYMJuhwD5AmOv31MZMkRJrBF58RLhsUhRqXQ-3D-3D