October 2017 - dev - lists.frrouting.org

new debian build instructions
by Rodny Molina 12 Oct '17

12 Oct '17

Hi folks, I just noticed that the original ‘debian’ folder has been moved to ‘debianpkg’ (which is breaking our build), and that there’s a new set of instructions for building FRR.deb package. However, these new instructions (debianpkg/README.deb_build.md) are not working for me. Basically, we are missing a ‘changelog’ and (apparently) some other debian requirements. So a couple of questions: * Do you have any cheatsheet for non-debian experts? * Are (somewhat) drastic changes like this one expected in stable (3.0) branches? Was this discussed somewhere and i totally missed it? Thanks. /Rodny

2 3

Re: [dev] Default-information originate for OSPFv3
by Donald Sharp 11 Oct '17

11 Oct '17

Sonum - The default information originate command has not been implemented for ospfv3. I would recommend creating a static v6 default route and then redistributing that into ospfv3 donald On Wed, Oct 11, 2017 at 6:44 PM, Sonum Mathur via dev <dev(a)lists.frrouting.org> wrote: > _______________________________________________ > dev mailing list > dev(a)lists.frrouting.org > https://lists.frrouting.org/listinfo/dev > > > ---------- Forwarded message ---------- > From: Sonum Mathur <sonum(a)pluribusnetworks.com> > To: dev(a)lists.frrouting.org > Cc: > Bcc: > Date: Wed, 11 Oct 2017 15:44:17 -0700 > Subject: Default-information originate for OSPFv3 > Hey folks, > > For injecting a default route into OSPFv3 normal area, we don't have default-information originate command in FRR. > Wanted to check if this is achieved differently or if there is a patch available somewhere. > > Looking for functionality similar to what we have in OSPF > default-information originate [<always|metric (0-16777214)|metric-type (1-2)|route-map WORD>] > > Thanks > -- > Sonum >

1 0

Default-information originate for OSPFv3
by Sonum Mathur 11 Oct '17

11 Oct '17

Hey folks, For injecting a default route into OSPFv3 normal area, we don't have default-information originate command in FRR. Wanted to check if this is achieved differently or if there is a patch available somewhere. Looking for functionalitysimilar to what we have in OSPF default-information originate [<always|metric (0-16777214)|metric-type (1-2)|route-map WORD>] Thanks -- Sonum

1 0

Notice for TSC meeting.
by Donald Sharp 10 Oct '17

10 Oct '17

1) Consolidate the maintainers lists Once this is consolidated we will update the website. Please be prepared to discuss what contributions people have played in the last year. thanks! donald

1 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 09 Oct '17

09 Oct '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1457695: API usage errors (VARARGS) /lib/csv.c: 288 in csv_encode_record() ________________________________________________________________________________________________________ *** CID 1457695: API usage errors (VARARGS) /lib/csv.c: 288 in csv_encode_record() 282 csv_field_t *fld = NULL; 283 int i; 284 285 va_start(list, count); 286 str = csv_field_iter(rec, &fld); 287 if (!fld) >>> CID 1457695: API usage errors (VARARGS) >>> va_end was not called for "list". 288 return NULL; 289 for (tempc = 0; tempc < count; tempc++) { 290 col = va_arg(list, char *); 291 for (i = 0; i < fld->field_len; i++) { 292 str[i] = col[i]; 293 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 04 Oct '17

04 Oct '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1457320: Error handling issues (NEGATIVE_RETURNS) /ldpd/ldpd.c: 453 in start_child() ________________________________________________________________________________________________________ *** CID 1457320: Error handling issues (NEGATIVE_RETURNS) /ldpd/ldpd.c: 453 in start_child() 447 close(fd_async); 448 close(fd_sync); 449 return (pid); 450 } 451 452 nullfd = open("/dev/null", O_RDONLY | O_NOCTTY); >>> CID 1457320: Error handling issues (NEGATIVE_RETURNS) >>> "nullfd" is passed to a parameter that cannot be negative. 453 dup2(nullfd, 0); 454 dup2(nullfd, 1); 455 dup2(nullfd, 2); 456 close(nullfd); 457 458 if (dup2(fd_async, LDPD_FD_ASYNC) == -1) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

OSPFv2 VRF support is now available
by Chirag Shah 04 Oct '17

04 Oct '17

Hi All, We have OSPFv2 VRF-lite support is now available in FRR master. List of ospf interface and list of area are part of "struct ospf" which would divide per vrf. Type1-5 LSAs and Opaque LSAs are handled i vrf aware instance. LSA and LSDB would be operate on per area and per ospf interface which would use its parent ospf vrf_id. OSPF Route Add/delete will have struct ospf or vrf_id passed as argument and ospf->vrf_id used to program the routes to zebra. External route are vrf aware. BFD sessions are vrf aware. Primary OSPF show CLIs like neighbor, interface, database, route are converted to take vrf <all | word> as arguement and follows "show ip ospf vrf [all|word] ....." format. json output containing VRF anchor point will be added in future check-ins. A new CLI 'show ip ospf vrfs' outlines all vrf configured ospf instances. MI-OSPF with VRF is not tested but configuration cli allows the combination. Kind Regards, Chirag Shah

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 03 Oct '17

03 Oct '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1457301: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_te.c: 1172 in ospf_mpls_te_lsa_new() ________________________________________________________________________________________________________ *** CID 1457301: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_te.c: 1172 in ospf_mpls_te_lsa_new() 1166 lsa_type = OSPF_OPAQUE_AREA_LSA; 1167 } 1168 tmp = SET_OPAQUE_LSID(OPAQUE_TYPE_INTER_AS_LSA, lp->instance); 1169 lsa_id.s_addr = htonl(tmp); 1170 1171 if (!ospf) >>> CID 1457301: Resource leaks (RESOURCE_LEAK) >>> Variable "s" going out of scope leaks the storage it points to. 1172 return NULL; 1173 1174 lsa_header_set(s, options, lsa_type, lsa_id, ospf->router_id); 1175 } else { 1176 options |= LSA_OPTIONS_GET(area); /* Get area default option */ 1177 options |= LSA_OPTIONS_NSSA_GET(area); ** CID 1457300: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_vty.c: 8730 in config_write_interface_one() ________________________________________________________________________________________________________ *** CID 1457300: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_vty.c: 8730 in config_write_interface_one() 8724 vty_out(vty, " %s", 8725 inet_ntoa(rn->p.u.prefix4)); 8726 vty_out(vty, "\n"); 8727 } 8728 8729 /* Cryptographic Authentication Key print. */ >>> CID 1457300: Null pointer dereferences (FORWARD_NULL) >>> Comparing "params" to null implies that "params" might be null. 8730 if (params && params->auth_crypt) { 8731 for (ALL_LIST_ELEMENTS_RO(params->auth_crypt, 8732 n2, ck)) { 8733 vty_out(vty, 8734 " ip ospf message-digest-key %d md5 %s", 8735 ck->key_id, ck->auth_key); ** CID 1457299: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_ri.c: 664 in ospf_router_info_lsa_originate1() ________________________________________________________________________________________________________ *** CID 1457299: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_ri.c: 664 in ospf_router_info_lsa_originate1() 658 659 /* Get ospf info */ 660 top = ospf_lookup_by_vrf_id(vrf_id); 661 if (top == NULL) { 662 zlog_debug("%s: ospf instance not found for vrf id %u", 663 __PRETTY_FUNCTION__, vrf_id); >>> CID 1457299: Resource leaks (RESOURCE_LEAK) >>> Variable "new" going out of scope leaks the storage it points to. 664 return rc; 665 } 666 667 /* Install this LSA into LSDB. */ 668 if (ospf_lsa_install(top, NULL /*oi */, new) == NULL) { 669 zlog_warn( ** CID 1457298: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_network.c: 268 in ospf_sock_init() ________________________________________________________________________________________________________ *** CID 1457298: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_network.c: 268 in ospf_sock_init() 262 ospf->fd = ospf_sock; 263 out: 264 if (ospfd_privs.change(ZPRIVS_LOWER)) { 265 zlog_err("ospf_sock_init: could not lower privs, %s", 266 safe_strerror(errno)); 267 } >>> CID 1457298: Resource leaks (RESOURCE_LEAK) >>> Handle variable "ospf_sock" going out of scope leaks the handle. 268 return ret; ** CID 1457297: (RESOURCE_LEAK) /ospfd/ospf_zebra.c: 1140 in ospf_distribute_list_update() /ospfd/ospf_zebra.c: 1144 in ospf_distribute_list_update() ________________________________________________________________________________________________________ *** CID 1457297: (RESOURCE_LEAK) /ospfd/ospf_zebra.c: 1140 in ospf_distribute_list_update() 1134 args[0] = ospf; 1135 args[1] = (void *)((ptrdiff_t) type); 1136 1137 /* External info does not exist. */ 1138 ext = ospf_external_lookup(type, instance); 1139 if (!ext || !(rt = EXTERNAL_INFO(ext))) >>> CID 1457297: (RESOURCE_LEAK) >>> Variable "args" going out of scope leaks the storage it points to. 1140 return; 1141 1142 /* If exists previously invoked thread, then let it continue. */ 1143 if (ospf->t_distribute_update) 1144 return; 1145 /ospfd/ospf_zebra.c: 1144 in ospf_distribute_list_update() 1138 ext = ospf_external_lookup(type, instance); 1139 if (!ext || !(rt = EXTERNAL_INFO(ext))) 1140 return; 1141 1142 /* If exists previously invoked thread, then let it continue. */ 1143 if (ospf->t_distribute_update) >>> CID 1457297: (RESOURCE_LEAK) >>> Variable "args" going out of scope leaks the storage it points to. 1144 return; 1145 1146 /* Set timer. */ 1147 ospf->t_distribute_update = NULL; 1148 thread_add_timer_msec(master, ospf_distribute_list_update_timer, 1149 (void **)args, ospf->min_ls_interval, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0