December 2024 - dev - lists.frrouting.org

FRR Release 10.2
by Jafar Al-Gharaibeh 27 Mar '26

27 Mar '26

Dear FRR Community, We are pleased to announce FRR release 10.2. Release notes are available at: https://frrouting.org/release https://github.com/FRRouting/frr/releases Please let us know if you see any issues. Cheers, The FRR Development Team!

2 9

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 16 Dec '24

16 Dec '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1602521: Error handling issues (CHECKED_RETURN) /pimd/pim_rp.c: 1110 in pim_rp_g() ________________________________________________________________________________________________________ *** CID 1602521: Error handling issues (CHECKED_RETURN) /pimd/pim_rp.c: 1110 in pim_rp_g() 1104 if (PIM_DEBUG_PIM_NHT_RP) 1105 zlog_debug( 1106 "%s: NHT Register RP addr %pPA grp %pFX with Zebra", 1107 __func__, &nht_p, &rp_info->group); 1108 pim_nht_find_or_track(pim, nht_p, NULL, rp_info, NULL); 1109 pim_rpf_set_refresh_time(pim); >>> CID 1602521: Error handling issues (CHECKED_RETURN) >>> Calling "pim_nht_lookup_ecmp" without checking return value (as is done elsewhere 9 out of 11 times). 1110 pim_nht_lookup_ecmp(pim, &rp_info->rp.source_nexthop, nht_p, &rp_info->group, true); 1111 return (&rp_info->rp); 1112 } 1113 1114 // About to Go Down 1115 return NULL; ** CID 1602520: Error handling issues (CHECKED_RETURN) /pimd/pim_tib.c: 38 in tib_sg_oil_setup() ________________________________________________________________________________________________________ *** CID 1602520: Error handling issues (CHECKED_RETURN) /pimd/pim_tib.c: 38 in tib_sg_oil_setup() 32 33 pim_addr_to_prefix(&grp, sg.grp); 34 35 up = pim_upstream_find(pim, &sg); 36 if (up) { 37 memcpy(&nexthop, &up->rpf.source_nexthop, sizeof(struct pim_nexthop)); >>> CID 1602520: Error handling issues (CHECKED_RETURN) >>> Calling "pim_nht_lookup_ecmp" without checking return value (as is done elsewhere 9 out of 11 times). 38 pim_nht_lookup_ecmp(pim, &nexthop, vif_source, &grp, false); 39 if (nexthop.interface) 40 input_iface_vif_index = pim_if_find_vifindex_by_ifindex( 41 pim, nexthop.interface->ifindex); 42 } else 43 input_iface_vif_index = pim_nht_lookup_ecmp_if_vif_index(pim, vif_source, &grp); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

Re: [dev] Supporting Graceful Restart for more SAFIs (e.g. EVPN)
by Donald Sharp 13 Dec '24

13 Dec '24

As I recall from the discussion during the time GR and EVPN was added was that there was uncertainty about behaviors and what we had time for in relation to testing. So it was not added. From my perspective I would love to have someone work on this bit of code. I would like though the addition of a topotest to show that it actually works. Donald > On Dec 12, 2024, at 11:05 AM, Lukas Stockner via dev <dev(a)lists.frrouting.org> wrote: > > <mime-attachment> > _______________________________________________ > dev mailing list > dev(a)lists.frrouting.org > https://lists.frrouting.org/listinfo/dev

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 12 Dec '24

12 Dec '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1602463: Error handling issues (CHECKED_RETURN) /pimd/pim_msdp_packet.c: 422 in pim_msdp_pkt_sa_gen() ________________________________________________________________________________________________________ *** CID 1602463: Error handling issues (CHECKED_RETURN) /pimd/pim_msdp_packet.c: 422 in pim_msdp_pkt_sa_gen() 416 417 sa_count = 0; 418 if (PIM_DEBUG_MSDP_INTERNAL) { 419 zlog_debug(" sa gen %d", local_cnt); 420 } 421 >>> CID 1602463: Error handling issues (CHECKED_RETURN) >>> Calling "pim_get_all_mcast_group" without checking return value (as is done elsewhere 9 out of 10 times). 422 pim_get_all_mcast_group(&group_all); 423 pim_msdp_originator_id(pim, &group_all, &rp); 424 local_cnt = pim_msdp_pkt_sa_fill_hdr(pim, local_cnt, rp); 425 426 for (ALL_LIST_ELEMENTS_RO(pim->msdp.sa_list, sanode, sa)) { 427 if (!(sa->flags & PIM_MSDP_SAF_LOCAL)) { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

Supporting Graceful Restart for more SAFIs (e.g. EVPN)
by Lukas Stockner 12 Dec '24

12 Dec '24

Hi all, I've been looking into using FRR as a RR for EVPN with Graceful Restart enabled and found that this currently does not work since FOREACH_AFI_SAFI_NSF only goes through the unicast, multicast and MPLS-VPN SAFIs, so EVPN routes aren't preserved and peers which only negotiate EVPN are deleted on disconnect. However, I can't see any reason why such a limitation would be necessary, and simply removing it and using the general FOREACH_AFI_SAFI in the GH code appears to work just fine. >From what I can tell through git blame, it seems like the GH code predates these SAFIs, its loop boundaries weren't updated when e.g. EVPN was added, and when the FOREACH #define was introduced to clean the code up, it was assumed that the difference is intentional. I'd be happy to open a PR to change this, just wanted to check if anyone is aware of a reason to keep this as-is. Cheers, Lukas

1 0