July 2024 - dev - lists.frrouting.org

Re: [dev] BMP Issue in FRR 10.0
by Donatas Abraitis 07 Aug '24

07 Aug '24

You are checking the master branch (development) documentation. You should use https://docs.frrouting.org/en/stable-10.0/bmp.html. On Tue, Jul 23, 2024 at 3:08 PM Boris Hassanov via dev < dev(a)lists.frrouting.org> wrote: > > > > ---------- Forwarded message ---------- > From: Boris Hassanov <bhassanov(a)yahoo.com> > To: "dev(a)lists.frrouting.org" <dev(a)lists.frrouting.org> > Cc: > Bcc: > Date: Mon, 17 Jun 2024 17:12:18 +0000 (UTC) > Subject: BMP Issue in FRR 10.0 > Hi all, > > During the testing I found strange BMP issue. RFC 7854 describes several > types of BMP messages, one of them is Stats Report ( > https://www.rfc-editor.org/rfc/rfc7854#page-13) > > The FRR documentation (. > https://docs.frrouting.org/en/latest/bmp.html#bmp-session-configuration ) > explicitly says: > " > > - > > the following statistics codes are implemented: > - > > 0: count of prefixes rejected > - > > 2: count of duplicate prefix withdrawals > - > > 3: count of prefixes with loop in cluster id > - > > 4: count of prefixes with loop in AS-path > - > > 5: count of prefixes with loop in originator > - > > 7: count of routes in adj-rib-in > - > > 8: count of routes in Loc-RIB > - > > 11: count of updates subjected to RFC 7607 > <https://datatracker.ietf.org/doc/html/rfc7607.html> “treat as > withdrawal” handling due to errors > - > > 65531: *experimental* count of prefixes rejected due to invalid > next-hop > > Note that stat items 3, 4 and 5 are specified to count updates, but > FRR implements them as prefix-based counters. > > " > The issue is that I do not see Stats Types 7 and 8 in the BMP message from > FRR towards BMP collector (goBMP in my test setup): > > [image: Inline image] > > > There are only 7 statistic types and no statistic codes 7 and 8. > > Is this a bug or I missed something in BMP config ? > > Here is the BMP config oof the FRR for the reference: > > bmp targets ubuntu-BMP > > bmp stats interval 300 > > bmp monitor ipv4 unicast pre-policy > > bmp monitor ipv4 unicast loc-rib > > bmp connect 10.30.131.101 port 5050 min-retry 30000 max-retry 3000 > source-interface eth2 > > exit > > FRR1# sh ver > > FRRouting 10.0_git (FRR1) on Linux(5.15.0-102-generic). > > Thank you in advance for the clarification. > > > SY, > Boris > > > > > > > > > ---------- Forwarded message ---------- > From: Boris Hassanov via dev <dev(a)lists.frrouting.org> > To: "dev(a)lists.frrouting.org" <dev(a)lists.frrouting.org> > Cc: > Bcc: > Date: Mon, 17 Jun 2024 17:12:18 +0000 (UTC) > Subject: [dev] BMP Issue in FRR 10.0 > _______________________________________________ > dev mailing list > dev(a)lists.frrouting.org > https://lists.frrouting.org/listinfo/dev > -- Donatas

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 31 Jul '24

31 Jul '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1598684: Null pointer dereferences (NULL_RETURNS) /pimd/pim_cmd.c: 2847 in clear_ip_msdp_peer_magic() ________________________________________________________________________________________________________ *** CID 1598684: Null pointer dereferences (NULL_RETURNS) /pimd/pim_cmd.c: 2847 in clear_ip_msdp_peer_magic() 2841 vrf = vrf_lookup_by_name(vrfname); 2842 if (vrf == NULL) 2843 return CMD_WARNING; 2844 } else 2845 vrf = vrf_lookup_by_id(VRF_DEFAULT); 2846 >>> CID 1598684: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "vrf", which is known to be "NULL". 2847 pim = vrf->info; 2848 for (ALL_LIST_ELEMENTS_RO(pim->msdp.peer_list, node, mp)) { 2849 if (mp->peer.s_addr != peer.s_addr) 2850 continue; 2851 2852 pim_msdp_peer_restart(mp); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 22 Jul '24

22 Jul '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1598496: (USE_AFTER_FREE) /bgpd/bgp_evpn.c: 6344 in bgp_evpn_free() /bgpd/bgp_evpn.c: 6344 in bgp_evpn_free() ________________________________________________________________________________________________________ *** CID 1598496: (USE_AFTER_FREE) /bgpd/bgp_evpn.c: 6344 in bgp_evpn_free() 6338 for (dest = zebra_announce_first(&bm->zebra_announce_head); dest; 6339 dest = dest_next) { 6340 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 6341 if (dest->za_vpn == vpn) { 6342 bgp_path_info_unlock(dest->za_bgp_pi); 6343 bgp_dest_unlock_node(dest); >>> CID 1598496: (USE_AFTER_FREE) >>> Calling "zebra_announce_del" dereferences freed pointer "dest". 6344 zebra_announce_del(&bm->zebra_announce_head, dest); 6345 } 6346 } 6347 6348 bgp_evpn_remote_ip_hash_destroy(vpn); 6349 bgp_evpn_vni_es_cleanup(vpn); /bgpd/bgp_evpn.c: 6344 in bgp_evpn_free() 6338 for (dest = zebra_announce_first(&bm->zebra_announce_head); dest; 6339 dest = dest_next) { 6340 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 6341 if (dest->za_vpn == vpn) { 6342 bgp_path_info_unlock(dest->za_bgp_pi); 6343 bgp_dest_unlock_node(dest); >>> CID 1598496: (USE_AFTER_FREE) >>> Passing freed pointer "dest" as an argument to "zebra_announce_del". 6344 zebra_announce_del(&bm->zebra_announce_head, dest); 6345 } 6346 } 6347 6348 bgp_evpn_remote_ip_hash_destroy(vpn); 6349 bgp_evpn_vni_es_cleanup(vpn); /bgpd/bgp_evpn.c: 6344 in bgp_evpn_free() 6338 for (dest = zebra_announce_first(&bm->zebra_announce_head); dest; 6339 dest = dest_next) { 6340 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 6341 if (dest->za_vpn == vpn) { 6342 bgp_path_info_unlock(dest->za_bgp_pi); 6343 bgp_dest_unlock_node(dest); >>> CID 1598496: (USE_AFTER_FREE) >>> Calling "zebra_announce_del" dereferences freed pointer "dest". 6344 zebra_announce_del(&bm->zebra_announce_head, dest); 6345 } 6346 } 6347 6348 bgp_evpn_remote_ip_hash_destroy(vpn); 6349 bgp_evpn_vni_es_cleanup(vpn); /bgpd/bgp_evpn.c: 6344 in bgp_evpn_free() 6338 for (dest = zebra_announce_first(&bm->zebra_announce_head); dest; 6339 dest = dest_next) { 6340 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 6341 if (dest->za_vpn == vpn) { 6342 bgp_path_info_unlock(dest->za_bgp_pi); 6343 bgp_dest_unlock_node(dest); >>> CID 1598496: (USE_AFTER_FREE) >>> Passing freed pointer "dest" as an argument to "zebra_announce_del". 6344 zebra_announce_del(&bm->zebra_announce_head, dest); 6345 } 6346 } 6347 6348 bgp_evpn_remote_ip_hash_destroy(vpn); 6349 bgp_evpn_vni_es_cleanup(vpn); ** CID 1598495: (USE_AFTER_FREE) /bgpd/bgpd.c: 3959 in bgp_delete() /bgpd/bgpd.c: 3959 in bgp_delete() ________________________________________________________________________________________________________ *** CID 1598495: (USE_AFTER_FREE) /bgpd/bgpd.c: 3959 in bgp_delete() 3953 dest = dest_next) { 3954 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 3955 dest_table = bgp_dest_table(dest); 3956 if (dest_table->bgp == bgp) { 3957 bgp_path_info_unlock(dest->za_bgp_pi); 3958 bgp_dest_unlock_node(dest); >>> CID 1598495: (USE_AFTER_FREE) >>> Calling "zebra_announce_del" dereferences freed pointer "dest". 3959 zebra_announce_del(&bm->zebra_announce_head, dest); 3960 } 3961 } 3962 3963 cnt_after = zebra_announce_count(&bm->zebra_announce_head); 3964 if (BGP_DEBUG(zebra, ZEBRA)) /bgpd/bgpd.c: 3959 in bgp_delete() 3953 dest = dest_next) { 3954 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 3955 dest_table = bgp_dest_table(dest); 3956 if (dest_table->bgp == bgp) { 3957 bgp_path_info_unlock(dest->za_bgp_pi); 3958 bgp_dest_unlock_node(dest); >>> CID 1598495: (USE_AFTER_FREE) >>> Calling "zebra_announce_del" dereferences freed pointer "dest". 3959 zebra_announce_del(&bm->zebra_announce_head, dest); 3960 } 3961 } 3962 3963 cnt_after = zebra_announce_count(&bm->zebra_announce_head); 3964 if (BGP_DEBUG(zebra, ZEBRA)) /bgpd/bgpd.c: 3959 in bgp_delete() 3953 dest = dest_next) { 3954 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 3955 dest_table = bgp_dest_table(dest); 3956 if (dest_table->bgp == bgp) { 3957 bgp_path_info_unlock(dest->za_bgp_pi); 3958 bgp_dest_unlock_node(dest); >>> CID 1598495: (USE_AFTER_FREE) >>> Passing freed pointer "dest" as an argument to "zebra_announce_del". 3959 zebra_announce_del(&bm->zebra_announce_head, dest); 3960 } 3961 } 3962 3963 cnt_after = zebra_announce_count(&bm->zebra_announce_head); 3964 if (BGP_DEBUG(zebra, ZEBRA)) /bgpd/bgpd.c: 3959 in bgp_delete() 3953 dest = dest_next) { 3954 dest_next = zebra_announce_next(&bm->zebra_announce_head, dest); 3955 dest_table = bgp_dest_table(dest); 3956 if (dest_table->bgp == bgp) { 3957 bgp_path_info_unlock(dest->za_bgp_pi); 3958 bgp_dest_unlock_node(dest); >>> CID 1598495: (USE_AFTER_FREE) >>> Passing freed pointer "dest" as an argument to "zebra_announce_del". 3959 zebra_announce_del(&bm->zebra_announce_head, dest); 3960 } 3961 } 3962 3963 cnt_after = zebra_announce_count(&bm->zebra_announce_head); 3964 if (BGP_DEBUG(zebra, ZEBRA)) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

use VXLAN on OVS/VPP
by MohammadReza MollaSalehi 03 Jul '24

03 Jul '24

Hi everyone, I'm having an issue with FRR not detecting the VXLAN interface when I use VPP or OVS. Additionally, even when I use LCP on VPP to create a TAP device, FRR still doesn't detect it. Would anyone happen to have any ideas or suggestions? Thanks for your help! MReza MollaSalehi DevOps Engineer, system administrator, security researcher Site: https://mrsalehi.info/ Email: info(a)mrsalehi.info

1 0

FRR 10.0 Release
by Jafar Al-Gharaibeh 01 Jul '24

01 Jul '24

Dear FRR Community, We are pleased to announce FRR 10.0 major release. For release notes please visit: https://frrouting.org/release/10.0/ https://github.com/FRRouting/frr/releases/tag/frr-10.0 In this release, we are deprecating a couple of features. Make sure to go over "Breaking Changes" in the release notes. Cheers, The FRR Development Team!

1 1