November 2017 - dev - lists.frrouting.org

DEFUN different from Quagga
by Mostafa Salari 15 Nov '17

15 Nov '17

Hi I figured out that the syntax of DEFUN commands in FRR 3 is different from Quagga. I found this problem when i saw my old (Quagga based) code raise errors when copied in FRR! For example, it seems that *() *has no meaning or different interpretation! As another example i think *argv*s are counted for all words in the command not only variables! am i right? So i have 2 questions 1. Where can i find the differences of DEFUN in FRR? 2. A trouble!!! When i input the *argv*s in vtysh in a different order, I will take different argv values!!!!!!! For example: i have in DEFUN: "snmp-server group NAME <v1|v2c> {read WORD|write WORD|notify WORD|context WORD}" Now, in vtysh, if the user enters: Router# snmp-server group g1 v1 write view1 read view2 My DEFUN considers argv[5] as view1 and argv[7] as view2 and if user enters: Router# snmp-server group g1 v1 read view2 write view1 My DEFUN considers argv[7] as view1 and argv[5] as view2 While in my DEFUN, i expect that snmp write view always to be (e.g.) argv[5] Please help. Thanks

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 14 Nov '17

14 Nov '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1461579: Resource leaks (RESOURCE_LEAK) /zebra/zebra_ptm.c: 949 in zebra_ptm_bfd_dst_deregister() ________________________________________________________________________________________________________ *** CID 1461579: Resource leaks (RESOURCE_LEAK) /zebra/zebra_ptm.c: 949 in zebra_ptm_bfd_dst_deregister() 943 zlog_debug("%s: Sent message (%d) %s", __func__, data_len, 944 ptm_cb.out_data); 945 946 zebra_ptm_send_message(ptm_cb.out_data, data_len); 947 948 stream_failure: >>> CID 1461579: Resource leaks (RESOURCE_LEAK) >>> Variable "out_ctxt" going out of scope leaks the storage it points to. 949 return 0; 950 } 951 952 /* BFD client register */ 953 int zebra_ptm_bfd_client_register(struct zserv *client, 954 u_short length) ** CID 1461578: Resource leaks (RESOURCE_LEAK) /zebra/zebra_ptm.c: 820 in zebra_ptm_bfd_dst_register() ________________________________________________________________________________________________________ *** CID 1461578: Resource leaks (RESOURCE_LEAK) /zebra/zebra_ptm.c: 820 in zebra_ptm_bfd_dst_register() 814 if (IS_ZEBRA_DEBUG_SEND) 815 zlog_debug("%s: Sent message (%d) %s", __func__, data_len, 816 ptm_cb.out_data); 817 zebra_ptm_send_message(ptm_cb.out_data, data_len); 818 819 stream_failure: >>> CID 1461578: Resource leaks (RESOURCE_LEAK) >>> Variable "out_ctxt" going out of scope leaks the storage it points to. 820 return 0; 821 } 822 823 /* BFD peer/dst deregister */ 824 int zebra_ptm_bfd_dst_deregister(struct zserv *client, u_short length, 825 struct zebra_vrf *zvrf) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Open source routing @ ietf meetup
by Lou Berger 13 Nov '17

13 Nov '17

Hi, Anyone interested in joining a "bring your own lunch" gathering of folks using/building open source routing code, please drop in to "Hullet Room" on *Wednesday* during lunch (noon). There is no agenda or slides -- feel free to come with a topic you'd like to discuss or info you want to share... Cheers, Lou

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 13 Nov '17

13 Nov '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1461328: Security best practices violations (TOCTOU) /lib/command.c: 1668 in file_write_config() ________________________________________________________________________________________________________ *** CID 1461328: Security best practices violations (TOCTOU) /lib/command.c: 1668 in file_write_config() 1662 if (errno != ENOENT) { 1663 vty_out(vty, 1664 "Can't unlink backup configuration file %s.\n", 1665 config_file_sav); 1666 goto finished; 1667 } >>> CID 1461328: Security best practices violations (TOCTOU) >>> Calling function "link" that uses "config_file" after a check function. This can cause a time-of-check, time-of-use race condition. 1668 if (link(config_file, config_file_sav) != 0) { 1669 vty_out(vty, 1670 "Can't backup old configuration file %s.\n", 1671 config_file_sav); 1672 goto finished; 1673 } ** CID 1461327: Security best practices violations (SECURE_TEMP) /lib/command.c: 1636 in file_write_config() ________________________________________________________________________________________________________ *** CID 1461327: Security best practices violations (SECURE_TEMP) /lib/command.c: 1636 in file_write_config() 1630 1631 1632 config_file_tmp = XMALLOC(MTYPE_TMP, strlen(config_file) + 8); 1633 sprintf(config_file_tmp, "%s.XXXXXX", config_file); 1634 1635 /* Open file to configuration write. */ >>> CID 1461327: Security best practices violations (SECURE_TEMP) >>> Calling "mkstemp" without securely setting umask first. 1636 fd = mkstemp(config_file_tmp); 1637 if (fd < 0) { 1638 vty_out(vty, "Can't open configuration file %s.\n", 1639 config_file_tmp); 1640 goto finished; 1641 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Results of FRR TSC 2017-10 Voting...
by Alistair Woodman 10 Nov '17

10 Nov '17

All, Here are the results of the FRR TSC vote. (sorry for the delay, I have been in transit) Eligible to vote: 18 Actually voted: 16 Turnout: 89% The following nominees were elected to the TSC: . Philippe Guibert . Donald Sharp . Renato Westphal . Russ White . Martin Winter . Quentin Young The following nominees were not: . Lou Berger . David Lamparter I'd like to thank everyone for participating in the process, and look forward to a repeat in 2018-10. /a

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 09 Nov '17

09 Nov '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1461297: Null pointer dereferences (REVERSE_INULL) /bgpd/rfapi/bgp_rfapi_cfg.c: 1468 in vnc_export_nvegroup() ________________________________________________________________________________________________________ *** CID 1461297: Null pointer dereferences (REVERSE_INULL) /bgpd/rfapi/bgp_rfapi_cfg.c: 1468 in vnc_export_nvegroup() 1462 if (rfg_new == NULL) { 1463 rfg_new = bgp_rfapi_cfg_match_byname(bgp, argv[5]->arg, 1464 RFAPI_GROUP_CFG_VRF); 1465 vnc_add_vrf_opener(bgp, rfg_new); 1466 } 1467 >>> CID 1461297: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "rfg_new" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1468 if (rfg_new == NULL) { 1469 vty_out(vty, "Can't find group named \"%s\".\n", argv[5]->arg); 1470 return CMD_WARNING_CONFIG_FAILED; 1471 } 1472 1473 if (argv[2]->arg[0] == 'b') { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Slack access
by Juergen Werner 08 Nov '17

08 Nov '17

Hi, my name is Juergen and I recently raised my first pull request. An acquaintance of mine, @cfra, pointed me to this project and I would like to contribute to it. Is this the right place to ask for access to the Slack channel? Best regards, Juergen

3 2

Last Notice: TSC Voting ends in a few hours....
by Alistair Woodman 07 Nov '17

07 Nov '17

Dear FRR maintainers, Voting for the TSC will close before tomorrow's call. If you have not voted, but intend to, you only have a few hours.

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Nov '17

06 Nov '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1461144: Memory - illegal accesses (BUFFER_SIZE_WARNING) /ospfd/ospf_vty.c: 4162 in show_ip_ospf_neighbor_sub() ________________________________________________________________________________________________________ *** CID 1461144: Memory - illegal accesses (BUFFER_SIZE_WARNING) /ospfd/ospf_vty.c: 4162 in show_ip_ospf_neighbor_sub() 4156 4157 if (nbr->state == NSM_Attempt && 4158 nbr->router_id.s_addr == 0) 4159 strncpy(neigh_str, "neighbor", 4160 INET_ADDRSTRLEN); 4161 else >>> CID 1461144: Memory - illegal accesses (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 16 bytes on destination array "neigh_str" of size 16 bytes might leave the destination string unterminated. 4162 strncpy(neigh_str, 4163 inet_ntoa(nbr->router_id), 4164 INET_ADDRSTRLEN); 4165 4166 json_object_object_get_ex(json, neigh_str, 4167 &json_neigh_array); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 03 Nov '17

03 Nov '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1460438: Uninitialized variables (UNINIT) /eigrpd/eigrp_reply.c: 173 in eigrp_reply_receive() ________________________________________________________________________________________________________ *** CID 1460438: Uninitialized variables (UNINIT) /eigrpd/eigrp_reply.c: 173 in eigrp_reply_receive() 167 eigrp->topology_table, &dest_addr); 168 /* 169 * Destination must exists 170 */ 171 if (!dest) { 172 char buf[PREFIX_STRLEN]; >>> CID 1460438: Uninitialized variables (UNINIT) >>> Using uninitialized element of array "buf" when calling "strlen". 173 zlog_err("%s: Received prefix %s which we do not know about", 174 __PRETTY_FUNCTION__, 175 prefix2str(&dest_addr, buf, strlen(buf))); 176 continue; 177 } 178 ** CID 1460437: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_reply.c: 160 in eigrp_reply_receive() ________________________________________________________________________________________________________ *** CID 1460437: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_reply.c: 160 in eigrp_reply_receive() 154 continue; 155 156 struct prefix dest_addr; 157 158 stream_set_getp(s, s->getp - sizeof(u_int16_t)); 159 >>> CID 1460437: Resource leaks (RESOURCE_LEAK) >>> Overwriting "tlv" in "tlv = eigrp_read_ipv4_tlv(s)" leaks the storage that "tlv" points to. 160 tlv = eigrp_read_ipv4_tlv(s); 161 162 dest_addr.family = AF_INET; 163 dest_addr.u.prefix4 = tlv->destination; 164 dest_addr.prefixlen = tlv->prefix_length; 165 struct eigrp_prefix_entry *dest = ** CID 1460436: Control flow issues (DEADCODE) /eigrpd/eigrp_query.c: 240 in eigrp_send_query() ________________________________________________________________________________________________________ *** CID 1460436: Control flow issues (DEADCODE) /eigrpd/eigrp_query.c: 240 in eigrp_send_query() 234 new_packet = true; 235 } 236 } 237 238 if (!has_tlv) { 239 if (ep) >>> CID 1460436: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "eigrp_packet_free(ep);". 240 eigrp_packet_free(ep); 241 return; 242 } 243 244 if ((ei->params.auth_type == EIGRP_AUTH_TYPE_MD5) 245 && ei->params.auth_keychain != NULL) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0