April 2017 - dev - lists.frrouting.org

Multi-Topology OSPF
by Jafar Al-Gharaibeh 11 Apr '17

11 Apr '17

Lou, Here is the pointer to MT-OSPF (RFC 4915) : https://github.com/AT-Corp/quagga-atc/tree/master It is based off Quagga as of April 2015 I think, put I pushed bug fixes on top that were necessary to have a stable run. This Initial effort started from https://github.com/tomhenderson/quagga-mtr Two main comments about this if we were to bring it in: 1- Keeping track of the multiple topologies was done using the "old" vrf code which was changed to map each topology to an FIB/kernel-routing-table. Significant changes to VRF was introduced to Quagga in mid 2015 which maps VRFs to network namespaces. Some porting effort is needed to decouple topologies from VRFs and map them to multiple routing tables within the same network namespace. At a later date multiple routing table support was added to Quagga so there is a "straight" and logical way to move forward: just map each topology to a routing table. It should have been done that way from the beginning, but since there was no support for multiple tables in Quagga at the time it was easier to just "hack" VRFs. 2- The current implementation supports 128 topology and it statically allocates tables for all of them and maintain them even if you are using very few toplogies or not using any additional topologies other than the default one. A better approach would be to just allocate/maintain those only if/when they are activated. Cheers, Jafar

2 1

Re: [dev] Not feeling well
by Lou Berger 11 Apr '17

11 Apr '17

I plan to join -- I'm sure we'll do something productive... assuming https://bluejeans.com/9192742159 still works... On 4/11/2017 8:17 AM, Donald Sharp via dev wrote: > _______________________________________________ > dev mailing list > dev(a)lists.frrouting.org > https://lists.frrouting.org/listinfo/dev

1 0

Re: [dev] Not feeling well
by Martin Winter 11 Apr '17

11 Apr '17

> Can I get a volunteer to send an agenda and run the meeting? I could run the meeting (but probably not send an agenda anymore) Same URL? - Martin

1 0

Re: [dev] Not feeling well
by David Lamparter 11 Apr '17

11 Apr '17

I'm also out unfortunately (bad migraine day), my apologies :( -David On Tue, Apr 11, 2017 at 10:52:07AM +0000, Donald Sharp via dev wrote: > Can I get a volunteer to send an agenda and run the meeting? > > Donald

1 0

Not feeling well
by Donald Sharp 11 Apr '17

11 Apr '17

Can I get a volunteer to send an agenda and run the meeting? Donald

1 0

Agenda item for weekly call -- FRR Community Outreach
by Alistair Woodman 11 Apr '17

11 Apr '17

All, one of my roles for the FRR community is to do outreach to get groups, projects, universities, corporations etc to become more formal involved with the FRR project. Can we spend some time on the weekly call tomorrow discussing the criteria we will use to add organizations/logos to the FRRouting website? /a Sent from my iPad

1 0

Broken CLI
by Donald Sharp 07 Apr '17

07 Apr '17

All - I keep finding and having to fix broken cli issues found by simply running vtysh: sharpd@robot ~/frr> sudo vtysh 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'distribute-list [prefix] WORD <in|out> [WORD]' 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'no [ipv6] distribute-list [prefix] WORD <in|out> [WORD]' 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'no [ipv6] distribute-list [prefix] WORD <in|out> [WORD]' 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'distribute-list [prefix] WORD <in|out> [WORD]' Please take a moment to at least *run* vtysh before you push something up for a Pull Request. Martin - I know a month or so back I asked to have some CI coverage of this issue. Is it possible to get something turned on? donald

2 2

Re: [dev] BFD
by Konstantin Shalygin 06 Apr '17

06 Apr '17

In some cases folks choose bird, because BFD is supported. > I would like to eventually find time to abstract it a bit more and > allow different solutions. Just not been high on my list of things to > do.

3 5

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Apr '17

06 Apr '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1424529: (FORWARD_NULL) /isisd/isis_lsp.c: 1654 in lsp_build() /isisd/isis_lsp.c: 1710 in lsp_build() ________________________________________________________________________________________________________ *** CID 1424529: (FORWARD_NULL) /isisd/isis_lsp.c: 1654 in lsp_build() 1648 lsp_debug("ISIS (%s): No DIS for circuit, not adding te-style IS neighbor.", 1649 area->area_tag); 1650 } 1651 else 1652 { 1653 /* Check if MPLS_TE is activate */ >>> CID 1424529: (FORWARD_NULL) >>> Dereferencing null pointer "circuit->interface". 1654 if (IS_MPLS_TE(isisMplsTE) && HAS_LINK_PARAMS(circuit->interface)) 1655 /* Add SubTLVs & Adjust real size of SubTLVs */ 1656 te_is_neigh->sub_tlvs_length = add_te_subtlvs(te_is_neigh->sub_tlvs, circuit->mtc); 1657 else 1658 /* Or keep only TE metric with no SubTLVs if MPLS_TE is off */ 1659 te_is_neigh->sub_tlvs_length = 0; /isisd/isis_lsp.c: 1710 in lsp_build() 1704 te_is_neigh = XCALLOC (MTYPE_ISIS_TLV, 1705 sizeof (struct te_is_neigh)); 1706 memcpy (te_is_neigh->neigh_id, nei->sysid, ISIS_SYS_ID_LEN); 1707 metric = circuit->te_metric[level - 1]; 1708 SET_TE_METRIC(te_is_neigh, metric); 1709 /* Check if MPLS_TE is activate */ >>> CID 1424529: (FORWARD_NULL) >>> Dereferencing null pointer "circuit->interface". 1710 if (IS_MPLS_TE(isisMplsTE) && HAS_LINK_PARAMS(circuit->interface)) 1711 /* Update Local and Remote IP address for MPLS TE circuit parameters */ 1712 /* NOTE sure that it is the pertinent place for that updates */ 1713 /* Local IP address could be updated in isis_circuit.c - isis_circuit_add_addr() */ 1714 /* But, where update remote IP address ? in isis_pdu.c - process_p2p_hello() ? */ 1715 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Re: [dev] Technical steering committee recomendations
by David Lamparter 05 Apr '17

05 Apr '17

Hiya, I'd like to nominate Donald Sharp to be on the steering committee. Donald has been continuously driving the entire project forward, pulling us together into a coherent group with a direction. He is contributing on all fronts - code, review, design and buerocracy; and he has shown that he is able to suggest agreements and ways forward in areas where we have diverging interests in the group :) Cheers, -David

1 0