June 2017 - dev - lists.frrouting.org

EVPN (and L3VPN) configuration
by Vivek Venkatraman 18 Jul '17

18 Jul '17

About 3 weeks ago, I submitted PR 619 ( https://github.com/FRRouting/frr/pull/619) which provides the standardized EVPN control plane for VxLAN. This is the EVPN implementation that is available/shipping with Cumulus Linux, just merged with the FRR 'master' branch. The PR provides a summary of the functionality. The essential configuration involves only two steps as documented in the file doc/evpn.md: 1. Enable (activate) the EVPN (AFI/SAFI 25/70) address-family between BGP speakers 2. Enable EVPN itself on the local system - to advertise local VNIs and MACs and Neighbors (ARP/ND) associated with those VNIs using BGP/EVPN procedures. The RD and RT parameters will be automatically derived as specified in these procedures and/or prevalent best practice. Step #2 is of course not needed on a Route Reflector. In addition, there are commands to configure the RD and RTs if auto-derivation is not desired - for e.g., peering with third-party BGP system. The syntax for this is shown through an example configuration below (which also shows steps #1 and #2). router bgp 65001 address-family l2vpn evpn neighbor SPINE activate vni 10100 rd 1:10100 route-target import 1:10100 exit-vni advertise-all-vni exit-address-family One topic of discussion is regarding this optional VNI configuration. Instead of the keyword being "vni", should it be "vni-policy" to match with "vrf-policy"? I don't think "vni-policy", or for that matter, "vrf-policy" is the best choice due to the following two main reasons: 1. A "policy" is a fairly familiar construct in routing parlance. It commonly refers to a set of rules or definitions that are generically specified and can then be applied to different "attach points". In FRR, a "route-map" would be a good example of such a policy. It may be misleading to call the specific configuration for a VNI or VRF as "policy", particularly when the VNI/VRF may later support import/export policies (route-maps). 2. The configuration syntax that emerged for VRFs after the last round of discussions separates out the "CE side" configuration (e.g., CE neighbors, redistribution etc.) from the "PE side" configuration (e.g., RD and RT configuration). From the user/operator's perspective, I do not see any value add in this separation, only a potential source of confusion since the same entity (VRF) needs to be configured in multiple places. It can also be debatable where a configuration lies. For e.g., should "vrf-import-policy" reside on the "PE side" as it deals with received L3VPN routes or on the "CE side" as it decides which routes to import into which VRF table? I see it as being very useful to have all the configuration relevant to a VRF (or VNI) in one place. The purpose of this email is to solicit wider feedback since only a few people participated in the earlier discussion and their positions are very likely unchanged. My suggestion would be to have the initial deliberations on the list and if that does not converge or indicates the need for a meeting, the maintainers will call one. Based on the consensus that emerges, I shall update my PR and/or introduce modifications in a subsequent PR - if needed. Vivek

3 11

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Jun '17

30 Jun '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1448984: (PW.TOO_FEW_PRINTF_ARGS) /lib/thread.c: 274 in () /lib/thread.c: 298 in () ________________________________________________________________________________________________________ *** CID 1448984: (PW.TOO_FEW_PRINTF_ARGS) /lib/thread.c: 274 in () 268 int idx = 0; 269 270 if (argv_find (argv, argc, "FILTER", &idx)) { 271 filter = parse_filter (argv[idx]->arg); 272 if (!filter) { 273 vty_outln(vty, "Invalid filter \"%s\" specified; must contain at least" >>> CID 1448984: (PW.TOO_FEW_PRINTF_ARGS) >>> the format string requires additional arguments 274 "one of 'RWTEXB'%s", argv[idx]->arg); 275 return CMD_WARNING; 276 } 277 } 278 279 cpu_record_print(vty, filter); /lib/thread.c: 298 in () 292 int idx = 0; 293 294 if (argv_find (argv, argc, "FILTER", &idx)) { 295 filter = parse_filter (argv[idx]->arg); 296 if (!filter) { 297 vty_outln(vty, "Invalid filter \"%s\" specified; must contain at least" >>> CID 1448984: (PW.TOO_FEW_PRINTF_ARGS) >>> the format string requires additional arguments 298 "one of 'RWTEXB'%s", argv[idx]->arg); 299 return CMD_WARNING; 300 } 301 } 302 303 cpu_record_clear (filter); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Jun '17

30 Jun '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 8 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 8 of 8 defect(s) ** CID 1448810: Memory - corruptions (ARRAY_VS_SINGLETON) /lib/prefix.c: 311 in prefix_match_network_statement() ________________________________________________________________________________________________________ *** CID 1448810: Memory - corruptions (ARRAY_VS_SINGLETON) /lib/prefix.c: 311 in prefix_match_network_statement() 305 pp = (const u_char *)&p->u.prefix; 306 307 offset = n->prefixlen / PNBBY; 308 shift = n->prefixlen % PNBBY; 309 310 if (shift) >>> CID 1448810: Memory - corruptions (ARRAY_VS_SINGLETON) >>> Using "pp" as an array. This might corrupt or misinterpret adjacent memory locations. 311 if (maskbit[shift] & (np[offset] ^ pp[offset])) 312 return 0; 313 314 while (offset--) 315 if (np[offset] != pp[offset]) 316 return 0; ** CID 1448809: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2430 in ospf_neighbor_poll_interval() ________________________________________________________________________________________________________ *** CID 1448809: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2430 in ospf_neighbor_poll_interval() 2424 int idx_poll = 3; 2425 int idx_pri = 5; 2426 struct in_addr nbr_addr; 2427 unsigned int priority = OSPF_NEIGHBOR_PRIORITY_DEFAULT; 2428 unsigned int interval = OSPF_POLL_INTERVAL_DEFAULT; 2429 >>> CID 1448809: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 72 out of 81 times). 2430 inet_aton(argv[idx_ipv4]->arg, &nbr_addr); 2431 2432 interval = strtoul(argv[idx_poll]->arg, NULL, 10); 2433 2434 if (argc > 4) 2435 priority = strtoul(argv[idx_pri]->arg, NULL, 10); ** CID 1448808: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2461 in no_ospf_neighbor() ________________________________________________________________________________________________________ *** CID 1448808: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2461 in no_ospf_neighbor() 2455 "Seconds\n") 2456 { 2457 VTY_DECLVAR_CONTEXT(ospf, ospf); 2458 int idx_ipv4 = 2; 2459 struct in_addr nbr_addr; 2460 >>> CID 1448808: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 72 out of 81 times). 2461 inet_aton(argv[idx_ipv4]->arg, &nbr_addr); 2462 2463 (void)ospf_nbr_nbma_unset (ospf, nbr_addr); 2464 2465 return CMD_SUCCESS; 2466 } ** CID 1448807: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 1296 in clear_ip_eigrp_neighbors_IP() ________________________________________________________________________________________________________ *** CID 1448807: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 1296 in clear_ip_eigrp_neighbors_IP() 1290 "IP-EIGRP neighbor address\n") 1291 { 1292 struct eigrp *eigrp; 1293 struct eigrp_neighbor *nbr; 1294 struct in_addr nbr_addr; 1295 >>> CID 1448807: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 72 out of 81 times). 1296 inet_aton(argv[4]->arg, &nbr_addr); 1297 1298 /* Check if eigrp process is enabled */ 1299 eigrp = eigrp_lookup (); 1300 if (eigrp == NULL) 1301 { ** CID 1448806: Memory - corruptions (ARRAY_VS_SINGLETON) /lib/prefix.c: 311 in prefix_match_network_statement() ________________________________________________________________________________________________________ *** CID 1448806: Memory - corruptions (ARRAY_VS_SINGLETON) /lib/prefix.c: 311 in prefix_match_network_statement() 305 pp = (const u_char *)&p->u.prefix; 306 307 offset = n->prefixlen / PNBBY; 308 shift = n->prefixlen % PNBBY; 309 310 if (shift) >>> CID 1448806: Memory - corruptions (ARRAY_VS_SINGLETON) >>> Using "np" as an array. This might corrupt or misinterpret adjacent memory locations. 311 if (maskbit[shift] & (np[offset] ^ pp[offset])) 312 return 0; 313 314 while (offset--) 315 if (np[offset] != pp[offset]) 316 return 0; ** CID 1448805: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 1404 in clear_ip_eigrp_neighbors_IP_soft() ________________________________________________________________________________________________________ *** CID 1448805: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 1404 in clear_ip_eigrp_neighbors_IP_soft() 1398 "Resync with peer without adjacency reset\n") 1399 { 1400 struct eigrp *eigrp; 1401 struct eigrp_neighbor *nbr; 1402 struct in_addr nbr_addr; 1403 >>> CID 1448805: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 72 out of 81 times). 1404 inet_aton(argv[4]->arg, &nbr_addr); 1405 1406 /* Check if eigrp process is enabled */ 1407 eigrp = eigrp_lookup (); 1408 if (eigrp == NULL) 1409 { ** CID 1448804: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2483 in no_ospf_neighbor_poll() ________________________________________________________________________________________________________ *** CID 1448804: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2483 in no_ospf_neighbor_poll() 2477 "Priority\n") 2478 { 2479 VTY_DECLVAR_CONTEXT(ospf, ospf); 2480 int idx_ipv4 = 2; 2481 struct in_addr nbr_addr; 2482 >>> CID 1448804: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 72 out of 81 times). 2483 inet_aton(argv[idx_ipv4]->arg, &nbr_addr); 2484 2485 (void)ospf_nbr_nbma_unset (ospf, nbr_addr); 2486 2487 return CMD_SUCCESS; 2488 } ** CID 1448803: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2393 in ospf_neighbor() ________________________________________________________________________________________________________ *** CID 1448803: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 2393 in ospf_neighbor() 2387 int idx_pri = 3; 2388 int idx_poll = 5; 2389 struct in_addr nbr_addr; 2390 unsigned int priority = OSPF_NEIGHBOR_PRIORITY_DEFAULT; 2391 unsigned int interval = OSPF_POLL_INTERVAL_DEFAULT; 2392 >>> CID 1448803: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 72 out of 81 times). 2393 inet_aton(argv[idx_ipv4]->arg, &nbr_addr); 2394 2395 if (argc > 2) 2396 priority = strtoul(argv[idx_pri]->arg, NULL, 10); 2397 2398 if (argc > 4) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 29 Jun '17

29 Jun '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1448581: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 7094 in no_ip_ospf_area() ________________________________________________________________________________________________________ *** CID 1448581: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 7094 in no_ip_ospf_area() 7088 return CMD_SUCCESS; 7089 7090 argv_find (argv, argc, "area", &idx); 7091 7092 // Check if we have an address arg and proccess it 7093 if (argc == idx + 3) { >>> CID 1448581: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 78 out of 81 times). 7094 inet_aton(argv[idx+2]->arg, &addr); 7095 params = ospf_lookup_if_params (ifp, addr); 7096 if ((params) == NULL) 7097 return CMD_SUCCESS; 7098 } 7099 else ** CID 1448580: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 7034 in ip_ospf_area() ________________________________________________________________________________________________________ *** CID 1448580: Error handling issues (CHECKED_RETURN) /ospfd/ospf_vty.c: 7034 in ip_ospf_area() 7028 VTY_NEWLINE); 7029 return CMD_WARNING; 7030 } 7031 7032 // Check if we have an address arg and proccess it 7033 if (argc == idx + 3) { >>> CID 1448580: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 78 out of 81 times). 7034 inet_aton(argv[idx+2]->arg, &addr); 7035 // update/create address-level params 7036 params = ospf_get_if_params ((ifp), (addr)); 7037 if (OSPF_IF_PARAM_CONFIGURED(params, if_area)) 7038 { 7039 vty_out (vty, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 28 Jun '17

28 Jun '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 28 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 28 defect(s) ** CID 1448410: Control flow issues (DEADCODE) /lib/plist_clippy.c: 168 in no_ip_prefix_list_all() ________________________________________________________________________________________________________ *** CID 1448410: Control flow issues (DEADCODE) /lib/plist_clippy.c: 168 in no_ip_prefix_list_all() 162 continue; 163 _fail = 0; 164 if (!strcmp(argv[_i]->varname, "prefix_list")) { 165 prefix_list = argv[_i]->arg; 166 } 167 if (_fail) >>> CID 1448410: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "vty_out" inside this statement: "vty_out(vty, "%% invalid in...". 168 vty_out (vty, "%% invalid input for %s: %s%s", 169 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 170 _failcnt += _fail; 171 } 172 if (_failcnt) 173 return CMD_WARNING; ** CID 1448409: Control flow issues (DEADCODE) /lib/plist_clippy.c: 614 in ipv6_prefix_list_sequence_number() ________________________________________________________________________________________________________ *** CID 1448409: Control flow issues (DEADCODE) /lib/plist_clippy.c: 614 in ipv6_prefix_list_sequence_number() 608 if (_fail) 609 vty_out (vty, "%% invalid input for %s: %s%s", 610 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 611 _failcnt += _fail; 612 } 613 if (_failcnt) >>> CID 1448409: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 614 return CMD_WARNING; 615 return ipv6_prefix_list_sequence_number_magic(self, vty, argc, argv, no); 616 } 617 618 /* show_ipv6_prefix_list => "show ipv6 prefix-list [WORD [seq$dseq (1-4294967295)$arg]]" */ 619 DEFUN_CMD_FUNC_DECL(show_ipv6_prefix_list) ** CID 1448408: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 25 in ip_prefix_list() ________________________________________________________________________________________________________ *** CID 1448408: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 25 in ip_prefix_list() 19 { 20 int _i; 21 unsigned _fail = 0, _failcnt = 0; 22 const char *prefix_list = NULL; 23 long seq = 0; 24 const char *seq_str = NULL; >>> CID 1448408: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "action" = "NULL". 25 const char *action = NULL; 26 const char *dest = NULL; 27 long ge = 0; 28 const char *ge_str = NULL; 29 long le = 0; 30 const char *le_str = NULL; ** CID 1448407: Control flow issues (DEADCODE) /lib/plist_clippy.c: 775 in show_ipv6_prefix_list_detail() ________________________________________________________________________________________________________ *** CID 1448407: Control flow issues (DEADCODE) /lib/plist_clippy.c: 775 in show_ipv6_prefix_list_detail() 769 if (_fail) 770 vty_out (vty, "%% invalid input for %s: %s%s", 771 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 772 _failcnt += _fail; 773 } 774 if (_failcnt) >>> CID 1448407: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 775 return CMD_WARNING; 776 return show_ipv6_prefix_list_detail_magic(self, vty, argc, argv, prefix_list); 777 } 778 779 /* clear_ipv6_prefix_list => "clear ipv6 prefix-list [WORD [X:X::X:X/M$prefix]]" */ 780 DEFUN_CMD_FUNC_DECL(clear_ipv6_prefix_list) ** CID 1448406: Control flow issues (DEADCODE) /lib/plist_clippy.c: 770 in show_ipv6_prefix_list_detail() ________________________________________________________________________________________________________ *** CID 1448406: Control flow issues (DEADCODE) /lib/plist_clippy.c: 770 in show_ipv6_prefix_list_detail() 764 continue; 765 _fail = 0; 766 if (!strcmp(argv[_i]->varname, "prefix_list")) { 767 prefix_list = argv[_i]->arg; 768 } 769 if (_fail) >>> CID 1448406: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "vty_out" inside this statement: "vty_out(vty, "%% invalid in...". 770 vty_out (vty, "%% invalid input for %s: %s%s", 771 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 772 _failcnt += _fail; 773 } 774 if (_failcnt) 775 return CMD_WARNING; ** CID 1448405: Control flow issues (DEADCODE) /lib/plist_clippy.c: 743 in show_ipv6_prefix_list_summary() ________________________________________________________________________________________________________ *** CID 1448405: Control flow issues (DEADCODE) /lib/plist_clippy.c: 743 in show_ipv6_prefix_list_summary() 737 if (_fail) 738 vty_out (vty, "%% invalid input for %s: %s%s", 739 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 740 _failcnt += _fail; 741 } 742 if (_failcnt) >>> CID 1448405: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 743 return CMD_WARNING; 744 return show_ipv6_prefix_list_summary_magic(self, vty, argc, argv, prefix_list); 745 } 746 747 /* show_ipv6_prefix_list_detail => "show ipv6 prefix-list detail [WORD$prefix-list]" */ 748 DEFUN_CMD_FUNC_DECL(show_ipv6_prefix_list_detail) ** CID 1448404: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 26 in ip_prefix_list() ________________________________________________________________________________________________________ *** CID 1448404: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 26 in ip_prefix_list() 20 int _i; 21 unsigned _fail = 0, _failcnt = 0; 22 const char *prefix_list = NULL; 23 long seq = 0; 24 const char *seq_str = NULL; 25 const char *action = NULL; >>> CID 1448404: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "dest" = "NULL". 26 const char *dest = NULL; 27 long ge = 0; 28 const char *ge_str = NULL; 29 long le = 0; 30 const char *le_str = NULL; 31 ** CID 1448403: Control flow issues (DEADCODE) /lib/plist_clippy.c: 205 in ip_prefix_list_sequence_number() ________________________________________________________________________________________________________ *** CID 1448403: Control flow issues (DEADCODE) /lib/plist_clippy.c: 205 in ip_prefix_list_sequence_number() 199 if (_fail) 200 vty_out (vty, "%% invalid input for %s: %s%s", 201 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 202 _failcnt += _fail; 203 } 204 if (_failcnt) >>> CID 1448403: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 205 return CMD_WARNING; 206 return ip_prefix_list_sequence_number_magic(self, vty, argc, argv, no); 207 } 208 209 /* show_ip_prefix_list => "show ip prefix-list [WORD [seq$dseq (1-4294967295)$arg]]" */ 210 DEFUN_CMD_FUNC_DECL(show_ip_prefix_list) ** CID 1448402: Control flow issues (DEADCODE) /lib/plist_clippy.c: 577 in no_ipv6_prefix_list_all() ________________________________________________________________________________________________________ *** CID 1448402: Control flow issues (DEADCODE) /lib/plist_clippy.c: 577 in no_ipv6_prefix_list_all() 571 continue; 572 _fail = 0; 573 if (!strcmp(argv[_i]->varname, "prefix_list")) { 574 prefix_list = argv[_i]->arg; 575 } 576 if (_fail) >>> CID 1448402: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "vty_out" inside this statement: "vty_out(vty, "%% invalid in...". 577 vty_out (vty, "%% invalid input for %s: %s%s", 578 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 579 _failcnt += _fail; 580 } 581 if (_failcnt) 582 return CMD_WARNING; ** CID 1448401: Control flow issues (DEADCODE) /lib/plist_clippy.c: 361 in show_ip_prefix_list_detail() ________________________________________________________________________________________________________ *** CID 1448401: Control flow issues (DEADCODE) /lib/plist_clippy.c: 361 in show_ip_prefix_list_detail() 355 continue; 356 _fail = 0; 357 if (!strcmp(argv[_i]->varname, "prefix_list")) { 358 prefix_list = argv[_i]->arg; 359 } 360 if (_fail) >>> CID 1448401: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "vty_out" inside this statement: "vty_out(vty, "%% invalid in...". 361 vty_out (vty, "%% invalid input for %s: %s%s", 362 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 363 _failcnt += _fail; 364 } 365 if (_failcnt) 366 return CMD_WARNING; ** CID 1448400: Null pointer dereferences (FORWARD_NULL) /lib/defun_lex.c: 1617 in def_yy_switch_to_buffer() ________________________________________________________________________________________________________ *** CID 1448400: Null pointer dereferences (FORWARD_NULL) /lib/defun_lex.c: 1617 in def_yy_switch_to_buffer() 1611 /* Flush out information for old buffer. */ 1612 *(yy_c_buf_p) = (yy_hold_char); 1613 YY_CURRENT_BUFFER_LVALUE->yy_buf_pos = (yy_c_buf_p); 1614 YY_CURRENT_BUFFER_LVALUE->yy_n_chars = (yy_n_chars); 1615 } 1616 >>> CID 1448400: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "yy_buffer_stack". 1617 YY_CURRENT_BUFFER_LVALUE = new_buffer; 1618 def_yy_load_buffer_state( ); 1619 1620 /* We don't actually know whether we did this switch during 1621 * EOF (def_yywrap()) processing, but the only time this flag 1622 * is looked at is after def_yywrap() is called, so it's safe ** CID 1448399: Control flow issues (DEADCODE) /lib/plist_clippy.c: 738 in show_ipv6_prefix_list_summary() ________________________________________________________________________________________________________ *** CID 1448399: Control flow issues (DEADCODE) /lib/plist_clippy.c: 738 in show_ipv6_prefix_list_summary() 732 continue; 733 _fail = 0; 734 if (!strcmp(argv[_i]->varname, "prefix_list")) { 735 prefix_list = argv[_i]->arg; 736 } 737 if (_fail) >>> CID 1448399: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "vty_out" inside this statement: "vty_out(vty, "%% invalid in...". 738 vty_out (vty, "%% invalid input for %s: %s%s", 739 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 740 _failcnt += _fail; 741 } 742 if (_failcnt) 743 return CMD_WARNING; ** CID 1448398: Control flow issues (DEADCODE) /lib/plist_clippy.c: 609 in ipv6_prefix_list_sequence_number() ________________________________________________________________________________________________________ *** CID 1448398: Control flow issues (DEADCODE) /lib/plist_clippy.c: 609 in ipv6_prefix_list_sequence_number() 603 continue; 604 _fail = 0; 605 if (!strcmp(argv[_i]->varname, "no")) { 606 no = argv[_i]->arg; 607 } 608 if (_fail) >>> CID 1448398: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "vty_out" inside this statement: "vty_out(vty, "%% invalid in...". 609 vty_out (vty, "%% invalid input for %s: %s%s", 610 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 611 _failcnt += _fail; 612 } 613 if (_failcnt) 614 return CMD_WARNING; ** CID 1448397: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 435 in ipv6_prefix_list() ________________________________________________________________________________________________________ *** CID 1448397: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 435 in ipv6_prefix_list() 429 int _i; 430 unsigned _fail = 0, _failcnt = 0; 431 const char *prefix_list = NULL; 432 long seq = 0; 433 const char *seq_str = NULL; 434 const char *action = NULL; >>> CID 1448397: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "dest" = "NULL". 435 const char *dest = NULL; 436 long ge = 0; 437 const char *ge_str = NULL; 438 long le = 0; 439 const char *le_str = NULL; 440 ** CID 1448396: Null pointer dereferences (FORWARD_NULL) /lib/defun_lex.c: 1585 in def_yyrestart() ________________________________________________________________________________________________________ *** CID 1448396: Null pointer dereferences (FORWARD_NULL) /lib/defun_lex.c: 1585 in def_yyrestart() 1579 */ 1580 void def_yyrestart (FILE * input_file ) 1581 { 1582 1583 if ( ! YY_CURRENT_BUFFER ){ 1584 def_yyensure_buffer_stack (); >>> CID 1448396: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "yy_buffer_stack". 1585 YY_CURRENT_BUFFER_LVALUE = 1586 def_yy_create_buffer(def_yyin,YY_BUF_SIZE ); 1587 } 1588 1589 def_yy_init_buffer(YY_CURRENT_BUFFER,input_file ); 1590 def_yy_load_buffer_state( ); ** CID 1448395: Control flow issues (DEADCODE) /lib/plist_clippy.c: 334 in show_ip_prefix_list_summary() ________________________________________________________________________________________________________ *** CID 1448395: Control flow issues (DEADCODE) /lib/plist_clippy.c: 334 in show_ip_prefix_list_summary() 328 if (_fail) 329 vty_out (vty, "%% invalid input for %s: %s%s", 330 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 331 _failcnt += _fail; 332 } 333 if (_failcnt) >>> CID 1448395: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 334 return CMD_WARNING; 335 return show_ip_prefix_list_summary_magic(self, vty, argc, argv, prefix_list); 336 } 337 338 /* show_ip_prefix_list_detail => "show ip prefix-list detail [WORD$prefix_list]" */ 339 DEFUN_CMD_FUNC_DECL(show_ip_prefix_list_detail) ** CID 1448394: Null pointer dereferences (NULL_RETURNS) /watchfrr/watchfrr.c: 672 in daemon_send_ready() ________________________________________________________________________________________________________ *** CID 1448394: Null pointer dereferences (NULL_RETURNS) /watchfrr/watchfrr.c: 672 in daemon_send_ready() 666 { 667 static int sent = 0; 668 if (!sent && gs.numdown == 0) { 669 FILE *fp; 670 671 fp = fopen(DAEMON_VTY_DIR "/watchfrr.started", "w"); >>> CID 1448394: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be null "fp" when calling "fclose". 672 fclose(fp); 673 zlog_notice 674 ("Watchfrr: Notifying Systemd we are up and running"); 675 systemd_send_started(master, 0); 676 sent = 1; 677 } ** CID 1448393: Control flow issues (DEADCODE) /lib/plist_clippy.c: 366 in show_ip_prefix_list_detail() ________________________________________________________________________________________________________ *** CID 1448393: Control flow issues (DEADCODE) /lib/plist_clippy.c: 366 in show_ip_prefix_list_detail() 360 if (_fail) 361 vty_out (vty, "%% invalid input for %s: %s%s", 362 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 363 _failcnt += _fail; 364 } 365 if (_failcnt) >>> CID 1448393: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 366 return CMD_WARNING; 367 return show_ip_prefix_list_detail_magic(self, vty, argc, argv, prefix_list); 368 } 369 370 /* clear_ip_prefix_list => "clear ip prefix-list [WORD [A.B.C.D/M$prefix]]" */ 371 DEFUN_CMD_FUNC_DECL(clear_ip_prefix_list) ** CID 1448392: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 431 in ipv6_prefix_list() ________________________________________________________________________________________________________ *** CID 1448392: Null pointer dereferences (FORWARD_NULL) /lib/plist_clippy.c: 431 in ipv6_prefix_list() 425 const char * le_str __attribute__ ((unused))) 426 funcdecl_ipv6_prefix_list; 427 DEFUN_CMD_FUNC_TEXT(ipv6_prefix_list) 428 { 429 int _i; 430 unsigned _fail = 0, _failcnt = 0; >>> CID 1448392: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix_list" = "NULL". 431 const char *prefix_list = NULL; 432 long seq = 0; 433 const char *seq_str = NULL; 434 const char *action = NULL; 435 const char *dest = NULL; 436 long ge = 0; ** CID 1448391: Control flow issues (DEADCODE) /lib/plist_clippy.c: 329 in show_ip_prefix_list_summary() ________________________________________________________________________________________________________ *** CID 1448391: Control flow issues (DEADCODE) /lib/plist_clippy.c: 329 in show_ip_prefix_list_summary() 323 continue; 324 _fail = 0; 325 if (!strcmp(argv[_i]->varname, "prefix_list")) { 326 prefix_list = argv[_i]->arg; 327 } 328 if (_fail) >>> CID 1448391: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "vty_out" inside this statement: "vty_out(vty, "%% invalid in...". 329 vty_out (vty, "%% invalid input for %s: %s%s", 330 argv[_i]->varname, argv[_i]->arg, VTY_NEWLINE); 331 _failcnt += _fail; 332 } 333 if (_failcnt) 334 return CMD_WARNING; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Call for Reviewers
by Donald Sharp 28 Jun '17

28 Jun '17

This commit: https://github.com/FRRouting/frr/pull/701 has gone for ~17 days without a review from anyone. Since this code has gone beyond 2 weeks without a review, I will auto push this code in on Friday 6/30. thanks! donald

1 0

FreeBSD port
by Olivier Cochard-Labbé 27 Jun '17

27 Jun '17

Hi, I've started working on the frr FreeBSD port (to be included into the official port-tree) and I've got some questions. 1. I've got a display bug with vtysh: Almost each line end up with a : --More--(END) I need to setup environment variable VTYSH_PAGER="" for fixing this problem. Is this a standard behavior ? 2. pimd is enabled by default into the configure script and it compiles great... but does someone tested it on FreeBSD ? (I didn't reach to use it). It has a different behavior from the other daemon too: As example it didn't support the -C/--dryrun option. 3. Regarding snmp configure option: Once enabled, I've got some build error like this one: vty.c:561:19: warning: implicit declaration of function 'typeof' is invalid in C99 [-Wimplicit-function-declaration] size_t nwrite = MIN ((int) strlen (str), VTY_BUFSIZ - vty->cp - 1); ^ ./zebra.h:341:5: note: expanded from macro 'MIN' ({ typeof (a) _a = (a); \ ^ vty.c:561:19: error: expected ';' after expression ./zebra.h:341:16: note: expanded from macro 'MIN' ({ typeof (a) _a = (a); \ ^ vty.c:561:19: error: use of undeclared identifier '_a' ./zebra.h:341:16: note: expanded from macro 'MIN' ({ typeof (a) _a = (a); \ 4. Regarding the tcmalloc configure option: Where can I find some benchmark somewhere about the benefits of this feature ? Thanks, Olivier

3 2

Today's Technical Meeting Agenda (11 am EDT)
by Donald Sharp 27 Jun '17

27 Jun '17

https://bluejeans.com/9192742159 1) 3.0 issues 2) New Issues 3) PR's 4) Anything else? donald

1 1

Issue with updating arp entries
by Tigran Martirosyan 24 Jun '17

24 Jun '17

Hello all, We at XCloud Networks are dealing with customers who run many hundreds of Routing on the host enabled machines. We are facing an issue which is described in bug tracking system with the link https://github.com/FRRouting/frr/issues/752 <https://github.com/FRRouting/frr/issues/752>. We want to start our contribution to the FRR project from solving this particular issue. @mainteiners. Could you please assign this issue to me (tigran(a)xcloudnetworks.com) Best, Tigran Martirosyan -------------------------------------- email: tigran(a)xcloudnetworks.com

1 0

Plans regarding VRF support for EIGRP
by Viktor Novotný 24 Jun '17

24 Jun '17

Hi everyone, our company is exploring option to use FRR based solution for IoT device. We would like to separate traffic to different applications into different VRFs, but it seems that VRF support is not implemented for EIGRP, is that so? I tried to create two eigrp router instances like this: /router eigrp 1// // eigrp router-id 192.168.2.3// // network 192.168.2.0/24 // // network 192.168.16.0/24 // // network 192.168.240.0/24 // // //router eigrp 2// // eigrp router-id 192.168.3.3// // network 192.168.3.0/24 // // network 192.168.17.0/24/ but all networks end up in the same instance in running config like this: /router eigrp 1// // network 192.168.2.0/24 // // network 192.168.3.0/24 // // network 192.168.16.0/24 // // network 192.168.17.0/24 // // network 192.168.240.0/24 / So if I haven't made any obvious mistake and VRF is indeed missing, are there any plans to add it or is anybody even working on it? Thank you Viktor

2 1