July 2017 - dev - lists.frrouting.org

Missing developer documentation
by Olivier Dugeon 12 Dec '17

12 Dec '17

Hiall, There is missing developer documentation in FRR. In PR #805 I try to update an old Zebra hacking document, but that seems too old to be publish, so I prefer to remove it as suggested during the PR review. For me, the main problem is how to start writing a such documentation ? First, it is too huge and to complicated to be written by only one person. Second, we need a dedicated space (e.g. a new doc project inside FRRouting) to collectively write such documentation and then push into frr master documents when they are ready. Finally, we need to organize themselves in order to collectively decided how to write them, to formalize the document through a common template, to harmonize the documentation... I would start by proposing: * start discussion about this new topic (create a new issue in github) during regular meeting * decide the document format (Markdown, in line github Wiki, LaTeX, TeXi ...) * create a new doc project within FRRouting * propose template * propose Table of Content for each document (perhaps partially common) * open contribution to the different documents Comments are welcome. Regards Olivier

4 6

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 31 Jul '17

31 Jul '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 79 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 79 defect(s) ** CID 1452363: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 88 in no_ldp_address_family() ________________________________________________________________________________________________________ *** CID 1452363: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 88 in no_ldp_address_family() 82 if (_fail) 83 vty_out (vty, "%% invalid input for %s: %s\n", 84 argv[_i]->varname, argv[_i]->arg); 85 _failcnt += _fail; 86 } 87 if (_failcnt) >>> CID 1452363: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 88 return CMD_WARNING; 89 return no_ldp_address_family_magic(self, vty, argc, argv, af); 90 } 91 92 /* ldp_discovery_holdtime => "[no] discovery <hello|targeted-hello>$hello_type holdtime (1-65535)$holdtime" */ 93 DEFUN_CMD_FUNC_DECL(ldp_discovery_holdtime) ** CID 1452362: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1045 in no_ldp_member_pseudowire() ________________________________________________________________________________________________________ *** CID 1452362: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1045 in no_ldp_member_pseudowire() 1039 if (_fail) 1040 vty_out (vty, "%% invalid input for %s: %s\n", 1041 argv[_i]->varname, argv[_i]->arg); 1042 _failcnt += _fail; 1043 } 1044 if (_failcnt) >>> CID 1452362: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 1045 return CMD_WARNING; 1046 return no_ldp_member_pseudowire_magic(self, vty, argc, argv, ifname); 1047 } 1048 1049 /* ldp_vc_type => "[no] vc type <ethernet|ethernet-tagged>$vc_type" */ 1050 DEFUN_CMD_FUNC_DECL(ldp_vc_type) ** CID 1452361: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 743 in ldp_ttl_security_disable() ________________________________________________________________________________________________________ *** CID 1452361: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 743 in ldp_ttl_security_disable() 737 if (_fail) 738 vty_out (vty, "%% invalid input for %s: %s\n", 739 argv[_i]->varname, argv[_i]->arg); 740 _failcnt += _fail; 741 } 742 if (_failcnt) >>> CID 1452361: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 743 return CMD_WARNING; 744 return ldp_ttl_security_disable_magic(self, vty, argc, argv, no); 745 } 746 747 /* ldp_session_holdtime => "[no] session holdtime (15-65535)$holdtime" */ 748 DEFUN_CMD_FUNC_DECL(ldp_session_holdtime) ** CID 1452360: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1758 in ldp_show_l2vpn_atom_vc() ________________________________________________________________________________________________________ *** CID 1452360: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1758 in ldp_show_l2vpn_atom_vc() 1752 if (_fail) 1753 vty_out (vty, "%% invalid input for %s: %s\n", 1754 argv[_i]->varname, argv[_i]->arg); 1755 _failcnt += _fail; 1756 } 1757 if (_failcnt) >>> CID 1452360: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 1758 return CMD_WARNING; 1759 return ldp_show_l2vpn_atom_vc_magic(self, vty, argc, argv, json); 1760 } 1761 1762 /* ldp_show_debugging_mpls_ldp => "show debugging mpls ldp" */ 1763 DEFUN_CMD_FUNC_DECL(ldp_show_debugging_mpls_ldp) ** CID 1452359: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 24 in no_ldp_mpls_ldp() ________________________________________________________________________________________________________ *** CID 1452359: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 24 in no_ldp_mpls_ldp() 18 if (_fail) 19 vty_out (vty, "%% invalid input for %s: %s\n", 20 argv[_i]->varname, argv[_i]->arg); 21 _failcnt += _fail; 22 } 23 if (_failcnt) >>> CID 1452359: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 24 return CMD_WARNING; 25 return no_ldp_mpls_ldp_magic(self, vty, argc, argv); 26 } 27 28 /* no_ldp_l2vpn => "no l2vpn WORD$l2vpn_name type vpls" */ 29 DEFUN_CMD_FUNC_DECL(no_ldp_l2vpn) ** CID 1452358: Null pointer dereferences (FORWARD_NULL) /ldpd/ldp_vty_cmds_clippy.c: 1101 in ldp_control_word() ________________________________________________________________________________________________________ *** CID 1452358: Null pointer dereferences (FORWARD_NULL) /ldpd/ldp_vty_cmds_clippy.c: 1101 in ldp_control_word() 1095 funcdecl_ldp_control_word; 1096 DEFUN_CMD_FUNC_TEXT(ldp_control_word) 1097 { 1098 int _i; 1099 unsigned _fail = 0, _failcnt = 0; 1100 const char *no = NULL; >>> CID 1452358: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "preference" = "NULL". 1101 const char *preference = NULL; 1102 1103 for (_i = 0; _i < argc; _i++) { 1104 if (!argv[_i]->varname) 1105 continue; 1106 _fail = 0; ** CID 1452357: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1753 in ldp_show_l2vpn_atom_vc() ________________________________________________________________________________________________________ *** CID 1452357: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1753 in ldp_show_l2vpn_atom_vc() 1747 continue; 1748 _fail = 0; 1749 if (!strcmp(argv[_i]->varname, "json")) { 1750 json = argv[_i]->arg; 1751 } 1752 if (_fail) >>> CID 1452357: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% invalid in...". 1753 vty_out (vty, "%% invalid input for %s: %s\n", 1754 argv[_i]->varname, argv[_i]->arg); 1755 _failcnt += _fail; 1756 } 1757 if (_failcnt) 1758 return CMD_WARNING; ** CID 1452356: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 706 in ldp_label_remote_accept() ________________________________________________________________________________________________________ *** CID 1452356: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 706 in ldp_label_remote_accept() 700 from_acl = argv[_i]->arg; 701 } 702 if (!strcmp(argv[_i]->varname, "for_acl")) { 703 for_acl = argv[_i]->arg; 704 } 705 if (_fail) >>> CID 1452356: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% invalid in...". 706 vty_out (vty, "%% invalid input for %s: %s\n", 707 argv[_i]->varname, argv[_i]->arg); 708 _failcnt += _fail; 709 } 710 if (_failcnt) 711 return CMD_WARNING; ** CID 1452355: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 209 in ldp_dual_stack_transport_connection_prefer_ipv4() ________________________________________________________________________________________________________ *** CID 1452355: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 209 in ldp_dual_stack_transport_connection_prefer_ipv4() 203 continue; 204 _fail = 0; 205 if (!strcmp(argv[_i]->varname, "no")) { 206 no = argv[_i]->arg; 207 } 208 if (_fail) >>> CID 1452355: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% invalid in...". 209 vty_out (vty, "%% invalid input for %s: %s\n", 210 argv[_i]->varname, argv[_i]->arg); 211 _failcnt += _fail; 212 } 213 if (_failcnt) 214 return CMD_WARNING; ** CID 1452354: Null pointer dereferences (FORWARD_NULL) /ldpd/ldp_vty_cmds_clippy.c: 73 in no_ldp_address_family() ________________________________________________________________________________________________________ *** CID 1452354: Null pointer dereferences (FORWARD_NULL) /ldpd/ldp_vty_cmds_clippy.c: 73 in no_ldp_address_family() 67 const char * af) 68 funcdecl_no_ldp_address_family; 69 DEFUN_CMD_FUNC_TEXT(no_ldp_address_family) 70 { 71 int _i; 72 unsigned _fail = 0, _failcnt = 0; >>> CID 1452354: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "af" = "NULL". 73 const char *af = NULL; 74 75 for (_i = 0; _i < argc; _i++) { 76 if (!argv[_i]->varname) 77 continue; 78 _fail = 0; ** CID 1452353: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1694 in ldp_show_mpls_ldp_neighbor_capabilities() ________________________________________________________________________________________________________ *** CID 1452353: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1694 in ldp_show_mpls_ldp_neighbor_capabilities() 1688 if (_fail) 1689 vty_out (vty, "%% invalid input for %s: %s\n", 1690 argv[_i]->varname, argv[_i]->arg); 1691 _failcnt += _fail; 1692 } 1693 if (_failcnt) >>> CID 1452353: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 1694 return CMD_WARNING; 1695 return ldp_show_mpls_ldp_neighbor_capabilities_magic(self, vty, argc, argv, json); 1696 } 1697 1698 /* ldp_show_l2vpn_atom_binding => "show l2vpn atom binding [json]$json" */ 1699 DEFUN_CMD_FUNC_DECL(ldp_show_l2vpn_atom_binding) ** CID 1452352: Null pointer dereferences (FORWARD_NULL) /ldpd/ldp_vty_cmds_clippy.c: 1030 in no_ldp_member_pseudowire() ________________________________________________________________________________________________________ *** CID 1452352: Null pointer dereferences (FORWARD_NULL) /ldpd/ldp_vty_cmds_clippy.c: 1030 in no_ldp_member_pseudowire() 1024 const char * ifname) 1025 funcdecl_no_ldp_member_pseudowire; 1026 DEFUN_CMD_FUNC_TEXT(no_ldp_member_pseudowire) 1027 { 1028 int _i; 1029 unsigned _fail = 0, _failcnt = 0; >>> CID 1452352: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "ifname" = "NULL". 1030 const char *ifname = NULL; 1031 1032 for (_i = 0; _i < argc; _i++) { 1033 if (!argv[_i]->varname) 1034 continue; 1035 _fail = 0; ** CID 1452351: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1472 in ldp_debug_mpls_ldp_messages_sent() ________________________________________________________________________________________________________ *** CID 1452351: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1472 in ldp_debug_mpls_ldp_messages_sent() 1466 if (_fail) 1467 vty_out (vty, "%% invalid input for %s: %s\n", 1468 argv[_i]->varname, argv[_i]->arg); 1469 _failcnt += _fail; 1470 } 1471 if (_failcnt) >>> CID 1452351: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 1472 return CMD_WARNING; 1473 return ldp_debug_mpls_ldp_messages_sent_magic(self, vty, argc, argv, no, all); 1474 } 1475 1476 /* ldp_show_mpls_ldp_binding => "show mpls ldp [<ipv4|ipv6>]$af binding [detail]$detail [json]$json" */ 1477 DEFUN_CMD_FUNC_DECL(ldp_show_mpls_ldp_binding) ** CID 1452350: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1276 in ldp_pw_status_disable() ________________________________________________________________________________________________________ *** CID 1452350: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1276 in ldp_pw_status_disable() 1270 continue; 1271 _fail = 0; 1272 if (!strcmp(argv[_i]->varname, "no")) { 1273 no = argv[_i]->arg; 1274 } 1275 if (_fail) >>> CID 1452350: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% invalid in...". 1276 vty_out (vty, "%% invalid input for %s: %s\n", 1277 argv[_i]->varname, argv[_i]->arg); 1278 _failcnt += _fail; 1279 } 1280 if (_failcnt) 1281 return CMD_WARNING; ** CID 1452349: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1040 in no_ldp_member_pseudowire() ________________________________________________________________________________________________________ *** CID 1452349: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1040 in no_ldp_member_pseudowire() 1034 continue; 1035 _fail = 0; 1036 if (!strcmp(argv[_i]->varname, "ifname")) { 1037 ifname = argv[_i]->arg; 1038 } 1039 if (_fail) >>> CID 1452349: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% invalid in...". 1040 vty_out (vty, "%% invalid input for %s: %s\n", 1041 argv[_i]->varname, argv[_i]->arg); 1042 _failcnt += _fail; 1043 } 1044 if (_failcnt) 1045 return CMD_WARNING; ** CID 1452348: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1785 in ldp_show_debugging_mpls_ldp() ________________________________________________________________________________________________________ *** CID 1452348: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1785 in ldp_show_debugging_mpls_ldp() 1779 if (_fail) 1780 vty_out (vty, "%% invalid input for %s: %s\n", 1781 argv[_i]->varname, argv[_i]->arg); 1782 _failcnt += _fail; 1783 } 1784 if (_failcnt) >>> CID 1452348: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 1785 return CMD_WARNING; 1786 return ldp_show_debugging_mpls_ldp_magic(self, vty, argc, argv); ** CID 1452347: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1361 in ldp_debug_mpls_ldp_discovery_hello() ________________________________________________________________________________________________________ *** CID 1452347: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1361 in ldp_debug_mpls_ldp_discovery_hello() 1355 if (_fail) 1356 vty_out (vty, "%% invalid input for %s: %s\n", 1357 argv[_i]->varname, argv[_i]->arg); 1358 _failcnt += _fail; 1359 } 1360 if (_failcnt) >>> CID 1452347: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 1361 return CMD_WARNING; 1362 return ldp_debug_mpls_ldp_discovery_hello_magic(self, vty, argc, argv, no, dir); 1363 } 1364 1365 /* ldp_debug_mpls_ldp_type => "[no] debug mpls ldp <errors|event|zebra>$type" */ 1366 DEFUN_CMD_FUNC_DECL(ldp_debug_mpls_ldp_type) ** CID 1452346: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1620 in ldp_show_mpls_ldp_capabilities() ________________________________________________________________________________________________________ *** CID 1452346: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1620 in ldp_show_mpls_ldp_capabilities() 1614 continue; 1615 _fail = 0; 1616 if (!strcmp(argv[_i]->varname, "json")) { 1617 json = argv[_i]->arg; 1618 } 1619 if (_fail) >>> CID 1452346: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% invalid in...". 1620 vty_out (vty, "%% invalid input for %s: %s\n", 1621 argv[_i]->varname, argv[_i]->arg); 1622 _failcnt += _fail; 1623 } 1624 if (_failcnt) 1625 return CMD_WARNING; ** CID 1452345: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1726 in ldp_show_l2vpn_atom_binding() ________________________________________________________________________________________________________ *** CID 1452345: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1726 in ldp_show_l2vpn_atom_binding() 1720 if (_fail) 1721 vty_out (vty, "%% invalid input for %s: %s\n", 1722 argv[_i]->varname, argv[_i]->arg); 1723 _failcnt += _fail; 1724 } 1725 if (_failcnt) >>> CID 1452345: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 1726 return CMD_WARNING; 1727 return ldp_show_l2vpn_atom_binding_magic(self, vty, argc, argv, json); 1728 } 1729 1730 /* ldp_show_l2vpn_atom_vc => "show l2vpn atom vc [json]$json" */ 1731 DEFUN_CMD_FUNC_DECL(ldp_show_l2vpn_atom_vc) ** CID 1452344: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1780 in ldp_show_debugging_mpls_ldp() ________________________________________________________________________________________________________ *** CID 1452344: Control flow issues (DEADCODE) /ldpd/ldp_vty_cmds_clippy.c: 1780 in ldp_show_debugging_mpls_ldp() 1774 1775 for (_i = 0; _i < argc; _i++) { 1776 if (!argv[_i]->varname) 1777 continue; 1778 _fail = 0; 1779 if (_fail) >>> CID 1452344: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% invalid in...". 1780 vty_out (vty, "%% invalid input for %s: %s\n", 1781 argv[_i]->varname, argv[_i]->arg); 1782 _failcnt += _fail; 1783 } 1784 if (_failcnt) 1785 return CMD_WARNING; 1786 return ldp_show_debugging_mpls_ldp_magic(self, vty, argc, argv); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 31 Jul '17

31 Jul '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1452282: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 186 in ipv6_route() ________________________________________________________________________________________________________ *** CID 1452282: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 186 in ipv6_route() 180 DEFUN_CMD_FUNC_TEXT(ipv6_route) 181 { 182 int _i; 183 unsigned _fail = 0, _failcnt = 0; 184 const char *no = NULL; 185 struct prefix_ipv6 prefix = { }; >>> CID 1452282: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix_str" = "NULL". 186 const char *prefix_str = NULL; 187 struct prefix_ipv6 from = { }; 188 const char *from_str = NULL; 189 struct in6_addr gate = IN6ADDR_ANY_INIT; 190 const char *gate_str = NULL; 191 const char *ifname = NULL; ** CID 1452281: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 23 in ip_mroute_dist() ________________________________________________________________________________________________________ *** CID 1452281: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 23 in ip_mroute_dist() 17 DEFUN_CMD_FUNC_TEXT(ip_mroute_dist) 18 { 19 int _i; 20 unsigned _fail = 0, _failcnt = 0; 21 const char *no = NULL; 22 struct prefix_ipv4 prefix = { }; >>> CID 1452281: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix_str" = "NULL". 23 const char *prefix_str = NULL; 24 struct in_addr gate = { INADDR_ANY }; 25 const char *gate_str = NULL; 26 const char *ifname = NULL; 27 long distance = 0; 28 const char *distance_str = NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Backtraces and best way to check cause
by Nigel Kukard 30 Jul '17

30 Jul '17

Hi guys, I'm wondering what would be the best way to try track the cause of these two backtraces. I'm trying to replace a Quagga 1.1.1 box with FRR 2.0 but am blocked by the below. There are about 30 or so external peers. 4 internal private peers. About 40 or so route maps and maybe 100 prefix lists. Jul 30 01:43:36 x-01-x zebra[12658]: Assertion `object->next_best == *updptr || !*updptr' failed in file plist.c, line 613, function trie_install_fn Jul 30 01:43:36 x-01-x zebra[12658]: Backtrace for 15 stack frames: Jul 30 01:43:36 x-01-x zebra[12658]: [bt 0] /usr/lib/x86_64-linux-gnu/libfrr.so.0(zlog_backtrace+0x3a) [0x7f89359acada] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 1] /usr/lib/x86_64-linux-gnu/libfrr.so.0(_zlog_assert_failed+0x67) [0x7f89359ad027] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 2] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x415c1) [0x7f89359ae5c1] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 3] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x42195) [0x7f89359af195] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 4] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x42858) [0x7f89359af858] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 5] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x42b67) [0x7f89359afb67] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 6] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x29c24) [0x7f8935996c24] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 7] /usr/lib/x86_64-linux-gnu/libfrr.so.0(cmd_execute_command+0xd0) [0x7f8935998180] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 8] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x22dd2) [0x7f893598fdd2] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 9] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x23103) [0x7f8935990103] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 10] /usr/lib/x86_64-linux-gnu/libfrr.so.0(+0x2468b) [0x7f893599168b] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 11] /usr/lib/x86_64-linux-gnu/libfrr.so.0(thread_call+0x6b) [0x7f893599ccdb] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 12] /usr/lib/frr/zebra(main+0x508) [0x555b24ff47b8] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 13] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f8934b70b45] Jul 30 01:43:36 x-01-x zebra[12658]: [bt 14] /usr/lib/frr/zebra(+0x1c9de) [0x555b24ff49de] Jul 30 01:43:36 x-01-x zebra[12658]: Current thread function vtysh_read, scheduled from file vty.c, line 2710 Jul 30 02:07:16 x-01-x bgpd[19976]: memory allocation count underflow for "BGP peer hostname" Jul 30 02:07:16 x-01-x bgpd[19976]: Backtrace for 10 stack frames: Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 0] /usr/lib/x86_64-linux-gnu/libfrr.so.0(zlog_backtrace+0x3a) [0x7f0903fafada] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 1] /usr/lib/x86_64-linux-gnu/libfrr.so.0(qfree+0x4e) [0x7f0903fc464e] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 2] /usr/lib/frr/bgpd(peer_group_delete+0xd4) [0x557425e9a244] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 3] /usr/lib/frr/bgpd(bgp_delete+0x145) [0x557425e9aa05] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 4] /usr/lib/frr/bgpd(sigint+0x68) [0x557425e91778] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 5] /usr/lib/x86_64-linux-gnu/libfrr.so.0(quagga_sigevent_process+0x50) [0x7f0903fbc790] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 6] /usr/lib/x86_64-linux-gnu/libfrr.so.0(thread_fetch+0x5d) [0x7f0903f9f77d] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 7] /usr/lib/frr/bgpd(main+0x4c8) [0x557425e901c8] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 8] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f0902e72b45] Jul 30 02:07:16 x-01-x bgpd[19976]: [bt 9] /usr/lib/frr/bgpd(+0x3f3dc) [0x557425e913dc] Kind Regards Nigel

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Jul '17

27 Jul '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1452064: Code maintainability issues (UNUSED_VALUE) /bgpd/bgp_attr.c: 2042 in bgp_attr_encap() ________________________________________________________________________________________________________ *** CID 1452064: Code maintainability issues (UNUSED_VALUE) /bgpd/bgp_attr.c: 2042 in bgp_attr_encap() 2036 stlv_last->next = tlv; 2037 } else { 2038 attr->vnc_subtlvs = tlv; 2039 } 2040 #endif 2041 } >>> CID 1452064: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "tlv" to "stlv_last" here, but that stored value is overwritten before it can be used. 2042 stlv_last = tlv; 2043 } 2044 2045 if (BGP_ATTR_ENCAP == type) { 2046 attr->encap_tunneltype = tunneltype; 2047 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Today's Technical Meeting 7/25
by Donald Sharp 25 Jul '17

25 Jul '17

https://bluejeans.com/9192742159 1) 3.0 issues 2) New Issues 3) PR's 4) Anything else? donald

2 1

NOTICE: Planned style conversion Monday, Jul 17
by Quentin Young 24 Jul '17

24 Jul '17

Hi folks, In a technical meeting many weeks ago we decided to restyle the codebase to Linux kernel style with the intent of easing maintenance burdens, increasing readability and having a common standard across all FRR components. With our pull request backlog presently at a minimum, the plan is to bite the bullet and convert FRR's master branch to Linux kernel style on Monday, July 17. The tooling for this task will be a Python wrapper for the clang-format <https://clang.llvm.org/docs/ClangFormat.html> source code formatter. The script and configuration file for clang-format will be checked in over the coming days prior to conversion. This patch will not be submitted in a pull request. This will be a direct push to master. All stable branches will remain as-is. Code submissions against those branches -- which should by now be limited to bug fixes -- should continue to follow the style guide present in those branches. Going forward we will require all patch submissions against master to conform to Linux kernel style, with some exceptions (DEFUNS primarily) that will be documented prior to conversion and which the Python script knows about. Recommended procedure will be to run the indent script over new code prior to submission. David has offered to write a helper script to ease merges / rebases for currently open pull requests and local branches. Please familiarize yourself with the kernel style guide located here: https://www.kernel.org/doc/html/v4.10/process/coding-style.html It will also be useful to have passing familiarity with clang-format: https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html The first page contains instructions on how to integrate it with Vim and Emacs should you wish to do so. The tools are located in the LLVM clang repository, which you can clone by following the instructions here: https://clang.llvm.org/get_started.html Quentin

3 3

Open source routing @ ietf meetup
by Lou Berger 20 Jul '17

20 Jul '17

Hi, Anyone interested in joining a "bring your own lunch" gathering of folks using/building open source routing code, please drop in to "London" on Thursday during lunch (noon). There is no agenda or slides... Cheers, Lou

4 5

Возможная блокировка github в Российской федерации / Possible blocking of github in the Russian Federation
by Алексей Болдырев 20 Jul '17

20 Jul '17

Обращаю внимание разработчиков и тестеров из России, что в России готовится закон о запрете анонимайзеров и VPN для частных лиц: https://www.linux.org.ru/forum/talks/13555716 Также возможно то, что в России будет возможно заблокирован github, что создаст сложности разработчикам и тестировщикам из Российской федерации. По этому я предлагаю сделать копию кода FRRouting на локальный сервер, а также поддерживать этот локальный сервер. -- I draw the attention of developers and testers from Russia that the law on banning anonymizers and VPN for private individuals is being prepared in Russia: Https://www.linux.org.ru/forum/talks/13555716 It is also possible that github will be blocked in Russia, which will create difficulties for developers and testers from the Russian Federation. Therefore, I propose to make a copy of the FRRouting code on the local server, and also support this local server.

2 1

FRR Technical Meeting Digest
by Quentin Young 18 Jul '17

18 Jul '17

PR's ------- #554 zebra: remove duplicate nexthop 1. waiting on donald for test results #783 add pseudowire mgmt in zebra: 1. Donald + Renato, waiting on your review 2. Bingen -> see static analysis issue and martin's comment re: json output #797 pim vrf 1. Waiting on reviewers #805 Add OSPF API and FRR Hacking documents 1. This brings up need for better API / developer's documentation overall 2. Olivier to open an issue & start a mailing list thread regarding this 3. OSPF docs w/o frr-hacking.md merged. Open Issues ------------ See comments and assignees on issue pages. General ------- All -- if you own a pull request that has merge conflicts, these are likely due to whitespace changes. Please see Friday's email for information on how to update your code to Linux kernel style and resolve the conflicts so we can get your patch in.

1 0