August 2017 - dev - lists.frrouting.org

Reindent issues
by Bingen Eguzkitza 22 Aug '17

22 Aug '17

Hi, I was trying to apply instructions here (rebase case): https://github.com/FRRouting/frr/wiki/Reindenting but for stable/3.0, and maybe I'm missing something, but it's not working as I would expect. To make it easy to reproduce, and to discard causes related to my branch, what I'm doing is: $ git checkout reindent-3.0-before $ git checkout -b test_reindent $ git cherry-pick reindent-3.0-before Now I have a new branch identical to reindent-3.0-after, can be checked with: $ git diff test_reindent reindent-3.0-after I do this so the script treats it as a new non-rebased branch. Then: $ python git-reindent-branch.py test_reindent I would expect that reindented branch is still identical to reindent-3.0-after, but it's not: $ git diff --stat reindented-branch reindent-3.0-after (...) <- see attached for details 598 files changed, 269745 insertions(+), 244747 deletions(-) How was the reindentation for stable-3.0 done? Was this script used? Thanks, ßingen.

2 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 22 Aug '17

22 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1454535: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_hello.c: 419 in eigrp_sw_version_initialize() ________________________________________________________________________________________________________ *** CID 1454535: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_hello.c: 419 in eigrp_sw_version_initialize() 413 char ver_string[] = VERSION; 414 char *dash = strstr(ver_string, "-"); 415 416 if (dash) 417 dash[0] = '\0'; 418 >>> CID 1454535: Error handling issues (CHECKED_RETURN) >>> Calling "sscanf" without checking return value (as is done elsewhere 37 out of 41 times). 419 sscanf(ver_string, "%d.%d", &FRR_MAJOR, &FRR_MINOR); 420 } 421 422 /** 423 * @fn eigrp_sw_version_encode 424 * ** CID 1454534: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1333 in zread_ipv4_delete() ________________________________________________________________________________________________________ *** CID 1454534: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1333 in zread_ipv4_delete() 1327 * by label, but 1328 * we don't care for delete. 1329 */ 1330 if (CHECK_FLAG(api.message, ZAPI_MESSAGE_LABEL)) 1331 stream_forward_getp(s, 1332 sizeof(u_int32_t)); >>> CID 1454534: Memory - corruptions (OVERRUN) >>> Assigning: "nexthop_p" = "&nexthop". "nexthop_p" now points to byte 0 of "nexthop" (which consists of 4 bytes). 1333 nexthop_p = (union g_addr *)&nexthop; 1334 break; 1335 case NEXTHOP_TYPE_IPV4_IFINDEX: 1336 nexthop.s_addr = stream_get_ipv4(s); 1337 nexthop_p = (union g_addr *)&nexthop; 1338 ifindex = stream_getl(s); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Issue with route-map on route-reflector?
by François Serman 22 Aug '17

22 Aug '17

Hi, First of all, I hope this is the appropriate ML :) I have an issue with route-map applied to reflected route, in the following scheme: A [ exaBGP ] --- advertises prefixes ---> B [ FRR ] --- appends attributes ----> C [ FRR ] 10.1.0.1 10.2.0.1 10.3.0.254 A advertises prefixes (1.1.1.1-24/32 with next hop 1.2.3.4). B is supposed to set a community (I've added local-pref and changed the next-hop to make for tests purposes). C is supposed to have an aggregated view of the prefixes decorated with the communities. My issue is : A's advertised-routes output seems OK (next hop, local pref) but only the local network (as in bgp router id block) is actually changed. I didn't find anything in the documentation about that. I've only found a mention in the cisco documentation (https://www.cisco.com/c/en/us/td/docs/ios-xml/ios/iproute_bgp/configuration…) : "The use of set clauses in outbound route maps can modify attributes and possibly create routing loops. To avoid this behavior, most set clauses of outbound route maps are ignored for routes reflected to iBGP peers. The only set clause of an outbound route map on a route reflector (RR) that is acted upon is the set ip next-hop clause. The set ip next-hop clause is applied to reflected routes. " Is there something I'm missing? Also, I've been checking who was right using tcmdump, attached to this email. Here is B's config: router bgp 65001 bgp router-id 10.2.0.1 bgp log-neighbor-changes neighbor my_route_advertisers peer-group neighbor my_route_reflectors peer-group neighbor my_route_reflectors remote-as internal neighbor my_route_reflectors description route-forwarder neighbor 10.3.0.254 remote-as 65001 neighbor 10.3.0.254 peer-group my_route_advertisers neighbor 10.1.0.1 peer-group my_route_reflectors ! address-family ipv4 unicast network 192.168.21.0/24 neighbor my_route_advertisers route-map deny-in in neighbor my_route_reflectors route-reflector-client neighbor my_route_reflectors route-map deny-out out neighbor 10.3.0.254 route-map apply-community out exit-address-family vnc defaults response-lifetime 3600 exit-vnc ! route-map apply-community permit 10 set community 65001:1010 set ip next-hop 8.8.8.8 set local-preference 10 ! route-map deny-in deny 5 ! route-map deny-out deny 5 and its advertised routes: # sh ip bgp neighbors 10.3.0.254 advertised-routes BGP table version is 25, local router ID is 10.2.0.1 Status codes: s suppressed, d damped, h history, * valid, > best, = multipath, i internal, r RIB-failure, S Stale, R Removed Origin codes: i - IGP, e - EGP, ? - incomplete Network Next Hop Metric LocPrf Weight Path *> 1.1.1.1/32 8.8.8.8 0 10 0 i .... *> 1.1.1.24/32 8.8.8.8 0 10 0 i *> 192.168.21.0 8.8.8.8 0 10 32768 i Total number of prefixes 25 And now, C's config: router bgp 65001 bgp router-id 10.3.0.254 bgp log-neighbor-changes neighbor my_route_advertisers peer-group neighbor my_route_reflectors peer-group neighbor my_route_reflectors remote-as internal neighbor my_route_reflectors description route-forwarder neighbor 10.4.0.254 remote-as 65001 neighbor 10.4.0.254 peer-group my_route_advertisers neighbor 10.2.0.1 peer-group my_route_reflectors neighbor 10.2.0.2 peer-group my_route_reflectors ! address-family ipv4 unicast neighbor my_route_advertisers route-map deny-in in neighbor my_route_reflectors route-reflector-client neighbor my_route_reflectors route-map deny-out out neighbor 10.2.0.1 soft-reconfiguration inbound exit-address-family vnc defaults response-lifetime 3600 exit-vnc ! route-map deny-in deny 5 ! route-map deny-out deny 5 rr# show ip bgp neighbors 10.2.0.1 received-routes BGP table version is 0, local router ID is 10.3.0.254 Status codes: s suppressed, d damped, h history, * valid, > best, = multipath, i internal, r RIB-failure, S Stale, R Removed Origin codes: i - IGP, e - EGP, ? - incomplete Network Next Hop Metric LocPrf Weight Path *> 1.1.1.1/32 1.2.3.4 0 100 0 i ..... *> 1.1.1.24/32 1.2.3.4 0 100 0 i *> 192.168.21.0 8.8.8.8 0 10 0 i Total number of prefixes 25 Thanks! François

2 3

FWD: Re: [FRRouting/frr] eigrpd: Setup eigrp to send FRR version (#1012)
by Andrew Lunn 21 Aug '17

21 Aug '17

----- Forwarded message from LabN CI User <notifications(a)github.com> ----- Date: Sun, 20 Aug 2017 11:07:31 -0700 From: LabN CI User <notifications(a)github.com> To: FRRouting/frr <frr(a)noreply.github.com> Cc: Subscribed <subscribed(a)noreply.github.com> Subject: Re: [FRRouting/frr] eigrpd: Setup eigrp to send FRR version (#1012) X-Spam-Status: No, score=-6.9 required=4.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_HI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 # LabN CI results: SUCCESS, 0 tests failed <table border='1' cellpadding='2' align='center' width='100%'> <tr style=bold> <td><h4>Result</h4></td> <td><h4>Date</h4></td> <td><h4>Start</h4></td> <td><h4>Finish</h4></td> <td><h4>Run<BR>Time</h4></td> <td><h4>Total</h4></td> <td><h4>Pass</h4></td> <td><h4>Fail</h4></td> <td><h4>Valgrind<BR>Errors</h4></td> <td><h4>Valgrind<BR>Loss</h4></td> <td><h4>Details</h4></td> <td><h4>Log</h4></td> </tr> <tr> <td><font color=green>SUCCESS <a href='https://github.com/FRRouting/frr'>git</a> <a href='https://github.com/FRRouting/frr/pull/1012'>merge/1012</a> <a href=https://github.com/FRRouting/frr/commit/ca9e3d23>ca9e3d23</a></font></td> <td>08/20/2017</td> <td>13:44:05</td> <td>14:07:29</td> <td>23:24</td> <td>1805</td> <td>1805</td> <td><a href=mailto:lberger@labn.net>0</a></td> <td><a href=mailto:lberger@labn.net>0</a></td> <td><a href=mailto:lberger@labn.net>0</a></td> <td><a href=mailto:lberger@labn.net>.txt</a></td> <td><a href=mailto:lberger@labn.net>.bz2</a></td> </tr></table></center>For details, please contact @louberger -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/FRRouting/frr/pull/1012#issuecomment-323601458 ----- End forwarded message ----- Could somebody ask the LabN CI system to not html encrypt its contents in the plain text segment. Andrew

2 6

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 Aug '17

19 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1454333: (STRING_OVERFLOW) /eigrpd/eigrp_packet.c: 618 in eigrp_read() /eigrpd/eigrp_packet.c: 619 in eigrp_read() ________________________________________________________________________________________________________ *** CID 1454333: (STRING_OVERFLOW) /eigrpd/eigrp_packet.c: 618 in eigrp_read() 612 start of the eigrp TLVs */ 613 opcode = eigrph->opcode; 614 615 if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { 616 char src[100], dst[100]; 617 >>> CID 1454333: (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "src" by copying the return value of "inet_ntoa" without checking the length. 618 strcpy(src, inet_ntoa(iph->ip_src)); 619 strcpy(dst, inet_ntoa(iph->ip_dst)); 620 zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", 621 lookup_msg(eigrp_packet_type_str, opcode, NULL), 622 ntohl(eigrph->sequence), ntohl(eigrph->ack), length, 623 IF_NAME(ei), src, dst); /eigrpd/eigrp_packet.c: 619 in eigrp_read() 613 opcode = eigrph->opcode; 614 615 if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { 616 char src[100], dst[100]; 617 618 strcpy(src, inet_ntoa(iph->ip_src)); >>> CID 1454333: (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "dst" by copying the return value of "inet_ntoa" without checking the length. 619 strcpy(dst, inet_ntoa(iph->ip_dst)); 620 zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", 621 lookup_msg(eigrp_packet_type_str, opcode, NULL), 622 ntohl(eigrph->sequence), ntohl(eigrph->ack), length, 623 IF_NAME(ei), src, dst); 624 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

FRR 3.0-rc1 tagged & available for testing
by David Lamparter 16 Aug '17

16 Aug '17

Hi all, FRRouting 3.0-rc1 has been tagged on git and the appropriate tarballs are available for download at: https://github.com/FRRouting/frr/releases/tag/frr-3.0-rc1 https://github.com/FRRouting/frr/releases/download/frr-3.0-rc1/frr-3.0-rc1.… For a list of changes, please refer to https://github.com/FRRouting/frr/wiki/FRR-2.0-%E2%86%92-FRR-3.0-Changelog Highlights include: - BGP Large Community support - OSPFv3 Authentication/Confidentiality support - PIM-SM - NHRP - L2VPN/VPLS support (OpenBSD only) The CLI has been significantly reworked, though old configurations should still load. This would be a good time for all interested parties to test and file issues on github for any problems found: https://github.com/FRRouting/frr/issues This *is* a release candidate, so please expect a glitch or two. Cheers, -David

1 0

Todays Technical Meeting 11 am EDT
by Donald Sharp 15 Aug '17

15 Aug '17

https://bluejeans.com/9192742159 1) Meeting Note Taker? 2) 3.0 status 3) New Issues 4) PR's 4a) BGP api change( #939 ) 5) Issue cleanup 6) Anything else? donald

2 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 15 Aug '17

15 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1454156: Uninitialized variables (UNINIT) /lib/routemap.c: 2204 in no_set_ip_nexthop() ________________________________________________________________________________________________________ *** CID 1454156: Uninitialized variables (UNINIT) /lib/routemap.c: 2204 in no_set_ip_nexthop() 2198 NO_STR 2199 SET_STR 2200 IP_STR 2201 "Next hop address\n" 2202 "IP address of next hop\n") 2203 { >>> CID 1454156: Uninitialized variables (UNINIT) >>> Declaring variable "idx" without initializer. 2204 int idx; 2205 VTY_DECLVAR_CONTEXT(route_map_index, index); 2206 const char *arg = NULL; 2207 2208 if (argv_find(argv, argc, "A.B.C.D", &idx)) 2209 arg = argv[idx]->arg; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Vty password is not set error
by $iddhe$h Divekar 11 Aug '17

11 Aug '17

Hi All, I was successful in installing quaga and got it working fine. Then I decided to try frr. I followed all the instructions mentioned in the link below. https://github.com/FRRouting/frr/blob/master/doc/Building_ FRR_on_Ubuntu1604.md Now when I try to telnet to zebra, it says "Vty password is not set". telnet localhost zebra Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. Vty password is not set. Connection closed by foreign host. I have added following config to /etc/frr/zebra.conf but that is not helping. sudo cat /etc/frr/zebra.conf [sudo] password for sidhesh: ! Zebra configuration saved from vty ! 2002/02/28 01:46:12 ! hostname LinuxRouter password zebra enable password z3bRa log file /var/log/zebra/zebra.log ! interface eth0 description Interface to External Network ip address 10.0.0.1/24 ! interface eth1 description Interface to Internal Network ip address 192.168.66.1/24 password zebra How do I configure Vty password for zebra in frr. -- -$iddhesh.

2 3

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 10 Aug '17

10 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 9 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 9 of 9 defect(s) ** CID 1453456: Error handling issues (CHECKED_RETURN) /lib/libfrr.c: 774 in frr_daemon_ctl() ________________________________________________________________________________________________________ *** CID 1453456: Error handling issues (CHECKED_RETURN) /lib/libfrr.c: 774 in frr_daemon_ctl() 768 if (nr <= 0) 769 return 0; 770 771 switch (buf[0]) { 772 case 'S': /* SIGTSTP */ 773 vty_stdio_suspend(); >>> CID 1453456: Error handling issues (CHECKED_RETURN) >>> Calling "send(daemon_ctl_sock, "s", 1UL, 0)" without checking return value. This library function may fail and return an error code. 774 send(daemon_ctl_sock, "s", 1, 0); 775 break; 776 case 'R': /* SIGTCNT [implicit] */ 777 vty_stdio_resume(); 778 break; 779 case 'I': /* SIGINT */ ** CID 1453455: Null pointer dereferences (NULL_RETURNS) /bgpd/bgpd.c: 2585 in peer_group_bind() ________________________________________________________________________________________________________ *** CID 1453455: Null pointer dereferences (NULL_RETURNS) /bgpd/bgpd.c: 2585 in peer_group_bind() 2579 } 2580 2581 if (peer->group) { 2582 assert(group && peer->group == group); 2583 } else { 2584 struct listnode *pn; >>> CID 1453455: Null pointer dereferences (NULL_RETURNS) >>> Assigning: "pn" = null return value from "listnode_lookup". 2585 pn = listnode_lookup(bgp->peer, peer); 2586 list_delete_node(bgp->peer, pn); 2587 peer->group = group; 2588 listnode_add_sort(bgp->peer, peer); 2589 2590 peer = peer_lock(peer); /* group->peer list reference */ ** CID 1453454: (RESOURCE_LEAK) /zebra/zebra_vxlan.c: 1397 in zvni_gw_macip_del() /zebra/zebra_vxlan.c: 1407 in zvni_gw_macip_del() ________________________________________________________________________________________________________ *** CID 1453454: (RESOURCE_LEAK) /zebra/zebra_vxlan.c: 1397 in zvni_gw_macip_del() 1391 if (!n) 1392 return 0; 1393 1394 /* mac entry should be present */ 1395 mac = zvni_mac_lookup(zvni, &n->emac); 1396 if (!mac) >>> CID 1453454: (RESOURCE_LEAK) >>> Failing to save or free storage allocated by "prefix_mac2str(&n->emac, NULL, 18)" leaks it. 1397 zlog_err("%u: MAC %s doesnt exsists for neigh %s on VNI %u", 1398 ifp->vrf_id, 1399 prefix_mac2str(&n->emac, NULL, ETHER_ADDR_STRLEN), 1400 ipaddr2str(ip, buf2, sizeof(buf2)), zvni->vni); 1401 1402 /* If the entry is not local nothing to do*/ /zebra/zebra_vxlan.c: 1407 in zvni_gw_macip_del() 1401 1402 /* If the entry is not local nothing to do*/ 1403 if (!CHECK_FLAG(n->flags, ZEBRA_NEIGH_LOCAL)) 1404 return -1; 1405 1406 if (IS_ZEBRA_DEBUG_VXLAN) >>> CID 1453454: (RESOURCE_LEAK) >>> Failing to save or free storage allocated by "prefix_mac2str(&n->emac, NULL, 18)" leaks it. 1407 zlog_debug( 1408 "%u:SVI %s(%u) VNI %u, sending GW MAC %s IP %s del to BGP", 1409 ifp->vrf_id, ifp->name, ifp->ifindex, zvni->vni, 1410 prefix_mac2str(&(n->emac), NULL, ETHER_ADDR_STRLEN), 1411 ipaddr2str(ip, buf2, sizeof(buf2))); 1412 ** CID 1453453: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vxlan.c: 1396 in zvni_gw_macip_del() ________________________________________________________________________________________________________ *** CID 1453453: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vxlan.c: 1396 in zvni_gw_macip_del() 1390 n = zvni_neigh_lookup(zvni, ip); 1391 if (!n) 1392 return 0; 1393 1394 /* mac entry should be present */ 1395 mac = zvni_mac_lookup(zvni, &n->emac); >>> CID 1453453: Null pointer dereferences (FORWARD_NULL) >>> Comparing "mac" to null implies that "mac" might be null. 1396 if (!mac) 1397 zlog_err("%u: MAC %s doesnt exsists for neigh %s on VNI %u", 1398 ifp->vrf_id, 1399 prefix_mac2str(&n->emac, NULL, ETHER_ADDR_STRLEN), 1400 ipaddr2str(ip, buf2, sizeof(buf2)), zvni->vni); 1401 ** CID 1453452: Control flow issues (DEADCODE) /bgpd/bgp_route.c: 10267 in bgp_show_neighbor_route() ________________________________________________________________________________________________________ *** CID 1453452: Control flow issues (DEADCODE) /bgpd/bgp_route.c: 10267 in bgp_show_neighbor_route() 10261 vty_out(vty, "%% No such neighbor or address family\n"); 10262 return CMD_WARNING; 10263 } 10264 10265 /* labeled-unicast routes live in the unicast table */ 10266 if (safi == SAFI_LABELED_UNICAST) >>> CID 1453452: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "safi = SAFI_UNICAST;". 10267 safi = SAFI_UNICAST; 10268 10269 return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, use_json); 10270 } 10271 10272 DEFUN (show_ip_bgp_neighbor_routes, ** CID 1453451: Error handling issues (NEGATIVE_RETURNS) /lib/libfrr.c: 752 in frr_terminal_close() ________________________________________________________________________________________________________ *** CID 1453451: Error handling issues (NEGATIVE_RETURNS) /lib/libfrr.c: 752 in frr_terminal_close() 746 } else { 747 printf("\n%s daemonizing\n", di->name); 748 fflush(stdout); 749 } 750 751 int nullfd = open("/dev/null", O_RDONLY | O_NOCTTY); >>> CID 1453451: Error handling issues (NEGATIVE_RETURNS) >>> "nullfd" is passed to a parameter that cannot be negative. 752 dup2(nullfd, 0); 753 dup2(nullfd, 1); 754 dup2(nullfd, 2); 755 close(nullfd); 756 } 757 ** CID 1453450: Resource leaks (RESOURCE_LEAK) /bgpd/bgp_routemap.c: 662 in route_match_vni_compile() ________________________________________________________________________________________________________ *** CID 1453450: Resource leaks (RESOURCE_LEAK) /bgpd/bgp_routemap.c: 662 in route_match_vni_compile() 656 vni = XMALLOC(MTYPE_ROUTE_MAP_COMPILED, sizeof(vni_t)); 657 if (!vni) 658 return NULL; 659 660 *vni = strtoul(arg, &end, 10); 661 if (*end != '\0') >>> CID 1453450: Resource leaks (RESOURCE_LEAK) >>> Variable "vni" going out of scope leaks the storage it points to. 662 return NULL; 663 664 return vni; 665 } 666 667 /* Free route map's compiled `vni' value. */ ** CID 1453449: Error handling issues (NEGATIVE_RETURNS) /lib/libfrr.c: 817 in frr_run() ________________________________________________________________________________________________________ *** CID 1453449: Error handling issues (NEGATIVE_RETURNS) /lib/libfrr.c: 817 in frr_run() 811 set_nonblocking(daemon_ctl_sock); 812 thread_add_read(master, frr_daemon_ctl, NULL, 813 daemon_ctl_sock, &daemon_ctl_thread); 814 } 815 } else { 816 int nullfd = open("/dev/null", O_RDONLY | O_NOCTTY); >>> CID 1453449: Error handling issues (NEGATIVE_RETURNS) >>> "nullfd" is passed to a parameter that cannot be negative. 817 dup2(nullfd, 0); 818 dup2(nullfd, 1); 819 dup2(nullfd, 2); 820 close(nullfd); 821 822 if (daemon_ctl_sock != -1) ** CID 1453448: Resource leaks (RESOURCE_LEAK) /zebra/zebra_vxlan.c: 1362 in zvni_gw_macip_add() ________________________________________________________________________________________________________ *** CID 1453448: Resource leaks (RESOURCE_LEAK) /zebra/zebra_vxlan.c: 1362 in zvni_gw_macip_add() 1356 n->ifindex = ifp->ifindex; 1357 1358 /* We have a neigh associated to mac increment the refcnt*/ 1359 mac->neigh_refcnt++; 1360 1361 if (IS_ZEBRA_DEBUG_VXLAN) >>> CID 1453448: Resource leaks (RESOURCE_LEAK) >>> Failing to save or free storage allocated by "prefix_mac2str(macaddr, NULL, 18)" leaks it. 1362 zlog_debug( 1363 "%u:SVI %s(%u) VNI %u, sending GW MAC %s IP %s add to BGP", 1364 ifp->vrf_id, ifp->name, ifp->ifindex, zvni->vni, 1365 prefix_mac2str(macaddr, NULL, ETHER_ADDR_STRLEN), 1366 ipaddr2str(ip, buf2, sizeof(buf2))); 1367 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0