January 2018 - dev - lists.frrouting.org

Static VRF Route Leaking
by Donald Sharp 23 Jan '18

23 Jan '18

All - I'd like to thanks Philippe Guibert, Lou Berger, Renato Westphal and Russ White working with me to get static route leaking into the FRR code base on master. To configure: vrf DONNA ip route 4.3.2.1/32 99.1.2.3 nexthop-vrf EVA ! vrf EVA ip route 9.1.2.3/32 44.3.2.4 nexthop-vrf DONNA ! These two commands create a static route that leaks the nexthops into the appropriate vrf's. At this point in time, BGP has not been modified to take advantage of vrf route leaking in the traditional manner, but the underpinnings in zebra and the zapi protocol are now there. donald

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 Jan '18

18 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1464192: Insecure data handling (INTEGER_OVERFLOW) /vtysh/vtysh.c: 204 in vtysh_client_run() ________________________________________________________________________________________________________ *** CID 1464192: Insecure data handling (INTEGER_OVERFLOW) /vtysh/vtysh.c: 204 in vtysh_client_run() 198 } 199 200 /* else if no callback, dump raw */ 201 if (!callback) { 202 if (fp) 203 fwrite(buf, 1, textlen, fp); >>> CID 1464192: Insecure data handling (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "bufvalid - buf - textlen" used as critical argument to function. 204 memmove(buf, buf + textlen, bufvalid - buf - textlen); 205 bufvalid -= textlen; 206 } 207 208 if (bufvalid == buf + bufsz) { 209 char *new; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Invite to frrouting.slack.com please
by Gregorio Tomas Focaccio 14 Jan '18

14 Jan '18

Hi All, My name if Greg Focaccio. I am lead network engineer at https://cari.net and fiberalley.com in San Diego, CA I am excited about frr and want to get started working with it. Could I please have an invite to frrouting.slack.com so I can begin to participate? Preferred email would be this one: public.focaccio(a)gmail.com my full name is Greg Focaccio and phone number 619-534-1332. Thanks, Greg

2 1

New EVPN Code in Master
by Donald Sharp 13 Jan '18

13 Jan '18

All - EVPN control plane in FRR is now enhanced so that it supports both asymmetric and symmetric routing models. Prefix-based routing is also supported using EVPN type-5 routes. Also, with all routing models, L3 multi-tenancy is inherently supported I'd like to thank Mitesh for his hard work getting this done! thanks! donald

1 0

Release 3.0.3
by Donald Sharp 13 Jan '18

13 Jan '18

All - Release 3.0.3 has been spun up. Changes over version 3.0.2: Fixes for GCC 7.0 Always enable watchfrr on new installation (req for systemd operation) Add 'no password' command (with warning) Added Ubuntu 17.10 Package support in source (no binary packages built [yet]) https://github.com/FRRouting/frr/releases Thanks! donald

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 12 Jan '18

12 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1463851: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_evpn.c: 395 in map_vrf_to_rt() ________________________________________________________________________________________________________ *** CID 1463851: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_evpn.c: 395 in map_vrf_to_rt() 389 memcpy(&eval_tmp, eval, ECOMMUNITY_SIZE); 390 if (!CHECK_FLAG(bgp_vrf->vrf_flags, 391 BGP_VRF_IMPORT_RT_CFGD)) 392 mask_ecom_global_admin(&eval_tmp, eval); 393 394 irt = lookup_vrf_import_rt(&eval_tmp); >>> CID 1463851: Null pointer dereferences (FORWARD_NULL) >>> Comparing "irt->vrfs" to null implies that "irt->vrfs" might be null. 395 if (irt && irt->vrfs) 396 if (is_vrf_present_in_irt_vrfs(irt->vrfs, bgp_vrf)) 397 /* Already mapped. */ 398 return; 399 400 if (!irt) { ** CID 1463850: Error handling issues (CHECKED_RETURN) /bgpd/bgp_evpn.c: 3808 in bgp_evpn_derive_auto_rd_for_vrf() ________________________________________________________________________________________________________ *** CID 1463850: Error handling issues (CHECKED_RETURN) /bgpd/bgp_evpn.c: 3808 in bgp_evpn_derive_auto_rd_for_vrf() 3802 { 3803 char buf[100]; 3804 3805 bgp->vrf_prd.family = AF_UNSPEC; 3806 bgp->vrf_prd.prefixlen = 64; 3807 sprintf(buf, "%s:%hu", inet_ntoa(bgp->router_id), bgp->vrf_rd_id); >>> CID 1463850: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix_rd" without checking return value (as is done elsewhere 14 out of 15 times). 3808 str2prefix_rd(buf, &bgp->vrf_prd); 3809 } 3810 3811 /* 3812 * Derive RD automatically for VNI using passed information - it 3813 * is of the form RouterId:unique-id-for-vni. ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

4.0 branch pull
by Donald Sharp 11 Jan '18

11 Jan '18

All - I intend to pull the 4.0 branch early next week. Now is the time for any last minute additions before we create it. Additionally I would like to create a 3.0.3 version with bug-fixes by the new years. So if you are missing anything or have a bug fix submitting it would be good. donald

5 14

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 04 Jan '18

04 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1463443: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_route_clippy.c: 111 in ipv6_bgp_network() ________________________________________________________________________________________________________ *** CID 1463443: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_route_clippy.c: 111 in ipv6_bgp_network() 105 int _i; 106 #if 1 /* anything that can fail? */ 107 unsigned _fail = 0, _failcnt = 0; 108 #endif 109 const char *no = NULL; 110 struct prefix_ipv6 prefix = { }; >>> CID 1463443: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix_str" = "NULL". 111 const char *prefix_str = NULL; 112 const char *map_name = NULL; 113 long label_index = 0; 114 const char *label_index_str = NULL; 115 116 for (_i = 0; _i < argc; _i++) { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Adding Python icinga/nagios plugin modules as their own repository in FRR?
by Donald Sharp 03 Jan '18

03 Jan '18

All - Patrick Velder is working on some python icinga/nagios plugin modules for status checking of BGP peers. I'd like to add to next weeks technical discussion how we as a community would like to support this type of work. Possibly bringing it in as it's own Repository under FRRouting. Patrick - Could you give us an example of how it would work/look like? thanks! donald

3 2