May 2018 - dev - lists.frrouting.org

Slack invite
by Wilhelm Wijkander 15 May '18

15 May '18

Would appreciate one... Regards, Wilhelm Wijkander

2 1

Request for Slack invite
by Simon Leinen 14 May '18

14 May '18

I'd like to participate in the FRRouting Slack channel. Our team uses FRR (Ubuntu/Docker/Cumulus versions) on most of our servers and switches. Thanks in advance! -- Simon.

2 1

Slack invite please
by Bruno Rijsman 14 May '18

14 May '18

Can I get a Slack invite please — Bruno

2 2

Today's Technical Meeting Agenda
by Philippe Guibert 08 May '18

08 May '18

Hi all, For todays call, there will be a discussion about Yang based management. Which approach should be taken to enhance Yang int FRRouting. We, at 6WIND would like to share with you our feedback about Yang approach, and the issues identified. You can find the link below for more information. https://docs.google.com/presentation/d/1rVCpH2VI1TnkAzZInlDUHAp9Zo4PjjzY9qz… Thanks, Philippe

7 18

notes from frr api discussion, 5/4/18
by Mark Stapp 04 May '18

04 May '18

Donald organized a conference call to focus on management and api issues. He suggested that I send around my notes, to give folks some overview of the discussion. I don't have a full attendee list, I'm sorry to say. And of course, if I've misrepresented something that someone said, please feel free to correct "the record"... * preso from 6Wind about their use of vty ** using xml transport between their own mgmt system and converting to vty ** command ordering an issue in cli/vty, as is feedback/validation ** planning to go forward with a yang-based schema, want api access, believe cli and api need to be converged as a single path ** Q from Donald: how do you handle shared objects, like route-map, acl, and prefix-list. "it's important that whatever solution we have understands that we have some shared/universal data" ** Renato W. gave a verbal overview of his 'northbound' proposal that has been mentioned on the regular dev call and in the yang slack channel; he will present slides and details soon we tried to list a few higher-level points : * attributes or objects? are we configuring individual attributes, or entire objects (or lists of objects)? * validation/handling logic inside daemons: what do they need to be able to do internally to ensure correctness, and what can be done by model-level validation (a benefit of models)? * sync vs. async (for transport, and for interaction with the daemon code) * shared/global objects (along the lines of Donald's point from earlier) * locking (per-attr? per-object? per-transaction - whatever that is?) what are the sorts of needs and expectations as we see more multi-threading in frr? * multi-admin (transactions concept): is this something that is a goal for frr, or is it the responsibility of external management systems? * impact on code (cli, running/protocol code, opportunity to auto-generate some config handler code?) * performance/mem - input of large config, paging of large data sets, e.g. * error-handling, feedback * multi-daemon, multi-process coordination (ease of daemon management, "it's really hard to set up mpls right now" [DS] ** behavior on restart among daemons, e.g. we discussed a follow-on meeting to continue the discussion, time tbd... Cheers, Mark

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 03 May '18

03 May '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1468512: Control flow issues (DEADCODE) /bgpd/bgp_pbr.c: 234 in bgp_pbr_build_and_validate_entry() ________________________________________________________________________________________________________ *** CID 1468512: Control flow issues (DEADCODE) /bgpd/bgp_pbr.c: 234 in bgp_pbr_build_and_validate_entry() 228 ecom = info->attr->ecommunity; 229 for (i = 0; i < ecom->size; i++) { 230 ecom_eval = (struct ecommunity_val *) 231 ecom->val + (i * ECOMMUNITY_SIZE); 232 233 if (action_count > ACTIONS_MAX_NUM) { >>> CID 1468512: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "if (term_bgp_debug_pbr & 2U...". 234 if (BGP_DEBUG(pbr, PBR_ERROR)) 235 zlog_err("%s: flowspec actions exceeds limit (max %u)", 236 __func__, action_count); 237 break; 238 } 239 api_action = &api->actions[action_count]; ** CID 1468511: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468511: Null pointer dereferences (FORWARD_NULL) /pimd/pim_msdp.c: 259 in pim_msdp_sa_new() 253 sa->uptime = pim_time_monotonic_sec(); 254 255 /* insert into misc tables for easy access */ 256 sa = hash_get(pim->msdp.sa_hash, sa, hash_alloc_intern); 257 if (!sa) { 258 zlog_err("%s: PIM hash get failure", __PRETTY_FUNCTION__); >>> CID 1468511: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "sa" to "pim_msdp_sa_free", which dereferences it. 259 pim_msdp_sa_free(sa); 260 return NULL; 261 } 262 listnode_add_sort(pim->msdp.sa_list, sa); 263 264 if (PIM_DEBUG_MSDP_EVENTS) { ** CID 1468510: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1468510: Null pointer dereferences (NULL_RETURNS) /ospf6d/ospf6_intra.c: 1326 in ospf6_intra_prefix_update_route_origin() 1320 struct ospf6_route *g_route, *nroute; 1321 1322 /* Update Global ospf6 route path */ 1323 g_route = ospf6_route_lookup(&oa_route->prefix, 1324 ospf6->route_table); 1325 >>> CID 1468510: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be null "g_route" when calling "ospf6_route_lock". 1326 for (ospf6_route_lock(g_route); g_route && 1327 ospf6_route_is_prefix(&oa_route->prefix, g_route); 1328 g_route = nroute) { 1329 nroute = ospf6_route_next(g_route); 1330 if (g_route->type != oa_route->type) 1331 continue; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

documentation now on the website
by Quentin Young 02 May '18

02 May '18

Hi folks, Updated documentation is now on the FRR website. User guide: https://frrouting.org/user-guide/ <https://frrouting.org/user-guide/> Developer’s guide: https://frrouting.org/dev-guide/ <https://frrouting.org/dev-guide/> This was built from the tip of master and should be accurate for the upcoming 4.0 release. Eventually I will work on a way to publish versioned documentation for each release. The developer documentation will be rolling. Thanks, Quentin

4 3