May 2019 - dev - lists.frrouting.org

ask for Ubuntu 19.04 (disco) support.
by SinYu 15 May '19

15 May '19

Hello, I am using ubuntu 19.04, i want to ask for get this support, how i do it? Ign:7 https://deb.frrouting.org/frr disco InRelease Err:8 https://deb.frrouting.org/frr disco Release 404 Not Found [IP: 185.142.180.129 443] Reading package lists... Done E: The repository 'https://deb.frrouting.org/frr disco Release' does not have a Release file. N: Updating from such a repository can't be done securely, and is therefore disabled by default. N: See apt-secure(8) manpage for repository creation and user configuration details.

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 14 May '19

14 May '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1480220: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1480220: Null pointer dereferences (FORWARD_NULL) /bfdd/bfd_packet.c: 529 in bfd_recv_cb() 523 uint8_t msgbuf[1516]; 524 struct bfd_vrf_global *bvrf = THREAD_ARG(t); 525 526 if (bvrf) 527 vrfid = bvrf->vrf->vrf_id; 528 /* Schedule next read. */ >>> CID 1480220: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "bvrf" to "bfd_sd_reschedule", which dereferences it. 529 bfd_sd_reschedule(bvrf, sd); 530 531 /* Handle echo packets. */ 532 if (sd == bvrf->bg_echo || sd == bvrf->bg_echov6) { 533 ptm_bfd_process_echo_pkt(bvrf, sd); 534 return 0; ** CID 1480219: (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1480219: (NULL_RETURNS) /bfdd/bfd.c: 182 in bfd_session_enable() 176 /* 177 * Get socket for transmitting control packets. Note that if we 178 * could use the destination port (3784) for the source 179 * port we wouldn't need a socket per session. 180 */ 181 if (BFD_CHECK_FLAG(bs->flags, BFD_SESS_FLAG_IPV6) == 0) { >>> CID 1480219: (NULL_RETURNS) >>> Dereferencing a pointer that might be null "bs->vrf" when calling "bp_peer_socket". 182 psock = bp_peer_socket(bs); 183 if (psock == -1) 184 return 0; 185 } else { 186 psock = bp_peer_socketv6(bs); 187 if (psock == -1) /bfdd/bfd.c: 186 in bfd_session_enable() 180 */ 181 if (BFD_CHECK_FLAG(bs->flags, BFD_SESS_FLAG_IPV6) == 0) { 182 psock = bp_peer_socket(bs); 183 if (psock == -1) 184 return 0; 185 } else { >>> CID 1480219: (NULL_RETURNS) >>> Dereferencing a pointer that might be null "bs->vrf" when calling "bp_peer_socketv6". 186 psock = bp_peer_socketv6(bs); 187 if (psock == -1) 188 return 0; 189 } 190 191 /* ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 13 May '19

13 May '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1480218: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1577 in lsp_update_internal() ________________________________________________________________________________________________________ *** CID 1480218: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1577 in lsp_update_internal() 1571 1572 if (ret == AOK) 1573 result = ZEBRA_DPLANE_REQUEST_QUEUED; 1574 else { 1575 atomic_fetch_add_explicit(&zdplane_info.dg_lsp_errors, 1, 1576 memory_order_relaxed); >>> CID 1480218: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1577 if (ctx) 1578 dplane_ctx_free(&ctx); 1579 } 1580 1581 return result; 1582 } ** CID 1480217: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1740 in intf_addr_update_internal() ________________________________________________________________________________________________________ *** CID 1480217: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1740 in intf_addr_update_internal() 1734 if (ret == AOK) 1735 result = ZEBRA_DPLANE_REQUEST_QUEUED; 1736 else { 1737 /* Error counter */ 1738 atomic_fetch_add_explicit(&zdplane_info.dg_intf_addr_errors, 1739 1, memory_order_relaxed); >>> CID 1480217: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1740 if (ctx) 1741 dplane_ctx_free(&ctx); 1742 } 1743 1744 return result; 1745 } ** CID 1480216: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1612 in pw_update_internal() ________________________________________________________________________________________________________ *** CID 1480216: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1612 in pw_update_internal() 1606 1607 if (ret == AOK) 1608 result = ZEBRA_DPLANE_REQUEST_QUEUED; 1609 else { 1610 atomic_fetch_add_explicit(&zdplane_info.dg_pw_errors, 1, 1611 memory_order_relaxed); >>> CID 1480216: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1612 if (ctx) 1613 dplane_ctx_free(&ctx); 1614 } 1615 1616 return result; 1617 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Re: [dev] I Write Again For This Project
by ＠Ms.E. Al-Hashimi, 05 May '19

05 May '19

1 0

If you have submitted a PR in the last 12-18 hours
by Donald Sharp 02 May '19

02 May '19

All - If you have submitted a PR in the last 12-18 hours we had a PR get pushed in that will cause all of them to fail due to valgrind issues. The push in of the broken PR was a mistake and we apologize for this disruption in your normal scheduled work. If you have pushed a PR in in the last 12-18 hours, please take a moment and rebase off of latest master to pickup the backout of the commits with the valgrind issue and force push an update. Thanks! donald

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 01 May '19

01 May '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 11 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 11 of 11 defect(s) ** CID 1479721: Null pointer dereferences (FORWARD_NULL) /ripngd/ripng_interface.c: 187 in ripng_if_down() ________________________________________________________________________________________________________ *** CID 1479721: Null pointer dereferences (FORWARD_NULL) /ripngd/ripng_interface.c: 187 in ripng_if_down() 181 182 if (ri->running) { 183 if (IS_RIPNG_DEBUG_EVENT) 184 zlog_debug("turn off %s", ifp->name); 185 186 /* Leave from multicast group. */ >>> CID 1479721: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "ripng". 187 ripng_multicast_leave(ifp, ripng->sock); 188 189 ri->running = 0; 190 } 191 192 return 0; ** CID 1479720: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1479720: Memory - corruptions (OVERRUN) /isisd/fabricd.c: 389 in fabricd_calculate_fabric_tier() 383 384 if (!furthest_from_remote) { 385 zlog_info("OpenFabric: Found no furthest node in remote spf"); 386 isis_spftree_del(remote_tree); 387 return ISIS_TIER_UNDEFINED; 388 } else { >>> CID 1479720: Memory - corruptions (OVERRUN) >>> Overrunning array "furthest_from_remote->N.id" of 7 bytes by passing it to a function which accesses it at byte offset 7. 389 zlog_info("OpenFabric: Found %s as furthest from remote dist == %" 390 PRIu32, rawlspid_print(furthest_from_remote->N.id), 391 furthest_from_remote->d_N); 392 } 393 394 int64_t tier = furthest_from_remote->d_N - furthest_t0->d_N; ** CID 1479719: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1479719: Null pointer dereferences (FORWARD_NULL) /pimd/pim_vxlan.c: 351 in pim_vxlan_orig_mr_up_add() 345 nht_p.u.prefix4 = up->upstream_addr; 346 pim_delete_tracked_nexthop(vxlan_sg->pim, 347 &nht_p, up, NULL); 348 } 349 pim_upstream_ref(up, flags, __PRETTY_FUNCTION__); 350 vxlan_sg->up = up; >>> CID 1479719: Null pointer dereferences (FORWARD_NULL) >>> Passing "vxlan_sg" to "pim_vxlan_orig_mr_up_iif_update", which dereferences null "vxlan_sg->iif". 351 pim_vxlan_orig_mr_up_iif_update(vxlan_sg); 352 } else { 353 up = pim_upstream_add(vxlan_sg->pim, &vxlan_sg->sg, 354 vxlan_sg->iif, flags, 355 __PRETTY_FUNCTION__, NULL); 356 vxlan_sg->up = up; ** CID 1479718: (BUFFER_SIZE_WARNING) /zebra/zebra_dplane.c: 1709 in intf_addr_update_internal() /zebra/zebra_dplane.c: 1737 in intf_addr_update_internal() ________________________________________________________________________________________________________ *** CID 1479718: (BUFFER_SIZE_WARNING) /zebra/zebra_dplane.c: 1709 in intf_addr_update_internal() 1703 zns = zebra_ns_lookup(ifp->vrf_id); 1704 dplane_ctx_ns_init(ctx, zns, false); 1705 1706 /* Init the interface-addr-specific area */ 1707 memset(&ctx->u.intf, 0, sizeof(ctx->u.intf)); 1708 >>> CID 1479718: (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 20 bytes on destination array "ctx->u.intf.ifname" of size 20 bytes might leave the destination string unterminated. 1709 strncpy(ctx->u.intf.ifname, ifp->name, sizeof(ctx->u.intf.ifname)); 1710 ctx->u.intf.ifindex = ifp->ifindex; 1711 ctx->u.intf.prefix = *(ifc->address); 1712 1713 if (if_is_broadcast(ifp)) 1714 ctx->u.intf.flags |= DPLANE_INTF_BROADCAST; /zebra/zebra_dplane.c: 1737 in intf_addr_update_internal() 1731 ctx->u.intf.flags |= DPLANE_INTF_HAS_LABEL; 1732 1733 /* Use embedded buffer if it's adequate; else allocate. */ 1734 len = strlen(ifc->label); 1735 1736 if (len < sizeof(ctx->u.intf.label_buf)) { >>> CID 1479718: (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 32 bytes on destination array "ctx->u.intf.label_buf" of size 32 bytes might leave the destination string unterminated. 1737 strncpy(ctx->u.intf.label_buf, ifc->label, 1738 sizeof(ctx->u.intf.label_buf)); 1739 ctx->u.intf.label = ctx->u.intf.label_buf; 1740 } else { 1741 ctx->u.intf.label = strdup(ifc->label); 1742 } ** CID 1479717: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1479717: Null pointer dereferences (FORWARD_NULL) /pimd/pim_vxlan.c: 947 in pim_vxlan_term_mr_oif_update() 941 if (PIM_DEBUG_VXLAN) 942 zlog_debug("vxlan SG %s term oif changed from %s to %s", 943 vxlan_sg->sg_str, 944 vxlan_sg->term_oif ? vxlan_sg->term_oif->name : "-", 945 ifp ? ifp->name : "-"); 946 >>> CID 1479717: Null pointer dereferences (FORWARD_NULL) >>> Passing "vxlan_sg" to "pim_vxlan_term_mr_del", which dereferences null "vxlan_sg->term_oif". 947 pim_vxlan_term_mr_del(vxlan_sg); 948 vxlan_sg->term_oif = ifp; 949 pim_vxlan_term_mr_add(vxlan_sg); 950 } 951 952 void pim_vxlan_add_term_dev(struct pim_instance *pim, ** CID 1479716: Null pointer dereferences (REVERSE_INULL) /pimd/pim_vxlan.c: 267 in pim_vxlan_orig_mr_up_iif_update() ________________________________________________________________________________________________________ *** CID 1479716: Null pointer dereferences (REVERSE_INULL) /pimd/pim_vxlan.c: 267 in pim_vxlan_orig_mr_up_iif_update() 261 pim_scan_individual_oil(vxlan_sg->up->channel_oil, 262 vif_index); 263 264 if (PIM_DEBUG_VXLAN) 265 zlog_debug("vxlan SG %s orig mroute-up updated with iif %s vifi %d", 266 vxlan_sg->sg_str, >>> CID 1479716: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "vxlan_sg->iif" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 267 vxlan_sg->iif?vxlan_sg->iif->name:"-", vif_index); 268 269 } 270 271 /* For every VxLAN BUM multicast group we setup a SG-up that has the following 272 * "forced properties" - ** CID 1479715: API usage errors (USE_AFTER_FREE) /ospfd/ospf_network.c: 239 in ospf_sock_init() ________________________________________________________________________________________________________ *** CID 1479715: API usage errors (USE_AFTER_FREE) /ospfd/ospf_network.c: 239 in ospf_sock_init() 233 if (ret < 0) 234 flog_err(EC_LIB_SOCKET, 235 "Can't set pktinfo option for fd %d", 236 ospf_sock); 237 } 238 >>> CID 1479715: API usage errors (USE_AFTER_FREE) >>> Passing closed handle "ospf_sock" as an argument to "setsockopt_so_sendbuf". 239 setsockopt_so_sendbuf(ospf_sock, bufsize); 240 setsockopt_so_recvbuf(ospf_sock, bufsize); 241 242 ospf->fd = ospf_sock; 243 return ret; ** CID 1479714: Security best practices violations (DC.WEAK_CRYPTO) /lib/typesafe.c: 194 in typesafe_skiplist_add() ________________________________________________________________________________________________________ *** CID 1479714: Security best practices violations (DC.WEAK_CRYPTO) /lib/typesafe.c: 194 in typesafe_skiplist_add() 188 { 189 size_t level = SKIPLIST_MAXDEPTH, newlevel, auxlevel; 190 struct sskip_item *prev = &head->hitem, *next, *auxprev, *auxnext; 191 int cmpval; 192 193 /* level / newlevel are 1-counted here */ >>> CID 1479714: Security best practices violations (DC.WEAK_CRYPTO) >>> "random" should not be used for security related applications, as linear congruential algorithms are too easy to break. 194 newlevel = __builtin_ctz(random()) + 1; 195 if (newlevel > SKIPLIST_MAXDEPTH) 196 newlevel = SKIPLIST_MAXDEPTH; 197 198 next = NULL; 199 while (level >= newlevel) { ** CID 1479713: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1479713: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 208 in show_ip_nht() 202 } 203 #if 1 /* anything that can fail? */ 204 if (_failcnt) 205 return CMD_WARNING; 206 #endif 207 #endif >>> CID 1479713: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "type" to "show_ip_nht_magic", which dereferences it. 208 return show_ip_nht_magic(self, vty, argc, argv, ipv4, ipv6, type, addr, addr_str, vrf_name, vrf_all); 209 } 210 211 /* show_route => "show < ip$ipv4 <fib$fib|route> [vrf <NAME$vrf_name|all$vrf_all>] [{ tag (1-4294967295) |A.B.C.D/M$prefix longer-prefixes |supernets-only$supernets_only }] [< RR_IP_REDIST_STR_ZEBR$type_str |ospf$type_str (1-65535)$ospf_instance_id >] |ipv6$ipv6 <fib$fib|route> [vrf <NAME$vrf_name|all$vrf_all>] [{ tag (1-4294967295) |X:X::X:X/M$prefix longer-prefixes }] [RR_IP6_REDIST_STR_ZEBR$type_str] > [json$json]" */ 212 DEFUN_CMD_FUNC_DECL(show_route) 213 #define funcdecl_show_route static int show_route_magic(\ ** CID 1479712: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1479712: Memory - corruptions (OVERRUN) /isisd/fabricd.c: 375 in fabricd_calculate_fabric_tier() 369 370 if (!second_furthest_t0) { 371 zlog_info("OpenFabric: Could not find two T0 routers"); 372 return ISIS_TIER_UNDEFINED; 373 } 374 >>> CID 1479712: Memory - corruptions (OVERRUN) >>> Overrunning array "furthest_t0->N.id" of 7 bytes by passing it to a function which accesses it at byte offset 7. 375 zlog_info("OpenFabric: Found %s as furthest t0 from local system, dist == %" 376 PRIu32, rawlspid_print(furthest_t0->N.id), furthest_t0->d_N); 377 378 struct isis_spftree *remote_tree = 379 isis_run_hopcount_spf(area, furthest_t0->N.id, NULL); 380 ** CID 1479711: Error handling issues (CHECKED_RETURN) /pimd/pim_zebra.c: 1012 in igmp_source_forward_start() ________________________________________________________________________________________________________ *** CID 1479711: Error handling issues (CHECKED_RETURN) /pimd/pim_zebra.c: 1012 in igmp_source_forward_start() 1006 grp.u.prefix4 = sg.grp; 1007 1008 up = pim_upstream_find(pim, &sg); 1009 if (up) { 1010 memcpy(&nexthop, &up->rpf.source_nexthop, 1011 sizeof(struct pim_nexthop)); >>> CID 1479711: Error handling issues (CHECKED_RETURN) >>> Calling "pim_ecmp_nexthop_lookup" without checking return value (as is done elsewhere 8 out of 9 times). 1012 pim_ecmp_nexthop_lookup(pim, &nexthop, &src, 1013 &grp, 0); 1014 if (nexthop.interface) 1015 input_iface_vif_index = 1016 pim_if_find_vifindex_by_ifindex( 1017 pim, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Data Structure changes
by Donald Sharp 01 May '19

01 May '19

All - We recently added some new data structure implementations in lib, thanks to David Lamparter for his work here. The new documentation is here: http://docs.frrouting.org/projects/dev-guide/en/latest/lists.html And we have some commits that convert current usages to the new data structures: 7c198e4e1 lib: use DECLARE_SKIPLIST for timers instead of pqueue c284542b6 lib: use DECLARE_LIST for thread_list 679b1649c lib: use DECLARE_HASH for qobj hash In addition we have a PR for switching some data structures around in zebra: https://github.com/FRRouting/frr/pull/4236 Which shows some tremendous memory savings, just by converting over. While it may not be feasible to convert the code base quickly I would like to ensure that the expectation is that new development uses these new data structures. I will be asking the question of 'why are you not using the new data structures' in PR's that introduce new work going forward. thanks! donald

1 0