November 2020 - dev - lists.frrouting.org

CLI configuration format for the new SR-TE daemon with PCEP
by Sebastien Merle 30 Nov '20

30 Nov '20

Hi, I am writing on behalf of the developers behind the pull request for the new experimental daemon pathd. It adds segment routing traffic engeneering policies and an optional dynamic module for PCEP support to FRR. During the review, the question of the CLI configuration format was discussed, and we wanted to submit the last proposal to be sure the community was agreeing with it. Here is a simple but artificially exhaustive example of pathd configuration with the pcep module enabled: ``` segment-routing traffic-eng segment-list SL1 index 10 mpls label 1111 nai node 1.1.1.1 index 20 mpls label 2222 nai node 2.2.2.2 ! policy color 4 endpoint 10.10.10.4 name r4 binding-sid 104 candidate-path preference 100 name exp41 explicit segment-list SL1 candidate-path preference 200 name dyn41 dynamic bandwidth 1234 affinity exclude-any 0x01 pcep metric bound abc 16 pcep required metric bnc 123 pcep objective-function mcp msn mll mrup ! ! pcep config-group COMMON source-address ip 10.10.10.10 timer keep-alive 50 ! config-group CONF1 config-group COMMON tcp-md5-auth SECRET timer keep-alive 30 ! pce-peer PCE1 config-group COMMON address ip 10.10.10.1 pce-initiated ! pce-peer PCE2 config-group CONF1 address ip 10.10.10.2 msd 32 sr-draft07 ! pcc peer PCE1 precedence 10 peer PCE2 precedence 20 ! ! ! ! ``` Some explanation about why the configuration format was chosen: * In the candidate path, the metric and objective function are prefixed with `pcep` because we didn't think this was generic enough for non-pcep candidate path. * `config-group` is used to create a hierarchy of pcc/pce configuration so the common configuration does not have to be duplicated in every `pce-peer`. * The `pce-peer` are not defined under `pcc` for two reasons: 1. This works around using vtysh without transaction, where we can't be sure when we have all the configuration to start the pcc. 2. The idea is to later support per-prefix selection of the PCE: ``` pcc peer PCE1 precedence 10 group GROUP1 priority 10 prefix 4.5.3.0/24 peer PCE2 precedence 10 peer PCE1 precedence 20 ! group GROUP2 priority 20 prefix 4.5.3.0/24 peer PCE3 precedence 10 peer PCE1 precedence 20 ! ! ``` The list of possible commands that can be specified under `config-group` and `pce-peer` is: * `sr-draft07` (Enable backward compatibility with segment routing draft07 PCEs) * `pce-initiated` (Enable PCE-intitated LSP support) * `tcp-md5-auth WORD` * `address <ip A.B.C.D | ipv6 X:X::X:X> [port (1024-65535)]` * `source-address [ip A.B.C.D | ipv6 X:X::X:X] [port (1024-65535)]` * `config-group WORD` * `timer [keep-alive (1-63)] [min-peer-keep-alive (1-255)] [max-peer-keep-alive (1-255)] ...` * `msd (1-32)` Link to the pull request: https://github.com/FRRouting/frr/pull/7351 Thank you very much for your feedback. Regards, Sebastien Merle.

3 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 Nov '20

19 Nov '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1499606: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2595 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_modify() ________________________________________________________________________________________________________ *** CID 1499606: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2595 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_modify() 2589 break; 2590 case NB_EV_APPLY: 2591 vrf = nb_running_get_entry(args->dnode, NULL, true); 2592 pim = vrf->info; 2593 plist = yang_dnode_get_string(args->dnode, NULL); 2594 yang_dnode_get_ip(&rp_addr, args->dnode, "../rp-address"); >>> CID 1499606: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix" without checking return value (as is done elsewhere 58 out of 61 times). 2595 str2prefix("224.0.0.0/4", &group); 2596 return pim_rp_cmd_worker(pim, rp_addr.ip._v4_addr, group, 2597 plist, args->errmsg, args->errmsg_len); 2598 } 2599 2600 return NB_OK; ** CID 1499605: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2500 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_destroy() ________________________________________________________________________________________________________ *** CID 1499605: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2500 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_destroy() 2494 args->errmsg_len); 2495 } 2496 2497 else if (yang_dnode_get(args->dnode, "./prefix-list")) { 2498 plist = yang_dnode_get_string(args->dnode, 2499 "./prefix-list"); >>> CID 1499605: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix" without checking return value (as is done elsewhere 58 out of 61 times). 2500 str2prefix("224.0.0.0/4", &group); 2501 result = pim_no_rp_cmd_worker(pim, rp_addr.ip._v4_addr, 2502 group, plist, 2503 args->errmsg, 2504 args->errmsg_len); 2505 } ** CID 1499604: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2622 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_destroy() ________________________________________________________________________________________________________ *** CID 1499604: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2622 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_destroy() 2616 break; 2617 case NB_EV_APPLY: 2618 vrf = nb_running_get_entry(args->dnode, NULL, true); 2619 pim = vrf->info; 2620 yang_dnode_get_ip(&rp_addr, args->dnode, "../rp-address"); 2621 plist = yang_dnode_get_string(args->dnode, NULL); >>> CID 1499604: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix" without checking return value (as is done elsewhere 58 out of 61 times). 2622 str2prefix("224.0.0.0/4", &group); 2623 return pim_no_rp_cmd_worker(pim, rp_addr.ip._v4_addr, group, 2624 plist, args->errmsg, 2625 args->errmsg_len); 2626 break; 2627 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 16 Nov '20

16 Nov '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1499551: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_flowspec_vty.c: 304 in route_vty_out_flowspec() ________________________________________________________________________________________________________ *** CID 1499551: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_flowspec_vty.c: 304 in route_vty_out_flowspec() 298 else if (json_paths && display == NLRI_STRING_FORMAT_JSON) 299 json_object_array_add(json_paths, json_nlri_path); 300 if (!path) 301 return; 302 303 ipv6_ecomm = bgp_attr_get_ipv6_ecommunity(path->attr); >>> CID 1499551: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "path->attr" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 304 if (path->attr && (path->attr->ecommunity || ipv6_ecomm)) { 305 /* Print attribute */ 306 attr = path->attr; 307 if (attr->ecommunity) 308 s1 = ecommunity_ecom2str(attr->ecommunity, 309 ECOMMUNITY_FORMAT_ROUTE_MAP, 0); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Announcing the 7.5 release of FRR
by Donald Sharp 16 Nov '20

16 Nov '20

All - I'd like to announce the 7.5 release of FRR! Debian Packaging - https://deb.frrouting.org/ Snap Packaging - https://snapcraft.io/frr RPM Packaging - https://rpm.frrouting.org/ Github Release - FreeBSd Packaging - Are built and available in FreeBSD packages/port BFD Profile support Minimum ttl support BGP rpki VRF support GR fixes Add wide option to display of routes Add `maximum-prefix <num> force` Add `bestpath-routes` to neighbor command Add `bgp shutdown message MSG...` command Add v6 Flowspec support Add `neighbor <neigh> shutdown rtt` command Allow update-delay to be applied globaly EVPN Beginning of MultiHoming Support ISIS Segment Routing Support VRF Support Guard against adj timer display overflow Add support for Anycast-SIDs OSPF Segment Routing support for ECMP Various LSA fixes Prevent crash if transferring config amongst instances PBR Adding json support to commands DSCP/ECN based PBR Matching PIM Add more json support to commands Fix missing mesh-group commands MSDP SA forwarding Clear (s,g,rpt) ifchannel on (*, G) prune received Fix igmp querier election and IP address mapping Crash fix when RP is removed STATIC Northbound Support YANG Filter and route-map Support OSPF model definition BGP model definition VTYSH Fix build-time errors for some --enable flags Speed up output of configuration across daemons ZEBRA nexthop group support for FPM northbound support for rib model Backup nexthop support netlink batching support Allow upper level protocols to request ARP Add json output for zebra ES, ES-EVI and access vlan dumps Upgrade to using libyang1.0.184 RPM Moved RPKI to subpackage Added SNMP subpackage Centos 6 and Debian Jessie have been deprecated As always there are too many bugfixes to list individually. This release compromises just over 1k of commits by the community, with contributors from 70 people. thanks! Donald

1 1

Northbound weekly meeting
by Lou Berger 13 Nov '20

13 Nov '20

1 0

Northbound weekly meeting
by Lou Berger 12 Nov '20

12 Nov '20

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 12 Nov '20

12 Nov '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1496950: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1496950: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_route.c: 4514 in bgp_soft_reconfig_table() 4508 if (pi) 4509 memcpy(&evpn, &pi->attr->evpn_overlay, 4510 sizeof(evpn)); 4511 else 4512 memset(&evpn, 0, sizeof(evpn)); 4513 >>> CID 1496950: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "label_pnt" to "bgp_update", which dereferences it. 4514 ret = bgp_update(peer, bgp_dest_get_prefix(dest), 4515 ain->addpath_rx_id, ain->attr, afi, 4516 safi, ZEBRA_ROUTE_BGP, 4517 BGP_ROUTE_NORMAL, prd, label_pnt, 4518 num_labels, 1, &evpn); 4519 ** CID 1496947: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1496947: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_rpki.c: 445 in revalidate_bgp_node() 439 uint32_t num_labels = 0; 440 441 if (path && path->extra) { 442 label = path->extra->label; 443 num_labels = path->extra->num_labels; 444 } >>> CID 1496947: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "label" to "bgp_update", which dereferences it. 445 ret = bgp_update(ain->peer, bgp_dest_get_prefix(bgp_dest), 446 ain->addpath_rx_id, ain->attr, afi, safi, 447 ZEBRA_ROUTE_BGP, BGP_ROUTE_NORMAL, NULL, label, 448 num_labels, 1, NULL); 449 450 if (ret < 0) ** CID 1496946: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1496946: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_mac.c: 213 in bgp_process_mac_rescan_table() 207 peer->host, pfx_buf); 208 } 209 continue; 210 } 211 212 memcpy(&evpn, &pi->attr->evpn_overlay, sizeof(evpn)); >>> CID 1496946: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "label_pnt" to "bgp_update", which dereferences it. 213 int32_t ret = bgp_update(peer, p, 214 pi->addpath_rx_id, 215 pi->attr, AFI_L2VPN, SAFI_EVPN, 216 ZEBRA_ROUTE_BGP, 217 BGP_ROUTE_NORMAL, &prd, 218 label_pnt, num_labels, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Knowing requirements for contrbutions
by jatin jain 12 Nov '20

12 Nov '20

*To* *FRRouting* *Sir, I am a young programmer. I found your organisation from GSOC-2020 archives. I want to contribute to your open source organisation, so please tell me what are requirements (like language, algorithms) to write code for your organisation* *Thanking You* *JATIN JAIN*

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 Nov '20

05 Nov '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1499389: Null pointer dereferences (NULL_RETURNS) /bgpd/bgp_nb_config.c: 6280 in bgp_peer_group_peer_lookup() ________________________________________________________________________________________________________ *** CID 1499389: Null pointer dereferences (NULL_RETURNS) /bgpd/bgp_nb_config.c: 6280 in bgp_peer_group_peer_lookup() 6274 const char *peer_str) 6275 { 6276 struct peer *peer = NULL; 6277 struct peer_group *group = NULL; 6278 6279 group = peer_group_lookup(bgp, peer_str); >>> CID 1499389: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "group", which is known to be "NULL". 6280 return peer = group->conf; 6281 } 6282 6283 /* 6284 * XPath: 6285 * /frr-routing:routing/control-plane-protocols/control-plane-protocol/frr-bgp:bgp/peer-groups/peer-group ** CID 1499388: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1499388: Null pointer dereferences (NULL_RETURNS) /bgpd/bgp_nb_config.c: 5201 in bgp_neighbors_unnumbered_neighbor_neighbor_remote_as_remote_as_type_destroy() 5195 bgp = nb_running_get_entry(args->dnode, NULL, true); 5196 peer_str = 5197 yang_dnode_get_string(args->dnode, "../../interface"); 5198 peer = peer_lookup_by_conf_if(bgp, peer_str); 5199 5200 /* remote-as set to 0 and as_type to unspecified */ >>> CID 1499388: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "peer" when calling "peer_as_change". 5201 peer_as_change(peer, 0, AS_UNSPECIFIED); 5202 5203 break; 5204 } 5205 5206 return NB_OK; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Northbound Weekly meeting
by Santosh P K 02 Nov '20

02 Nov '20

All, Adjusted day light saving and this is the new slot we are going to use for northbound weekly meeting. Thanks Santosh P K

1 0