April 2020 - dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 02 Apr '20

02 Apr '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1492482: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1492482: Memory - corruptions (OVERRUN) /zebra/zebra_rnh.c: 1048 in send_client() 1042 stream_putl(s, re->metric); 1043 num = 0; 1044 nump = stream_get_endp(s); 1045 stream_putc(s, 0); 1046 for (ALL_NEXTHOPS(re->nhe->nhg, nh)) 1047 if (rnh_nexthop_valid(re, nh)) { >>> CID 1492482: Memory - corruptions (OVERRUN) >>> Overrunning struct type zapi_nexthop of 112 bytes by passing it to a function which accesses it at byte offset 115. 1048 zapi_nexthop_from_nexthop(&znh, nh); 1049 zapi_nexthop_encode(s, &znh, 0 /* flags */); 1050 num++; 1051 } 1052 stream_putc_at(s, nump, num); 1053 } else { ** CID 1492481: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vxlan.c: 10262 in zebra_evpn_pim_cfg_clean_up() ________________________________________________________________________________________________________ *** CID 1492481: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vxlan.c: 10262 in zebra_evpn_pim_cfg_clean_up() 10256 } 10257 10258 static int zebra_evpn_pim_cfg_clean_up(struct zserv *client) 10259 { 10260 struct zebra_vrf *zvrf = zebra_vrf_get_evpn(); 10261 >>> CID 1492481: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "zvrf", which is known to be "NULL". 10262 if (CHECK_FLAG(zvrf->flags, ZEBRA_PIM_SEND_VXLAN_SG)) { 10263 if (IS_ZEBRA_DEBUG_VXLAN) 10264 zlog_debug("VxLAN SG updates to PIM, stop"); 10265 UNSET_FLAG(zvrf->flags, ZEBRA_PIM_SEND_VXLAN_SG); 10266 } 10267 ** CID 1492480: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1492480: Memory - corruptions (OVERRUN) /pimd/pim_nht.c: 737 in pim_parse_nexthop_update() 731 struct zapi_route nhr; 732 733 if (!vrf) 734 return 0; 735 pim = vrf->info; 736 >>> CID 1492480: Memory - corruptions (OVERRUN) >>> Overrunning struct type zapi_route of 14456 bytes by passing it to a function which accesses it at byte offset 29815. 737 if (!zapi_nexthop_update_decode(zclient->ibuf, &nhr)) { 738 if (PIM_DEBUG_PIM_NHT) 739 zlog_debug( 740 "%s: Decode of nexthop update from zebra failed", 741 __func__); 742 return 0; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0

RTT
by Sofia Salgueiro 02 Apr '20

02 Apr '20

Good afternoon, I've been using CORE with FRRouting and I've noticed that the PING rtt between two directly connected router devices is approximately 80 us, even if I change the bandwidth of the links. I've also noticed that this value seems to increase with the number of hops, eg. between 2 routers with 4 links the value doubles to approximately 160 us. So, I was wondering if maybe you could give me some insight on how the PING is emulated and, more specifically, why the rtt has this value? Best regards, Sofia Salgueiro

3 2

Router Simulation using Dockers
by Sofia Salgueiro 02 Apr '20

02 Apr '20

Hello, I'm currently working on my Master Thesis in Electrical and Computer Engineering at Instituto Superior Técnico, Lisbon, and was looking to use FRRouting to simulate routers using dockers. Is this possible and, if so, would you mind providing me with some information on this? Best regards, Sofia Salgueiro

5 5

Telco meeting 01/04 minutes
by olivier.dugeon＠orange.com 01 Apr '20

01 Apr '20

Dear all, Minutes are available in the wiki as usual, but pay attention as I created a new dedicated page for that. You'll find them from the Telco page https://github.com/FRRouting/frr/wiki/FRR-Telco-SP-projects or directly from the page https://github.com/FRRouting/frr/wiki/Telco-Meeting-Minutes During the call we (thanks Lou) start drawing a new version of Zebra threading model to handle smoothly Link State redistribution between daemons. Donald, Quentin, could you have a look and give us your feedback? I also change the order of the minutes (from latest to oldest one). As usual, don't hesitate to correct them if I miss something or made a mistake. Regards Olivier -- Orange logo <http://www.orange.com> Olivier Dugeon Orange Expert, Future Networks Open Source Referent Orange/IMT/OLN/WTC/IEE/iTeQ fixe : +33 2 96 07 28 80 mobile : +33 6 82 90 37 85 olivier.dugeon(a)orange.com <mailto:olivier.dugeon@orange.com> _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

1 0