July 2020 - dev - lists.frrouting.org

Northbound meeting today is canceled
by Santosh P K 31 Jul '20

31 Jul '20

Hello All, I have a conflict today and hence will not be able to run northbound meeting today. Today’s meeting will be canceled. Thanks Santosh P K

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 28 Jul '20

28 Jul '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1496495: Error handling issues (CHECKED_RETURN) /zebra/zebra_dplane.c: 2539 in dplane_route_notif_update() ________________________________________________________________________________________________________ *** CID 1496495: Error handling issues (CHECKED_RETURN) /zebra/zebra_dplane.c: 2539 in dplane_route_notif_update() 2533 } 2534 2535 /* Capture info about the source of the notification, in 'ctx' */ 2536 dplane_ctx_set_notif_provider(new_ctx, 2537 dplane_ctx_get_notif_provider(ctx)); 2538 >>> CID 1496495: Error handling issues (CHECKED_RETURN) >>> Calling "dplane_update_enqueue" without checking return value (as is done elsewhere 9 out of 10 times). 2539 dplane_update_enqueue(new_ctx); 2540 2541 ret = ZEBRA_DPLANE_REQUEST_QUEUED; 2542 2543 done: 2544 return ret; ** CID 1496494: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_nb_config.c: 1221 in lib_vrf_zebra_l3vni_id_modify() ________________________________________________________________________________________________________ *** CID 1496494: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_nb_config.c: 1221 in lib_vrf_zebra_l3vni_id_modify() 1215 * if zebra vrf already mapped to different vni id. 1216 */ 1217 pn_dnode = yang_dnode_get_parent(args->dnode, "vrf"); 1218 if (pn_dnode) { 1219 vrfname = yang_dnode_get_string(pn_dnode, "./name"); 1220 vrf = vrf_lookup_by_name(vrfname); >>> CID 1496494: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "vrf", which is known to be "NULL". 1221 zvrf = zebra_vrf_lookup_by_id(vrf->vrf_id); 1222 if (zvrf->l3vni && zvrf->l3vni != vni) { 1223 zlog_debug( 1224 "vni %u cannot be configured as vni %u is already configured under the vrf", 1225 vni, zvrf->l3vni); 1226 return NB_ERR_VALIDATION; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Telco meeting status
by olivier.dugeon＠orange.com 24 Jul '20

24 Jul '20

Dear all, Following the last Telco meeting, I updated the Wiki page to reflect our new usage of GitHub Project management facilities: https://github.com/FRRouting/frr/wiki/FRR-Telco-SP-projects Regarding BGP-LS, there is already a #Telco channel on Slack with very few discussions. So, I propose to use this #Telco channel to discuss on-going development around BGP-LS. Cristain (in Cc:) started its internship within Orange one month ago. He'll join Slack soon. Cristian started to backport our old BGP-LS code to FRR. Please, interact with him through Slack to discuss how to organise the work and progress. As mentioned, I'll start 3 weeks vacations this evening. So, fill free to maintain or cancel the next Telco meeting in 2 weeks. Allistair will manage it. Finally, I'll push a preview of Link State PR as WIP. Look at the doxygen doc within link_state.h for details and usage. Enjoy your summer. Regards Olivier

1 0

BGP Link State code
by olivier.dugeon＠orange.com 17 Jul '20

17 Jul '20

Dear all, Many of you are interested by our very old code about BGP Link State. So, I decided to publish it, but ***AS IS*** more as a proof of concept rather than a running code. It is based on a old version of Quagga. I don't know if it compiles, if it runs ... As the code was unfortunately not versioned, I try to patch what seems the Quagga version from which the code was written to produce the git commit. But, I have not the time to check if the result compiles and if it is running. *Please, d**on't ask me for that*. As an old code, it is using old style. So, only new files are following FRR style. The repo is here: https://github.com/Orange-OpenSource/Quagga-TE/tree/BGP-LS The implementation is made of new files: - BGP-LS TLV definition: bgpd/bgp_ls.h - New Link State NLRI: bgpd/bgp_bgpls_nlri.c - Parser/Serializer: bgpd/bgp_ls_bgpls.c - BGP-LS Database: bgpd/bgp_lsdb.[c,h] - BGP API for OSPF-API: bgpd/bgp_api.[c,h], bgpd/bgp_ls_ospf.h - BGP Link State transcodage: bgpd/bgp_transcode.c - BGP to OSPF-API connection: bgpd/bgp_zbusclient.[c,h] At least the NLRI, TLV definition, parser / serializer and LSDB could be re-use easily. Of course all interaction with OSPF through OSPF API must be replaced by the new ZAPI Opaque message. And following files have been patched for integration: - bgpd/bgp_advertise.c, bgpd/bgp_aspath.c, bgpd/bgp_attr.|c,h], bgpd/bgp_btoa.c, bgpd/bgp_clist.c, bgpd/bgp_community.[c,h], bgpd/bgp_dump.c, bgpd/bgp_fsm.c, bgpd/bgp_main.c, bgpd/bgp_mplsvpn.c, bgpd/bgp_nexthop.c, bgpd/bgp_open.c, bgpd/bgp_packet.c, bgpd/bgp_route.c, bgpd/bgp_routemap.c, bgpd/bgp_table.c, bgpd/bgp_vty.c, bgpd/bgp_zebra.c, bgpd/bgpd.c, bgpd/bgpd.h Where takes place the huge part of difficulties in order to merge them into FRR. King regards Olivier _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 16 Jul '20

16 Jul '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1496376: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_rib.c: 1948 in rib_count_installed_nh() ________________________________________________________________________________________________________ *** CID 1496376: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_rib.c: 1948 in rib_count_installed_nh() 1942 } else { 1943 if (CHECK_FLAG(nexthop->flags, NEXTHOP_FLAG_ACTIVE)) 1944 count++; 1945 } 1946 } 1947 >>> CID 1496376: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "rib_get_fib_backup_nhg(re)", which is known to be "NULL". 1948 for (ALL_NEXTHOPS_PTR(rib_get_fib_backup_nhg(re), nexthop)) { 1949 if (CHECK_FLAG(nexthop->flags, NEXTHOP_FLAG_FIB)) 1950 count++; 1951 } 1952 1953 return count; ** CID 1496375: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1496375: Memory - corruptions (OVERRUN) /zebra/zebra_mpls.c: 3408 in mpls_lsp_uninstall() 3402 nhlfe = nhlfe_find(&lsp->nhlfe_list, type, gtype, gate, 3403 ifindex); 3404 if (!nhlfe) 3405 return 0; 3406 3407 if (IS_ZEBRA_DEBUG_MPLS) { >>> CID 1496375: Memory - corruptions (OVERRUN) >>> Overrunning array "buf" of 76 bytes by passing it to a function which accesses it at byte offset 8191 using argument "8192". 3408 nhlfe2str(nhlfe, buf, BUFSIZ); 3409 zlog_debug("Del LSP in-label %u type %d nexthop %s flags 0x%x", 3410 in_label, type, buf, nhlfe->flags); 3411 } 3412 3413 if (CHECK_FLAG(lsp->flags, LSP_FLAG_INSTALLED) || ** CID 1495424: Error handling issues (CHECKED_RETURN) /zebra/zebra_rnh.c: 1190 in send_client() ________________________________________________________________________________________________________ *** CID 1495424: Error handling issues (CHECKED_RETURN) /zebra/zebra_rnh.c: 1190 in send_client() 1184 nhg = NULL; 1185 1186 if (nhg) { 1187 for (ALL_NEXTHOPS_PTR(nhg, nh)) 1188 if (rnh_nexthop_valid(re, nh)) { 1189 zapi_nexthop_from_nexthop(&znh, nh); >>> CID 1495424: Error handling issues (CHECKED_RETURN) >>> Calling "zapi_nexthop_encode" without checking return value (as is done elsewhere 5 out of 6 times). 1190 zapi_nexthop_encode(s, &znh, 1191 0 /* flags */); 1192 num++; 1193 } 1194 } 1195 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Reg: Questions about FRR APIs
by Thilak T 14 Jul '20

14 Jul '20

Hello, community, I am reasonably new to the FRR space and trying to find resources to manage the FRR instance via code. Programmatically access protocol states ( for example, show ip bgp summary) or apply configuration like changing the route-map applied to neighbors, etc. I went through the FRR docs, and I see the VTYSH session touching upon this topic in the context of the shell. How do I get started with an API ( golang, python ) to do what we can do via the vtysh? Thank you in advance for pointing me in the right direction Thanks, Thilak

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 10 Jul '20

10 Jul '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1496314: Null pointer dereferences (REVERSE_INULL) /isisd/isis_circuit.c: 724 in isis_circuit_down() ________________________________________________________________________________________________________ *** CID 1496314: Null pointer dereferences (REVERSE_INULL) /isisd/isis_circuit.c: 724 in isis_circuit_down() 718 #ifndef FABRICD 719 /* send northbound notification */ 720 isis_notif_if_state_change(circuit, true); 721 #endif /* ifndef FABRICD */ 722 723 /* log adjacency changes if configured to do so */ >>> CID 1496314: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "circuit->area" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 724 if (circuit->area && circuit->area->log_adj_changes) { 725 struct isis_adjacency *adj = NULL; 726 if (circuit->circ_type == CIRCUIT_T_P2P) { 727 adj = circuit->u.p2p.neighbor; 728 if (adj) 729 isis_log_adj_change( ** CID 1496313: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1496313: Null pointer dereferences (NULL_RETURNS) /bgpd/bgp_bmp.c: 959 in bmp_wrsync() 953 */ 954 if (!bmp->syncrdpos) 955 bmp->syncrdpos = bgp_table_top(table); 956 957 /* look for a valid mid-layer table */ 958 do { >>> CID 1496313: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "bmp->syncrdpos" when calling "bgp_dest_get_bgp_table_info". 959 table = bgp_dest_get_bgp_table_info(bmp->syncrdpos); 960 if (table) { 961 break; 962 } 963 bmp->syncrdpos = bgp_route_next(bmp->syncrdpos); 964 } while (bmp->syncrdpos); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0

Re: [dev] Northbound discussion
by Santosh P K 02 Jul '20

02 Jul '20

Today’s meeting is cancelled as there is not much agenda. Please request for review as all PRs are updated and ready for review. Thanks Santosh P K

1 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 01 Jul '20

01 Jul '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1496146: Control flow issues (UNREACHABLE) /bgpd/bgp_main.c: 142 in sighup() ________________________________________________________________________________________________________ *** CID 1496146: Control flow issues (UNREACHABLE) /bgpd/bgp_main.c: 142 in sighup() 136 * that is not setup properly again in bgp_rest. 137 * I see no easy way to do this nor do I see that 138 * this is a desirable way to reload config 139 * given the yang work. 140 */ 141 /* Terminate all thread. */ >>> CID 1496146: Control flow issues (UNREACHABLE) >>> This code cannot be reached: "bgp_terminate();". 142 bgp_terminate(); 143 bgp_reset(); 144 zlog_info("bgpd restarting!"); 145 146 /* Reload config file. */ 147 vty_read_config(NULL, bgpd_di.config_file, config_default); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0