September 2020 - dev - lists.frrouting.org

FRR 2020 Annual TSC Election - Call for TSC Nominations...
by Alistair Woodman 06 Oct '20

06 Oct '20

All, This email kicks off the FRR annual TSC election process. Please unicast me your nominations for TSC candidates. Process: 1) Present TSC members are automatically re-nominated. 2) I will unicast each candidate to confirm that they are actually willing to serve. 3) Voting will start in 2 weeks 4) Voting will close in 3 weeks /a

1 1

Regarding representation as FRR maintainer
by Abhijit Chaudhary 29 Sep '20

29 Sep '20

Dear All, I want to bring to your consideration that Niral has a long term commitment to contribute to FRRouting. Our team has been contributing to the FRR community, and I can assure you that our contribution would increase over time. We ensure to mention that our NOS uses FRRouting in all our external presentations. As the FRR Maintainer election would happen next month, I would appreciate it if the community can consider a representation from Niral in the FRR Maintainer list. I had a discussion with Kaushik and he is keen to take up the responsibility and dedicate time for FRR maintenance. Kindly let us know your thoughts regarding it. Best, - Abhijit +91-9886179612 <http://www.niralnetworks.com/> Building Curated, Open, Disaggregated Networking for 5G and Beyond According to DSCI report, A NASSCOM Initiative, Niral Networks is a key 5G technology player from India <https://www.nasscom.in/sites/default/files/TechSagar_Wireless_and_Networkin…>

2 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 22 Sep '20

22 Sep '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1497109: Error handling issues (CHECKED_RETURN) /lib/northbound.c: 125 in nb_node_new_cb() ________________________________________________________________________________________________________ *** CID 1497109: Error handling issues (CHECKED_RETURN) /lib/northbound.c: 125 in nb_node_new_cb() 119 nb_node->parent_list = sparent_list->priv; 120 121 /* Set flags. */ 122 if (CHECK_FLAG(snode->nodetype, LYS_CONTAINER | LYS_LIST)) { 123 bool config_only = true; 124 >>> CID 1497109: Error handling issues (CHECKED_RETURN) >>> Calling "yang_snodes_iterate_subtree" without checking return value (as is done elsewhere 4 out of 5 times). 125 yang_snodes_iterate_subtree(snode, NULL, 126 nb_node_check_config_only, 0, 127 &config_only); 128 if (config_only) 129 SET_FLAG(nb_node->flags, F_NB_NODE_CONFIG_ONLY); 130 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 Sep '20

18 Sep '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1465475: (RESOURCE_LEAK) /zebra/zebra_netns_id.c: 190 in zebra_ns_id_get() /zebra/zebra_netns_id.c: 227 in zebra_ns_id_get() ________________________________________________________________________________________________________ *** CID 1465475: (RESOURCE_LEAK) /zebra/zebra_netns_id.c: 190 in zebra_ns_id_get() 184 sock = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE); 185 if (sock < 0) { 186 flog_err_sys(EC_LIB_SOCKET, "netlink( %u) socket() error: %s", 187 sock, safe_strerror(errno)); 188 if (fd_param == -1) 189 close(fd); >>> CID 1465475: (RESOURCE_LEAK) >>> Handle variable "fd" going out of scope leaks the handle. 190 return NS_UNKNOWN; 191 } 192 memset(&snl, 0, sizeof(snl)); 193 snl.nl_family = AF_NETLINK; 194 snl.nl_groups = RTNLGRP_NSID; 195 snl.nl_pid = 0; /* AUTO PID */ /zebra/zebra_netns_id.c: 227 in zebra_ns_id_get() 221 222 ret = send_receive(sock, nlh, seq, buf); 223 if (ret < 0) { 224 close(sock); 225 if (fd_param == -1) 226 close(fd); >>> CID 1465475: (RESOURCE_LEAK) >>> Handle variable "fd" going out of scope leaks the handle. 227 return NS_UNKNOWN; 228 } 229 nlh = (struct nlmsghdr *)buf; 230 231 /* message to analyse : NEWNSID response */ 232 ret = 0; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Regarding FRR Pim Protocol Function
by Pankaj Garbyal 18 Sep '20

18 Sep '20

Hello Sir/Madam, I am using FRRRouting Release 5.1 for PIM Protocol support in my Switch. But I find that PIM Protocol is not acknowledging the multicast packets coming towards it. When i compared the same with FRR installed in Linux PC, i found that a new interface named "pimreg" is enabled by FRR but the same is not happening in FRR of my switch. Kindly provide me help to get the pimreg interface option in my switch through FRR. also provide some information on the role of "pimreg" to run the PIM Protocol at FRR. Attached here my quagga build file for your reference. Thank you in advance for your support. Regards, Pankaj Garbyal Mobile: +91-9873987203

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 Sep '20

17 Sep '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 6 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1497010: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1497010: Null pointer dereferences (NULL_RETURNS) /isisd/isis_nb_config.c: 2853 in lib_interface_isis_mpls_holddown_modify() 2847 break; 2848 case NB_EV_APPLY: 2849 circuit = nb_running_get_entry(args->dnode, NULL, true); 2850 holddown = yang_dnode_get_uint16(args->dnode, NULL); 2851 2852 if (circuit->ldp_sync_info == NULL) >>> CID 1497010: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "isis" when calling "isis_ldp_sync_if_init". 2853 isis_ldp_sync_if_init(circuit, isis); 2854 ldp_sync_info = circuit->ldp_sync_info; 2855 2856 SET_FLAG(ldp_sync_info->flags, LDP_SYNC_FLAG_HOLDDOWN); 2857 ldp_sync_info->holddown = holddown; 2858 break; ** CID 1497009: (NULL_RETURNS) /isisd/isis_nb_config.c: 1921 in isis_instance_mpls_ldp_sync_holddown_modify() /isisd/isis_nb_config.c: 1924 in isis_instance_mpls_ldp_sync_holddown_modify() ________________________________________________________________________________________________________ *** CID 1497009: (NULL_RETURNS) /isisd/isis_nb_config.c: 1921 in isis_instance_mpls_ldp_sync_holddown_modify() 1915 case NB_EV_ABORT: 1916 break; 1917 case NB_EV_APPLY: 1918 holddown = yang_dnode_get_uint16(args->dnode, NULL); 1919 1920 if (holddown == LDP_IGP_SYNC_HOLDDOWN_DEFAULT) >>> CID 1497009: (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 1921 UNSET_FLAG(isis->ldp_sync_cmd.flags, 1922 LDP_SYNC_FLAG_HOLDDOWN); 1923 else 1924 SET_FLAG(isis->ldp_sync_cmd.flags, 1925 LDP_SYNC_FLAG_HOLDDOWN); 1926 isis->ldp_sync_cmd.holddown = holddown; /isisd/isis_nb_config.c: 1924 in isis_instance_mpls_ldp_sync_holddown_modify() 1918 holddown = yang_dnode_get_uint16(args->dnode, NULL); 1919 1920 if (holddown == LDP_IGP_SYNC_HOLDDOWN_DEFAULT) 1921 UNSET_FLAG(isis->ldp_sync_cmd.flags, 1922 LDP_SYNC_FLAG_HOLDDOWN); 1923 else >>> CID 1497009: (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 1924 SET_FLAG(isis->ldp_sync_cmd.flags, 1925 LDP_SYNC_FLAG_HOLDDOWN); 1926 isis->ldp_sync_cmd.holddown = holddown; 1927 1928 /* set holddown time on all ISIS interfaces */ 1929 FOR_ALL_INTERFACES (vrf, ifp) { ** CID 1497008: Memory - illegal accesses (USE_AFTER_FREE) /isisd/isis_nb_config.c: 90 in isis_instance_destroy() ________________________________________________________________________________________________________ *** CID 1497008: Memory - illegal accesses (USE_AFTER_FREE) /isisd/isis_nb_config.c: 90 in isis_instance_destroy() 84 if (args->event != NB_EV_APPLY) 85 return NB_OK; 86 area = nb_running_unset_entry(args->dnode); 87 isis_area_destroy(area); 88 89 /* remove ldp-sync config */ >>> CID 1497008: Memory - illegal accesses (USE_AFTER_FREE) >>> Dereferencing freed pointer "area". 90 if (area->isis->vrf_id == VRF_DEFAULT) 91 isis_ldp_sync_gbl_exit(true); 92 93 return NB_OK; 94 } 95 ** CID 1497007: Null pointer dereferences (NULL_RETURNS) /isisd/isis_nb_config.c: 2886 in lib_interface_isis_mpls_holddown_destroy() ________________________________________________________________________________________________________ *** CID 1497007: Null pointer dereferences (NULL_RETURNS) /isisd/isis_nb_config.c: 2886 in lib_interface_isis_mpls_holddown_destroy() 2880 break; 2881 case NB_EV_APPLY: 2882 circuit = nb_running_get_entry(args->dnode, NULL, true); 2883 ldp_sync_info = circuit->ldp_sync_info; 2884 UNSET_FLAG(ldp_sync_info->flags, LDP_SYNC_FLAG_HOLDDOWN); 2885 >>> CID 1497007: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 2886 if (CHECK_FLAG(isis->ldp_sync_cmd.flags, 2887 LDP_SYNC_FLAG_HOLDDOWN)) 2888 ldp_sync_info->holddown = isis->ldp_sync_cmd.holddown; 2889 else 2890 ldp_sync_info->holddown = LDP_IGP_SYNC_HOLDDOWN_DEFAULT; 2891 break; 2892 } 2893 return NB_OK; ** CID 1497006: Null pointer dereferences (NULL_RETURNS) /isisd/isis_nb_config.c: 1863 in isis_instance_mpls_ldp_sync_create() ________________________________________________________________________________________________________ *** CID 1497006: Null pointer dereferences (NULL_RETURNS) /isisd/isis_nb_config.c: 1863 in isis_instance_mpls_ldp_sync_create() 1857 case NB_EV_APPLY: 1858 /* register with opaque client to recv LDP-IGP Sync msgs */ 1859 zclient_register_opaque(zclient, LDP_IGP_SYNC_IF_STATE_UPDATE); 1860 zclient_register_opaque(zclient, LDP_IGP_SYNC_ANNOUNCE_UPDATE); 1861 zclient_register_opaque(zclient, LDP_IGP_SYNC_HELLO_UPDATE); 1862 >>> CID 1497006: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 1863 if (!CHECK_FLAG(isis->ldp_sync_cmd.flags, 1864 LDP_SYNC_FLAG_ENABLE)) { 1865 SET_FLAG(isis->ldp_sync_cmd.flags, 1866 LDP_SYNC_FLAG_ENABLE); 1867 1868 /* turn on LDP-IGP Sync on all ptop ISIS interfaces */ ** CID 1497005: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1497005: Null pointer dereferences (NULL_RETURNS) /isisd/isis_nb_config.c: 2793 in lib_interface_isis_mpls_ldp_sync_modify() 2787 break; 2788 case NB_EV_APPLY: 2789 circuit = nb_running_get_entry(args->dnode, NULL, true); 2790 ldp_sync_enable = yang_dnode_get_bool(args->dnode, NULL); 2791 2792 if (circuit->ldp_sync_info == NULL) >>> CID 1497005: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "isis" when calling "isis_ldp_sync_if_init". 2793 isis_ldp_sync_if_init(circuit, isis); 2794 ldp_sync_info = circuit->ldp_sync_info; 2795 2796 if (ldp_sync_enable) { 2797 /* enable LDP-SYNC on an interface 2798 * if ptop interface send message to LDP to get state ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 10 Sep '20

10 Sep '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1496950: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1496950: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_route.c: 4403 in bgp_soft_reconfig_table() 4397 if (pi) 4398 memcpy(&evpn, &pi->attr->evpn_overlay, 4399 sizeof(evpn)); 4400 else 4401 memset(&evpn, 0, sizeof(evpn)); 4402 >>> CID 1496950: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "label_pnt" to "bgp_update", which dereferences it. 4403 ret = bgp_update(peer, bgp_dest_get_prefix(dest), 4404 ain->addpath_rx_id, ain->attr, afi, 4405 safi, ZEBRA_ROUTE_BGP, 4406 BGP_ROUTE_NORMAL, prd, label_pnt, 4407 num_labels, 1, &evpn); 4408 ** CID 1496949: Null pointer dereferences (REVERSE_INULL) /isisd/isis_cli.c: 329 in ip6_router_isis_magic() ________________________________________________________________________________________________________ *** CID 1496949: Null pointer dereferences (REVERSE_INULL) /isisd/isis_cli.c: 329 in ip6_router_isis_magic() 323 NB_OP_MODIFY, "true"); 324 nb_cli_enqueue_change(vty, "./frr-isisd:isis/circuit-type", 325 NB_OP_MODIFY, circ_type); 326 } 327 328 /* check if the interface is a loopback and if so set it as passive */ >>> CID 1496949: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ifp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 329 if (ifp && if_is_loopback(ifp)) 330 nb_cli_enqueue_change(vty, "./frr-isisd:isis/passive", 331 NB_OP_MODIFY, "true"); 332 333 return nb_cli_apply_changes(vty, NULL); 334 } ** CID 1496948: Null pointer dereferences (REVERSE_INULL) /isisd/isis_cli.c: 238 in ip_router_isis_magic() ________________________________________________________________________________________________________ *** CID 1496948: Null pointer dereferences (REVERSE_INULL) /isisd/isis_cli.c: 238 in ip_router_isis_magic() 232 NB_OP_MODIFY, "true"); 233 nb_cli_enqueue_change(vty, "./frr-isisd:isis/circuit-type", 234 NB_OP_MODIFY, circ_type); 235 } 236 237 /* check if the interface is a loopback and if so set it as passive */ >>> CID 1496948: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ifp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 238 if (ifp && if_is_loopback(ifp)) 239 nb_cli_enqueue_change(vty, "./frr-isisd:isis/passive", 240 NB_OP_MODIFY, "true"); 241 242 return nb_cli_apply_changes(vty, NULL); 243 } ** CID 1496947: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1496947: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_rpki.c: 445 in revalidate_bgp_node() 439 uint32_t num_labels = 0; 440 441 if (path && path->extra) { 442 label = path->extra->label; 443 num_labels = path->extra->num_labels; 444 } >>> CID 1496947: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "label" to "bgp_update", which dereferences it. 445 ret = bgp_update(ain->peer, bgp_dest_get_prefix(bgp_dest), 446 ain->addpath_rx_id, ain->attr, afi, safi, 447 ZEBRA_ROUTE_BGP, BGP_ROUTE_NORMAL, NULL, label, 448 num_labels, 1, NULL); 449 450 if (ret < 0) ** CID 1496946: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1496946: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_mac.c: 213 in bgp_process_mac_rescan_table() 207 peer->host, pfx_buf); 208 } 209 continue; 210 } 211 212 memcpy(&evpn, &pi->attr->evpn_overlay, sizeof(evpn)); >>> CID 1496946: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "label_pnt" to "bgp_update", which dereferences it. 213 int32_t ret = bgp_update(peer, p, 214 pi->addpath_rx_id, 215 pi->attr, AFI_L2VPN, SAFI_EVPN, 216 ZEBRA_ROUTE_BGP, 217 BGP_ROUTE_NORMAL, &prd, 218 label_pnt, num_labels, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Using of sub interfaces for vxlan/evpn communication
by Cyril MATTIUZZI 07 Sep '20

07 Sep '20

I am trying to use vxlan with bgp / evpn: No problem with using vlan. However, as soon as several vlan comes on the same interface, nothing happens anymore, because my bridge is no longer on the interface but on the sub interface. Is it possible to perform interface trunking on FRR so that 2 vlans can be used on the same link? (example : using vlans 123, 130, 199 = ens10.123 ; ens10.130 ; ens10.199) [https://user-images.githubusercontent.com/70760763/92245330-832d3480-eec4-1…] I am available for any additional information Best regards.

1 0