February 2021 - dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Feb '21

27 Feb '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1502244: Null pointer dereferences (NULL_RETURNS) /pimd/pim_nb_config.c: 2414 in lib_interface_pim_address_family_mroute_oif_modify() ________________________________________________________________________________________________________ *** CID 1502244: Null pointer dereferences (NULL_RETURNS) /pimd/pim_nb_config.c: 2414 in lib_interface_pim_address_family_mroute_oif_modify() 2408 snprintf(args->errmsg, args->errmsg_len, 2409 "%% Enable PIM and/or IGMP on this interface first"); 2410 return NB_ERR_VALIDATION; 2411 } 2412 2413 #ifdef PIM_ENFORCE_LOOPFREE_MFC >>> CID 1502244: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "oif", which is known to be "NULL". 2414 if (iif->ifindex == oif->ifindex) { 2415 strlcpy(args->errmsg, 2416 "% IIF same as OIF and loopfree enforcement is enabled; rejecting", 2417 args->errmsg_len); 2418 return NB_ERR_VALIDATION; 2419 } ** CID 1502243: Error handling issues (CHECKED_RETURN) /bgpd/bgp_evpn_mh.c: 1704 in bgp_evpn_local_es_activate() ________________________________________________________________________________________________________ *** CID 1502243: Error handling issues (CHECKED_RETURN) /bgpd/bgp_evpn_mh.c: 1704 in bgp_evpn_local_es_activate() 1698 /* generate EAD-EVI */ 1699 bgp_evpn_local_type1_evi_route_add(bgp, es); 1700 1701 /* generate EAD-ES */ 1702 build_evpn_type1_prefix(&p, BGP_EVPN_AD_ES_ETH_TAG, &es->esi, 1703 es->originator_ip); >>> CID 1502243: Error handling issues (CHECKED_RETURN) >>> Calling "bgp_evpn_type1_route_update" without checking return value (as is done elsewhere 4 out of 5 times). 1704 bgp_evpn_type1_route_update(bgp, es, NULL, &p); 1705 } 1706 } 1707 1708 /* Process ES link oper-up by generating ES-EAD and ESR */ 1709 static void bgp_evpn_local_es_up(struct bgp *bgp, struct bgp_evpn_es *es, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Canceled: FRR Telco meeting
by olivier.dugeon＠orange.com 17 Feb '21

17 Feb '21

When: Wednesday, February 17, 2021 4:00 PM-5:00 PM. (UTC+01:00) Amsterdam, Berlin, Bern, Rome, Stockholm, Vienna Where: BlueJean https://bluejeans.com/377688464 *~*~*~*~*~*~*~*~*~* Hi all, This is the invite for the regular be-weekly Telco's meeting for 2021. NOTE: THE MEETING ID CHANGE. Please use https://bluejeans.com/377688464 for the next Telco meetings Regards Olivier _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 12 Feb '21

12 Feb '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 6 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1501748: Insecure data handling (TAINTED_SCALAR) /bgpd/bgp_mplsvpn_snmp.c: 1162 in mplsL3vpnVrfRtTable() ________________________________________________________________________________________________________ *** CID 1501748: Insecure data handling (TAINTED_SCALAR) /bgpd/bgp_mplsvpn_snmp.c: 1162 in mplsL3vpnVrfRtTable() 1156 .rtlist[BGP_VPN_POLICY_DIR_FROMVPN], 1157 ECOMMUNITY_FORMAT_ROUTE_MAP, 1158 ECOMMUNITY_ROUTE_TARGET); 1159 break; 1160 case MPLSVPNVRFRTTYPEEXPORT: 1161 case MPLSVPNVRFRTTYPEBOTH: >>> CID 1501748: Insecure data handling (TAINTED_SCALAR) >>> Using tainted variable "rt_index" as an index into an array "l3vpn_bgp->vpn_policy". 1162 rt_b = ecommunity_ecom2str( 1163 l3vpn_bgp->vpn_policy[rt_index] 1164 .rtlist[BGP_VPN_POLICY_DIR_TOVPN], 1165 ECOMMUNITY_FORMAT_ROUTE_MAP, 1166 ECOMMUNITY_ROUTE_TARGET); 1167 break; ** CID 1501747: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_mplsvpn_snmp.c: 1033 in bgpL3vpnVrfRt_lookup() ________________________________________________________________________________________________________ *** CID 1501747: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_mplsvpn_snmp.c: 1033 in bgpL3vpnVrfRt_lookup() 1027 l3vpn_bgp = bgp_lookup_by_name(vrf_name); 1028 if (l3vpn_bgp && !is_bgp_vrf_mplsvpn(l3vpn_bgp)) 1029 return NULL; 1030 if (!l3vpn_bgp) 1031 return NULL; 1032 /* check the index and type match up */ >>> CID 1501747: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> The "or" condition "*rt_index != AFI_IP || *rt_index != AFI_IP6" will always be true because "*rt_index" cannot be equal to two different values at the same time, so it must be not equal to at least one of them. 1033 if ((*rt_index != AFI_IP) || (*rt_index != AFI_IP6)) 1034 return NULL; 1035 /* do we have RT config */ 1036 if (!(l3vpn_bgp->vpn_policy[*rt_index] 1037 .rtlist[BGP_VPN_POLICY_DIR_FROMVPN] 1038 || l3vpn_bgp->vpn_policy[*rt_index] ** CID 1501746: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_mplsvpn_snmp.c: 1461 in bgpL3vpnRte_lookup() ________________________________________________________________________________________________________ *** CID 1501746: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_mplsvpn_snmp.c: 1461 in bgpL3vpnRte_lookup() 1455 if (str_len == 0) { 1456 *l3vpn_bgp = bgp_lookup_by_name_next(vrf_name); 1457 } else 1458 /* otherwise lookup the one we have */ 1459 *l3vpn_bgp = bgp_lookup_by_name(vrf_name); 1460 >>> CID 1501746: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "l3vpn_bgp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1461 if (l3vpn_bgp == NULL) 1462 return NULL; 1463 1464 pi = bgp_lookup_route_next(l3vpn_bgp, dest, &prefix, policy, 1465 &nexthop); 1466 if (pi) { ** CID 1501745: (TAINTED_SCALAR) /bgpd/bgp_mplsvpn_snmp.c: 1088 in bgpL3vpnVrfRt_lookup() /bgpd/bgp_mplsvpn_snmp.c: 1075 in bgpL3vpnVrfRt_lookup() /bgpd/bgp_mplsvpn_snmp.c: 1078 in bgpL3vpnVrfRt_lookup() ________________________________________________________________________________________________________ *** CID 1501745: (TAINTED_SCALAR) /bgpd/bgp_mplsvpn_snmp.c: 1088 in bgpL3vpnVrfRt_lookup() 1082 && !import) 1083 continue; 1084 if (*rt_type == MPLSVPNVRFRTTYPEEXPORT 1085 && !export) 1086 continue; 1087 /* ckeck for both */ >>> CID 1501745: (TAINTED_SCALAR) >>> Using tainted variable "*rt_index" as an index into an array "l3vpn_bgp->vpn_policy". 1088 if (*rt_type == MPLSVPNVRFRTTYPEIMPORT && import 1089 && export 1090 && ecommunity_cmp( 1091 l3vpn_bgp->vpn_policy[*rt_index].rtlist 1092 [BGP_VPN_POLICY_DIR_FROMVPN], 1093 l3vpn_bgp->vpn_policy[*rt_index].rtlist /bgpd/bgp_mplsvpn_snmp.c: 1075 in bgpL3vpnVrfRt_lookup() 1069 *rt_type = 0; 1070 break; 1071 } 1072 if (*rt_type) { 1073 bool import, export; 1074 >>> CID 1501745: (TAINTED_SCALAR) >>> Using tainted variable "*rt_index" as an index into an array "l3vpn_bgp->vpn_policy". 1075 import = 1076 (!!l3vpn_bgp->vpn_policy[*rt_index].rtlist 1077 [BGP_VPN_POLICY_DIR_FROMVPN]); 1078 export = 1079 (!!l3vpn_bgp->vpn_policy[*rt_index].rtlist 1080 [BGP_VPN_POLICY_DIR_TOVPN]); /bgpd/bgp_mplsvpn_snmp.c: 1078 in bgpL3vpnVrfRt_lookup() 1072 if (*rt_type) { 1073 bool import, export; 1074 1075 import = 1076 (!!l3vpn_bgp->vpn_policy[*rt_index].rtlist 1077 [BGP_VPN_POLICY_DIR_FROMVPN]); >>> CID 1501745: (TAINTED_SCALAR) >>> Using tainted variable "*rt_index" as an index into an array "l3vpn_bgp->vpn_policy". 1078 export = 1079 (!!l3vpn_bgp->vpn_policy[*rt_index].rtlist 1080 [BGP_VPN_POLICY_DIR_TOVPN]); 1081 if (*rt_type == MPLSVPNVRFRTTYPEIMPORT 1082 && !import) 1083 continue; ** CID 1501744: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1501744: Null pointer dereferences (NULL_RETURNS) /bgpd/bgp_mplsvpn_snmp.c: 1464 in bgpL3vpnRte_lookup() 1458 /* otherwise lookup the one we have */ 1459 *l3vpn_bgp = bgp_lookup_by_name(vrf_name); 1460 1461 if (l3vpn_bgp == NULL) 1462 return NULL; 1463 >>> CID 1501744: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "*l3vpn_bgp" when calling "bgp_lookup_route_next". 1464 pi = bgp_lookup_route_next(l3vpn_bgp, dest, &prefix, policy, 1465 &nexthop); 1466 if (pi) { 1467 uint8_t vrf_name_len = 1468 strnlen((*l3vpn_bgp)->name, VRF_NAMSIZ); 1469 const struct prefix *p = bgp_dest_get_prefix(*dest); ** CID 1501743: (OVERRUN) ________________________________________________________________________________________________________ *** CID 1501743: (OVERRUN) /bgpd/bgp_mplsvpn_snmp.c: 1411 in bgpL3vpnRte_lookup() 1405 oid2in_addr(&name[i], sizeof(struct in_addr), 1406 &prefix.u.prefix4); 1407 i += sizeof(struct in_addr); 1408 break; 1409 case INETADDRESSTYPEIPV6: 1410 prefix.family = AF_INET6; >>> CID 1501743: (OVERRUN) >>> Overrunning struct type in_addr of 4 bytes by passing it to a function which accesses it at byte offset 15 using argument "16". 1411 oid2in_addr(&name[i], sizeof(struct in6_addr), 1412 &prefix.u.prefix4); /* sic */ 1413 i += sizeof(struct in6_addr); 1414 break; 1415 } 1416 prefix.prefixlen = (uint8_t)name[i++]; /bgpd/bgp_mplsvpn_snmp.c: 1434 in bgpL3vpnRte_lookup() 1428 oid2in_addr(&name[i], sizeof(struct in_addr), 1429 &nexthop.ip._v4_addr); 1430 i += sizeof(struct in_addr); 1431 break; 1432 case INETADDRESSTYPEIPV6: 1433 nexthop.ipa_type = IPADDR_V6; >>> CID 1501743: (OVERRUN) >>> Overrunning struct type in_addr of 4 bytes by passing it to a function which accesses it at byte offset 15 using argument "16". 1434 oid2in_addr(&name[i], sizeof(struct in6_addr), 1435 &nexthop.ip._v4_addr); /* sic */ 1436 i += sizeof(struct in6_addr); 1437 break; 1438 } 1439 } /bgpd/bgp_mplsvpn_snmp.c: 1482 in bgpL3vpnRte_lookup() 1476 /* copy the index parameters */ 1477 oid_copy_str(&name[namelen], (*l3vpn_bgp)->name, 1478 vrf_name_len); 1479 oid_index = namelen + vrf_name_len; 1480 name[oid_index++] = 1481 v4 ? INETADDRESSTYPEIPV4 : INETADDRESSTYPEIPV6; >>> CID 1501743: (OVERRUN) >>> Overrunning struct type in_addr of 4 bytes by passing it to a function which accesses it at byte offset 15 using argument "addr_len" (which evaluates to 16). 1482 oid_copy_addr(&name[oid_index], &p->u.prefix4, 1483 addr_len); 1484 oid_index += addr_len; 1485 name[oid_index++] = p->prefixlen; 1486 name[oid_index++] = *policy >> 8; 1487 name[oid_index++] = *policy & 0xff; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Disable compiling python codes in FRR
by Shahriar Basiri 08 Feb '21

08 Feb '21

Dear FRR community,I need to disable compiling python codes in FRR. I am cross compiling FRR but my toolchain doesn't have python. I think main frr codes is in c and maybe some tests and GUI are using python. is it at all possible to disable compiling python codes? Any help is really appreciated.ThanksShahriar

1 0

Canceled: Northbound Weekly meeting
by Santosh P K 04 Feb '21

04 Feb '21

All, Adjusted day light saving and this is the new slot we are going to use for northbound weekly meeting. Thanks Santosh P K

1 0