May 2021 - dev - lists.frrouting.org

Canceled: FRR Telco meeting
by olivier.dugeon＠orange.com 25 May '21

25 May '21

When: Wednesday, May 26, 2021 4:00 PM-5:00 PM. (UTC+01:00) Amsterdam, Berlin, Bern, Rome, Stockholm, Vienna Where: BlueJean https://bluejeans.com/377688464 *~*~*~*~*~*~*~*~*~* Hi all, This is the invite for the regular be-weekly Telco's meeting for 2021. NOTE: THE MEETING ID CHANGE. Please use https://bluejeans.com/377688464 for the next Telco meetings Regards Olivier _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 May '21

19 May '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 28 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1504898: Insecure data handling (TAINTED_SCALAR) ________________________________________________________________________________________________________ *** CID 1504898: Insecure data handling (TAINTED_SCALAR) /ospfd/ospf_dump.c: 585 in ospf_packet_dump() 579 ospf_packet_hello_dump(s, ntohs(ospfh->length)); 580 break; 581 case OSPF_MSG_DB_DESC: 582 ospf_packet_db_desc_dump(s, ntohs(ospfh->length)); 583 break; 584 case OSPF_MSG_LS_REQ: >>> CID 1504898: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted variable "ntohs(ospfh->length)" to a tainted sink. 585 ospf_packet_ls_req_dump(s, ntohs(ospfh->length)); 586 break; 587 case OSPF_MSG_LS_UPD: 588 ospf_packet_ls_upd_dump(s, ntohs(ospfh->length)); 589 break; 590 case OSPF_MSG_LS_ACK: ** CID 1504897: Memory - corruptions (OVERRUN) /ospfd/ospf_apiserver.c: 1175 in ospf_apiserver_handle_register_event() ________________________________________________________________________________________________________ *** CID 1504897: Memory - corruptions (OVERRUN) /ospfd/ospf_apiserver.c: 1175 in ospf_apiserver_handle_register_event() 1169 size = ntohs(msg->hdr.msglen); 1170 if (size < OSPF_MAX_LSA_SIZE) { 1171 1172 apiserv->filter = XMALLOC(MTYPE_OSPF_APISERVER_MSGFILTER, size); 1173 1174 /* copy it over. */ >>> CID 1504897: Memory - corruptions (OVERRUN) >>> Overrunning struct type lsa_filter_type of 4 bytes by passing it to a function which accesses it at byte offset 1498 using argument "size" (which evaluates to 1499). 1175 memcpy(apiserv->filter, &rmsg->filter, size); 1176 rc = OSPF_API_OK; 1177 } else 1178 rc = OSPF_API_NOMEMORY; 1179 1180 /* Send a reply back to client with return code */ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 May '21

19 May '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1504895: Possible Control flow issues (DEADCODE) /lib/northbound.c: 2434 in nb_init() ________________________________________________________________________________________________________ *** CID 1504895: Possible Control flow issues (DEADCODE) /lib/northbound.c: 2434 in nb_init() 2428 DEBUGD(&nb_dbg_events, "northbound: loading %s.yang", 2429 modules[i]->name); 2430 *loadedp++ = yang_module_load(modules[i]->name); 2431 } 2432 2433 if (explicit_compile) >>> CID 1504895: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "yang_init_loading_complete();". 2434 yang_init_loading_complete(); 2435 2436 /* Initialize the compiled nodes with northbound data */ 2437 for (size_t i = 0; i < nmodules; i++) { 2438 yang_snodes_iterate(loaded[i]->info, nb_node_new_cb, 0, NULL); 2439 nb_load_callbacks(modules[i]); ** CID 1504894: (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1504894: (NULL_RETURNS) /lib/northbound.c: 610 in nb_config_diff() 604 /* Skip rest of sub-tree, move to next sibling 605 */ 606 LYD_TREE_DFS_continue = 1; 607 break; 608 case 'd': /* delete */ 609 target = yang_dnode_get(config1->dnode, path); >>> CID 1504894: (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "target" when calling "nb_config_diff_deleted". 610 nb_config_diff_deleted(target, &seq, changes); 611 612 /* Skip rest of sub-tree, move to next sibling 613 */ 614 LYD_TREE_DFS_continue = 1; 615 break; /lib/northbound.c: 602 in nb_config_diff() 596 * dnode from the diff instead of the 597 * candidate config node we get failures when 598 * looking up default values, etc, based on 599 * the diff tree. 600 */ 601 target = yang_dnode_get(config2->dnode, path); >>> CID 1504894: (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "target" when calling "nb_config_diff_created". 602 nb_config_diff_created(target, &seq, changes); 603 604 /* Skip rest of sub-tree, move to next sibling 605 */ 606 LYD_TREE_DFS_continue = 1; 607 break; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

FRR 7.5.1 oficial debian package
by ivaylo 19 May '21

19 May '21

Hello, First thanks to of you about the work around FRR softaware ! After clean install (or upgrade from 7.3.1) on Debian 9/10 the oficial package of frr 7.5.1 (from frr-stable debian repository), I observe broken config file after edit via CLI (telnet or when starting bgpd with -t ) in route-map sections For example: bgpd# show running-config .... ! route-map IPV4-AAA-OUT permit 10 match as-path localas set as-path prepend 60349 60349 match ip address prefix-list v4_prep_nets route-map IPV4-AAA-OUT permit 60 match community c_CLS_2_AAA set as-path prepend 60349 ! .... First there is no comment between the two rules in the route map, second the match clauses are separate with set. Example2: extrestr# conf t extrestr(config)# route-ma extrestr(config)# route-map AAA1 permi extrestr(config)# route-map AAA1 permit 10 extrestr(config-route-map)# match as-path our_asn extrestr(config-route-map)# match community c_gws extrestr(config-route-map)# exit extrestr(config)# route-map AAA1 deny 5 extrestr(config-route-map)# show running-config ... route-map RS-OUT permit 10 match as-path our_asn set ipv6 next-hop global 2a09:a947:bac:252::133 set ipv6 next-hop prefer-global set ip next-hop 185.200.158.133 set ip next-hop 185.200.158.133 route-map AAA1 permit 10 match as-path our_asn match community c_gws ! route-map AAA1 deny 5 ... Commenting lines (!) are set strange (maybe random?) the. The rules in the route-map are not in the right sequence (I think they are add one after another without sequence). The other problem set clause of ip next-hop they are always added two times .... extrestr# conf t extrestr(config)# route-map RS-OUT permit 10 extrestr(config-route-map)# no set ip next-hop 185.200.158.133 extrestr(config-route-map)# show running-config .... route-map RS-OUT permit 10 match as-path our_asn set ipv6 next-hop global 2a09:a947:bac:252::133 set ipv6 next-hop prefer-global ! route-map AAA1 permit 10 match as-path our_asn match community c_gws ! route-map AAA1 deny 5 .... extrestr(config-route-map)# set ip next-hop 185.200.158.133 extrestr(config-route-map)# show running-config .... ! route-map RS-OUT permit 10 match as-path our_asn set ipv6 next-hop global 2a09:a947:bac:252::133 set ipv6 next-hop prefer-global set ip next-hop 185.200.158.133 set ip next-hop 185.200.158.133 route-map AAA1 permit 10 match as-path our_asn match community c_gws ! route-map AAA1 deny 5 ! When the bgpd.conf is writen it is same as is shown with running-config command, show route-map XXXX shows right sequence of the chains, so maybe it works at all, but I am not sure what will be with complicated route maps rules when you jump from one to another RM and back. Also with larger config files it is night mare to trace route map sequence. After build my own (package for debian10) stable 7.5 , stable 7.4 , stable 7.3 I see the problems starts from 7.4 and up. I have and version 7.6-dev build on Slackware and same is there. Currnet stable/7.3 branch and old debian 7.3.1 package (from frr repository) are ok. Current master 7.7 is totaly unusable on debian 10 because libyang2 (maybe the CI package of libyang 2 is broken not sure) but the cli (via telnet) is very slow (laggy, hard to write even a command) and bgpd connects and disconnects constantly. If you need debug or test more let me know. Ivaylo Josifov VarnaIX / Varteh LTD +359 52 969393 Varna, Bulgaria

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 13 May '21

13 May '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1504731: Control flow issues (DEADCODE) /pathd/path_cli.c: 425 in segment_list_has_prefix() ________________________________________________________________________________________________________ *** CID 1504731: Control flow issues (DEADCODE) /pathd/path_cli.c: 425 in segment_list_has_prefix() 419 } 420 inet_ntop(AF_INET6, &prefix_cli.u.prefix6, buf_prefix, 421 sizeof(buf_prefix)); 422 pre_ipaddr.ipa_type = IPADDR_V6; 423 pre_ipaddr.ip._v6_addr = prefix_cli.u.prefix6; 424 } else { >>> CID 1504731: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 2;". 425 return CMD_ERR_NO_MATCH; 426 } 427 snprintf(xpath, XPATH_MAXLEN, "./segment[index='%s']/nai/local-address", 428 index_str); 429 nb_cli_enqueue_change(vty, xpath, NB_OP_MODIFY, buf_prefix); 430 snprintf(xpath, XPATH_MAXLEN, ** CID 1504730: Control flow issues (DEADCODE) /pathd/path_cli.c: 532 in srte_segment_list_segment_magic() ________________________________________________________________________________________________________ *** CID 1504730: Control flow issues (DEADCODE) /pathd/path_cli.c: 532 in srte_segment_list_segment_magic() 526 } else { 527 segment_list_has_prefix( 528 vty, xpath, index, index_str, prefix_ipv4, 529 prefix_ipv4_str, prefix_ipv6, prefix_ipv6_str, has_algo, 530 algo, algo_str, has_iface_id, iface_id, iface_id_str); 531 if (status != CMD_SUCCESS) >>> CID 1504730: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return status;". 532 return status; 533 } 534 535 return nb_cli_apply_changes(vty, NULL); 536 } 537 ** CID 1504729: Control flow issues (DEADCODE) /pathd/path_cli.c: 355 in segment_list_has_src_dst() ________________________________________________________________________________________________________ *** CID 1504729: Control flow issues (DEADCODE) /pathd/path_cli.c: 355 in segment_list_has_src_dst() 349 node_src_id = adj_src_ipv4_str; 350 } else if (adj_src_ipv6_str != NULL) { 351 nb_cli_enqueue_change(vty, xpath, NB_OP_MODIFY, 352 "ipv6_adjacency"); 353 node_src_id = adj_src_ipv6_str; 354 } else { >>> CID 1504729: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 2;". 355 return CMD_ERR_NO_MATCH; 356 } 357 /* addresses */ 358 snprintf(xpath, XPATH_MAXLEN, "./segment[index='%s']/nai/local-address", 359 index_str); 360 nb_cli_enqueue_change(vty, xpath, NB_OP_MODIFY, node_src_id); ** CID 1504728: Null pointer dereferences (REVERSE_INULL) /pathd/pathd.c: 203 in srte_segment_entry_set_nai() ________________________________________________________________________________________________________ *** CID 1504728: Null pointer dereferences (REVERSE_INULL) /pathd/pathd.c: 203 in srte_segment_entry_set_nai() 197 { 198 int32_t status = 0; 199 struct prefix pre = {0}; 200 segment->nai_type = type; 201 memcpy(&segment->nai_local_addr, local_ip, sizeof(struct ipaddr)); 202 >>> CID 1504728: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "segment" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 203 if (!segment || !local_ip || !remote_ip) 204 return 1; 205 206 switch (type) { 207 case SRTE_SEGMENT_NAI_TYPE_IPV4_NODE: 208 case SRTE_SEGMENT_NAI_TYPE_IPV6_NODE: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 May '21

05 May '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1504610: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1504610: Uninitialized variables (UNINIT) /zebra/connected.c: 437 in connected_down() 431 * one. 432 */ 433 for (ALL_LIST_ELEMENTS_RO(ifp->connected, cnode, c)) { 434 struct prefix cp; 435 436 PREFIX_COPY(&cp, CONNECTED_PREFIX(c)); >>> CID 1504610: Uninitialized variables (UNINIT) >>> Using uninitialized value "cp.family" when calling "apply_mask". 437 apply_mask(&cp); 438 439 if (prefix_same(&p, &cp)) 440 count++; 441 442 if (count >= 2) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 04 May '21

04 May '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1504585: Insecure data handling (TAINTED_SCALAR) /ospfclient/ospf_apiclient.c: 334 in ospf_apiclient_send_request() ________________________________________________________________________________________________________ *** CID 1504585: Insecure data handling (TAINTED_SCALAR) /ospfclient/ospf_apiclient.c: 334 in ospf_apiclient_send_request() 328 /* Wait for reply */ /* NB: New "msg" is allocated by "msg_read()". */ 329 msg = msg_read(oclient->fd_sync); 330 if (!msg) 331 return -1; 332 333 assert(msg->hdr.msgtype == MSG_REPLY); >>> CID 1504585: Insecure data handling (TAINTED_SCALAR) >>> Using tainted variable "reqseq" as a loop boundary. 334 assert(ntohl(msg->hdr.msgseq) == reqseq); 335 336 msgreply = (struct msg_reply *)STREAM_DATA(msg->s); 337 rc = msgreply->errcode; 338 msg_free(msg); 339 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0