August 2021 - dev - lists.frrouting.org

Announcing FRR 8.0.1
by Martin Winter 30 Aug '21

30 Aug '21

We are pleased to announce release 8.0.1 of FRRouting! Github Release - https://github.com/FRRouting/frr/releases/tag/frr-8.0.1 Debian Packaging - https://deb.frrouting.org/ RPM Packaging - https://rpm.frrouting.org/ This is a bugfix release of FRR 8.0 For a detailed changelog with all the fixes over 8.0 see https://github.com/FRRouting/frr/releases/tag/frr-8.0.1 As always, thank you to all contributors! - Martin

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 25 Aug '21

25 Aug '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1506591: Control flow issues (DEADCODE) /pimd/pim_igmpv3.c: 548 in allow() ________________________________________________________________________________________________________ *** CID 1506591: Control flow issues (DEADCODE) /pimd/pim_igmpv3.c: 548 in allow() 542 GMI, accomplishes this. 543 */ 544 igmp_source_reset_gmi(igmp, group, source); 545 546 } /* scan received sources */ 547 >>> CID 1506591: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "group->group_filtermode_isexcl" inside this statement: "if (num_sources == 0 && gro...". 548 if ((num_sources == 0) && (group->group_filtermode_isexcl) 549 && (listcount(group->group_source_list) == 1)) { 550 struct in_addr star = {.s_addr = INADDR_ANY}; 551 552 source = igmp_find_source_by_addr(group, star); 553 if (source) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 21 Aug '21

21 Aug '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1506514: Insecure data handling (TAINTED_SCALAR) /ospf6d/ospf6_gr_helper.c: 1222 in ospf6_grace_lsa_show_info() ________________________________________________________________________________________________________ *** CID 1506514: Insecure data handling (TAINTED_SCALAR) /ospf6d/ospf6_gr_helper.c: 1222 in ospf6_grace_lsa_show_info() 1216 if (!use_json) 1217 vty_out(vty, "TLV info:\n"); 1218 } else { 1219 zlog_debug(" TLV info:"); 1220 } 1221 >>> CID 1506514: Insecure data handling (TAINTED_SCALAR) >>> Using tainted variable "length" as a loop boundary. 1222 for (tlvh = TLV_HDR_TOP(lsah); sum < length; 1223 tlvh = TLV_HDR_NEXT(tlvh)) { 1224 switch (ntohs(tlvh->type)) { 1225 case GRACE_PERIOD_TYPE: 1226 gracePeriod = (struct grace_tlv_graceperiod *)tlvh; 1227 sum += TLV_SIZE(tlvh); ** CID 1506513: Insecure data handling (TAINTED_SCALAR) /ospf6d/ospf6_gr_helper.c: 160 in ospf6_extract_grace_lsa_fields() ________________________________________________________________________________________________________ *** CID 1506513: Insecure data handling (TAINTED_SCALAR) /ospf6d/ospf6_gr_helper.c: 160 in ospf6_extract_grace_lsa_fields() 154 int sum = 0; 155 156 lsah = (struct ospf6_lsa_header *)lsa->header; 157 158 length = ntohs(lsah->length) - OSPF6_LSA_HEADER_SIZE; 159 >>> CID 1506513: Insecure data handling (TAINTED_SCALAR) >>> Using tainted variable "length" as a loop boundary. 160 for (tlvh = TLV_HDR_TOP(lsah); sum < length; 161 tlvh = TLV_HDR_NEXT(tlvh)) { 162 switch (ntohs(tlvh->type)) { 163 case GRACE_PERIOD_TYPE: 164 gracePeriod = (struct grace_tlv_graceperiod *)tlvh; 165 *interval = ntohl(gracePeriod->interval); ** CID 1506512: (USE_AFTER_FREE) /ospf6d/ospf6_gr_helper.c: 232 in ospf6_check_chg_in_rxmt_list() /ospf6d/ospf6_gr_helper.c: 232 in ospf6_check_chg_in_rxmt_list() ________________________________________________________________________________________________________ *** CID 1506512: (USE_AFTER_FREE) /ospf6d/ospf6_gr_helper.c: 232 in ospf6_check_chg_in_rxmt_list() 226 for (ALL_LSDB(nbr->retrans_list, lsa, lsanext)) { 227 struct ospf6_lsa *lsa_in_db = NULL; 228 229 /* Fetching the same copy of LSA form LSDB to validate the 230 * topochange. 231 */ >>> CID 1506512: (USE_AFTER_FREE) >>> Dereferencing freed pointer "lsa". 232 lsa_in_db = 233 ospf6_lsdb_lookup(lsa->header->type, lsa->header->id, 234 lsa->header->adv_router, lsa->lsdb); 235 236 if (lsa_in_db && lsa_in_db->tobe_acknowledged) 237 return OSPF6_TRUE; /ospf6d/ospf6_gr_helper.c: 232 in ospf6_check_chg_in_rxmt_list() 226 for (ALL_LSDB(nbr->retrans_list, lsa, lsanext)) { 227 struct ospf6_lsa *lsa_in_db = NULL; 228 229 /* Fetching the same copy of LSA form LSDB to validate the 230 * topochange. 231 */ >>> CID 1506512: (USE_AFTER_FREE) >>> Dereferencing freed pointer "lsa". 232 lsa_in_db = 233 ospf6_lsdb_lookup(lsa->header->type, lsa->header->id, 234 lsa->header->adv_router, lsa->lsdb); 235 236 if (lsa_in_db && lsa_in_db->tobe_acknowledged) 237 return OSPF6_TRUE; ** CID 1506511: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1506511: Null pointer dereferences (NULL_RETURNS) /ospf6d/ospf6_gr_helper.c: 1163 in show_ipv6_ospf6_gr_helper_magic() 1157 if (argv_find(argv, argc, "detail", &idx)) 1158 detail = true; 1159 1160 if (uj) 1161 json = json_object_new_object(); 1162 >>> CID 1506511: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "ospf6" when calling "show_ospf6_gr_helper_details". 1163 show_ospf6_gr_helper_details(vty, ospf6, json, uj, detail); 1164 1165 if (uj) { 1166 vty_out(vty, "%s\n", 1167 json_object_to_json_string_ext( 1168 json, JSON_C_TO_STRING_PRETTY)); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Frr-Pimd with quagga-zebra
by Sanjeev Singh 17 Aug '21

17 Aug '21

Hi, Is it possible to run FRR-PIMD with Quagga-Zebra ? Thanks, Sanjeev Singh

3 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 Aug '21

17 Aug '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1506502: Control flow issues (DEADCODE) /zebra/zebra_mpls_vty.c: 84 in zebra_mpls_transit_lsp() ________________________________________________________________________________________________________ *** CID 1506502: Control flow issues (DEADCODE) /zebra/zebra_mpls_vty.c: 84 in zebra_mpls_transit_lsp() 78 vty_out(vty, "%% Invalid label\n"); 79 return CMD_WARNING_CONFIG_FAILED; 80 } 81 82 if (add_cmd) { 83 if (!gate_str) { >>> CID 1506502: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% No Nexthop...". 84 vty_out(vty, "%% No Nexthop Information\n"); 85 return CMD_WARNING_CONFIG_FAILED; 86 } 87 if (!outlabel_str) { 88 vty_out(vty, "%% No Outgoing label Information\n"); 89 return CMD_WARNING_CONFIG_FAILED; ** CID 1506501: Control flow issues (DEADCODE) /bgpd/bgp_routemap.c: 1223 in route_match_alias() ________________________________________________________________________________________________________ *** CID 1506501: Control flow issues (DEADCODE) /bgpd/bgp_routemap.c: 1223 in route_match_alias() 1217 if (!found && strcmp(alias, com2alias) == 0) 1218 found = false; 1219 XFREE(MTYPE_TMP, communities[i]); 1220 } 1221 XFREE(MTYPE_TMP, communities); 1222 if (found) >>> CID 1506501: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return RMAP_MATCH;". 1223 return RMAP_MATCH; 1224 } 1225 1226 return RMAP_NOMATCH; 1227 } 1228 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 07 Aug '21

07 Aug '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1506222: Error handling issues (CHECKED_RETURN) /lib/frrlua.c: 243 in lua_decode_sockunion() ________________________________________________________________________________________________________ *** CID 1506222: Error handling issues (CHECKED_RETURN) /lib/frrlua.c: 243 in lua_decode_sockunion() 237 lua_setfield(L, -2, "string"); 238 } 239 240 void lua_decode_sockunion(lua_State *L, int idx, union sockunion *su) 241 { 242 lua_getfield(L, idx, "string"); >>> CID 1506222: Error handling issues (CHECKED_RETURN) >>> Calling "str2sockunion" without checking return value (as is done elsewhere 20 out of 21 times). 243 str2sockunion(lua_tostring(L, -1), su); 244 lua_pop(L, 1); 245 /* pop the table */ 246 lua_pop(L, 1); 247 } 248 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 04 Aug '21

04 Aug '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1506193: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1506193: Uninitialized variables (UNINIT) /ospfd/ospf_interface.c: 1463 in ospf_reset_hello_timer() 1457 struct prefix p; 1458 struct ospf_interface *oi = NULL; 1459 1460 p.u.prefix4 = addr; 1461 p.family = AF_INET; 1462 >>> CID 1506193: Uninitialized variables (UNINIT) >>> Using uninitialized value "p". Field "p.prefixlen" is uninitialized when calling "ospf_if_table_lookup". 1463 oi = ospf_if_table_lookup(ifp, &p); 1464 1465 if (oi) { 1466 /* Send hello before restart the hello timer 1467 * to avoid session flaps in case of bigger 1468 * hello interval configurations. ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 03 Aug '21

03 Aug '21

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1506156: (DEADCODE) /lib/frrscript.c: 294 in frrscript_load() /lib/frrscript.c: 299 in frrscript_load() /lib/frrscript.c: 289 in frrscript_load() /lib/frrscript.c: 304 in frrscript_load() ________________________________________________________________________________________________________ *** CID 1506156: (DEADCODE) /lib/frrscript.c: 294 in frrscript_load() 288 break; 289 case LUA_ERRSYNTAX: 290 zlog_err( 291 "frrscript: failed loading script '%s.lua': syntax error: %s", 292 script_name, lua_tostring(L, -1)); 293 break; >>> CID 1506156: (DEADCODE) >>> Execution cannot reach this statement: "case 4:". 294 case LUA_ERRMEM: 295 zlog_err( 296 "frrscript: failed loading script '%s.lua': out-of-memory error: %s", 297 script_name, lua_tostring(L, -1)); 298 break; 299 case LUA_ERRGCMM: /lib/frrscript.c: 299 in frrscript_load() 293 break; 294 case LUA_ERRMEM: 295 zlog_err( 296 "frrscript: failed loading script '%s.lua': out-of-memory error: %s", 297 script_name, lua_tostring(L, -1)); 298 break; >>> CID 1506156: (DEADCODE) >>> Execution cannot reach this statement: "case 5:". 299 case LUA_ERRGCMM: 300 zlog_err( 301 "frrscript: failed loading script '%s.lua': garbage collector error: %s", 302 script_name, lua_tostring(L, -1)); 303 break; 304 case LUA_ERRFILE: /lib/frrscript.c: 289 in frrscript_load() 283 } 284 int ret = luaL_dofile(L, script_name); 285 286 switch (ret) { 287 case LUA_OK: 288 break; >>> CID 1506156: (DEADCODE) >>> Execution cannot reach this statement: "case 3:". 289 case LUA_ERRSYNTAX: 290 zlog_err( 291 "frrscript: failed loading script '%s.lua': syntax error: %s", 292 script_name, lua_tostring(L, -1)); 293 break; 294 case LUA_ERRMEM: /lib/frrscript.c: 304 in frrscript_load() 298 break; 299 case LUA_ERRGCMM: 300 zlog_err( 301 "frrscript: failed loading script '%s.lua': garbage collector error: %s", 302 script_name, lua_tostring(L, -1)); 303 break; >>> CID 1506156: (DEADCODE) >>> Execution cannot reach this statement: "case 7:". 304 case LUA_ERRFILE: 305 zlog_err( 306 "frrscript: failed loading script '%s.lua': file read error: %s", 307 script_name, lua_tostring(L, -1)); 308 break; 309 default: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0