June 2022 - dev - lists.frrouting.org

Error when running frr from source code
by hieunt562＠viettel.com.vn 30 Jun '22

30 Jun '22

Hi all. I want to install FRR 8.2.2 release from source code for ospfd running on CenOS 7. So, I followed the guide line from http://docs.frrouting.org/projects/dev-guide/en/latest/building-frr-for-cent os7.html. - First, when I run: ./configure --bindir=/usr/bin --sbindir=/usr/lib/frr --sysconfdir=/etc/frr --libdir=/usr/lib/frr --libexecdir=/usr/lib/frr --localstatedir=/var/run/frr --with-moduledir=/usr/lib/frr/modules --enable-snmp=agentx --enable-multipath=64 --enable-user=frr --enable-group=frr --enable-vty-group=frrvty --disable-ldpd --enable-fpm --with-pkg-git-version --with-pkg-extra-version=-MyOwnFRRVersion SPHINXBUILD=/usr/bin/sphinx-build I got two warnings: configure: WARNING: sphinx is missing but required to build documentation configure: WARNING: pytest is missing, unit tests cannot be performed - After compile source and install I run sudo systemctl start frr I got error message like below: [root@localhost frr]# sudo systemctl start frr Job for frr.service failed. See "systemctl status frr.service" and "journalctl -xe" for details. [root@localhost frr]# systemctl status frr.service ● frr.service - FRRouting Loaded: loaded (/etc/systemd/system/frr.service; enabled; vendor preset: disabled) Active: activating (start) since Wed 2022-06-22 23:10:24 EDT; 16s ago Docs: <https://frrouting.readthedocs.io/en/latest/setup.html> https://frrouting.readthedocs.io/en/latest/setup.html Control: 10242 (frrinit.sh) Status: "restarting all" Tasks: 3 CGroup: /system.slice/frr.service ├─10242 /bin/bash /usr/lib/frr/frrinit.sh start ├─10246 /usr/lib/frr/watchfrr -d -F traditional zebra ospfd staticd └─10247 /usr/lib/frr/watchfrr -d -F traditional zebra ospfd staticd Jun 22 23:10:24 localhost.localdomain systemd[1]: Starting FRRouting... Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [T83RR-8SM5G] watchfrr 8.2.2-MyOwnFRRVersion starting: vty@0 Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [ZCJ3S-SPH5S] zebra state -> down : initial connection attempt failed Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [ZCJ3S-SPH5S] ospfd state -> down : initial connection attempt failed Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [ZCJ3S-SPH5S] staticd state -> down : initial connection attempt failed Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [YFT0P-5Q5YX] Forked background command [pid 10248]: /usr/lib/frr/watchfrr.sh restart all [root@localhost frr]# journalctl -xe -- Subject: Unit frr.service has finished shutting down -- Defined-By: systemd -- Support: <http://lists.freedesktop.org/mailman/listinfo/systemd-devel> http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Unit frr.service has finished shutting down. Jun 22 23:10:24 localhost.localdomain systemd[1]: Starting FRRouting... -- Subject: Unit frr.service has begun start-up -- Defined-By: systemd -- Support: <http://lists.freedesktop.org/mailman/listinfo/systemd-devel> http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Unit frr.service has begun starting up. Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [T83RR-8SM5G] watchfrr 8.2.2-MyOwnFRRVersion starting: vty@0 Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [ZCJ3S-SPH5S] zebra state -> down : initial connection attempt failed Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [ZCJ3S-SPH5S] ospfd state -> down : initial connection attempt failed Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [ZCJ3S-SPH5S] staticd state -> down : initial connection attempt failed Jun 22 23:10:24 localhost.localdomain watchfrr[10247]: [YFT0P-5Q5YX] Forked background command [pid 10248]: /usr/lib/frr/watchfrr.sh restart all Jun 22 23:10:24 localhost.localdomain watchfrr.sh[10260]: Cannot stop zebra: pid file not found Jun 22 23:10:24 localhost.localdomain watchfrr.sh[10256]: Cannot stop staticd: pid file not found Jun 22 23:10:24 localhost.localdomain watchfrr.sh[10259]: Cannot stop ospfd: pid file not found Jun 22 23:10:24 localhost.localdomain watchfrr.sh[10263]: Failed to start zebra! Jun 22 23:10:24 localhost.localdomain watchfrr.sh[10266]: Failed to start ospfd! Jun 22 23:10:24 localhost.localdomain watchfrr.sh[10269]: Failed to start staticd! Do you know why I got these errors, please help me to fix them. Thanks and best regards! HieuNT

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 23 Jun '22

23 Jun '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1518664: (UNINIT) ________________________________________________________________________________________________________ *** CID 1518664: (UNINIT) /ospfd/ospf_vty.c: 4410 in show_ip_ospf_neighbour_brief() 4404 time_val); 4405 json_object_int_add(json_neighbor, "deadTimeMsecs", 4406 time_store); 4407 json_object_int_add(json_neighbor, 4408 "routerDeadIntervalTimerDueMsec", 4409 time_store); >>> CID 1518664: (UNINIT) >>> Using uninitialized value "res.tv_usec" when calling "ospf_timeval_dump". 4410 json_object_string_add( 4411 json_neighbor, "upTime", 4412 ospf_timeval_dump(&res, uptime, 4413 sizeof(uptime))); 4414 json_object_string_add( 4415 json_neighbor, "deadTime", /ospfd/ospf_vty.c: 4458 in show_ip_ospf_neighbour_brief() 4452 vty_out(vty, "%-15s %3d %-15s ", "-", nbr->priority, 4453 msgbuf); 4454 else 4455 vty_out(vty, "%-15pI4 %3d %-15s ", &nbr->router_id, 4456 nbr->priority, msgbuf); 4457 >>> CID 1518664: (UNINIT) >>> Using uninitialized value "res.tv_usec" when calling "ospf_timeval_dump". 4458 vty_out(vty, "%-15s ", 4459 ospf_timeval_dump(&res, uptime, sizeof(uptime))); 4460 4461 vty_out(vty, "%9s ", 4462 ospf_timer_dump(nbr->t_inactivity, timebuf, 4463 sizeof(timebuf))); ** CID 1518663: (CONSTANT_EXPRESSION_RESULT) /zebra/zapi_msg.c: 1650 in nexthop_from_zapi() /zebra/zapi_msg.c: 1616 in nexthop_from_zapi() ________________________________________________________________________________________________________ *** CID 1518663: (CONSTANT_EXPRESSION_RESULT) /zebra/zapi_msg.c: 1650 in nexthop_from_zapi() 1644 memset(&vtep_ip, 0, sizeof(vtep_ip)); 1645 vtep_ip.ipa_type = IPADDR_V6; 1646 memcpy(&vtep_ip.ipaddr_v6, &(api_nh->gate.ipv6), 1647 sizeof(struct in6_addr)); 1648 zebra_rib_queue_evpn_route_add( 1649 api_nh->vrf_id, &api_nh->rmac, &vtep_ip, p); >>> CID 1518663: (CONSTANT_EXPRESSION_RESULT) >>> In "nexthop->flags |= 256 /* 1 << 8 */", wider "256 /* 1 << 8 */" has high-order bits (0x100) that don't affect the narrower left-hand side. 1650 SET_FLAG(nexthop->flags, NEXTHOP_FLAG_EVPN); 1651 } 1652 break; 1653 case NEXTHOP_TYPE_BLACKHOLE: 1654 if (IS_ZEBRA_DEBUG_RECV) 1655 zlog_debug("%s: nh blackhole %d", /zebra/zapi_msg.c: 1616 in nexthop_from_zapi() 1610 memset(&vtep_ip, 0, sizeof(vtep_ip)); 1611 vtep_ip.ipa_type = IPADDR_V4; 1612 memcpy(&(vtep_ip.ipaddr_v4), &(api_nh->gate.ipv4), 1613 sizeof(struct in_addr)); 1614 zebra_rib_queue_evpn_route_add( 1615 api_nh->vrf_id, &api_nh->rmac, &vtep_ip, p); >>> CID 1518663: (CONSTANT_EXPRESSION_RESULT) >>> In "nexthop->flags |= 256 /* 1 << 8 */", wider "256 /* 1 << 8 */" has high-order bits (0x100) that don't affect the narrower left-hand side. 1616 SET_FLAG(nexthop->flags, NEXTHOP_FLAG_EVPN); 1617 } 1618 break; 1619 case NEXTHOP_TYPE_IPV6: 1620 if (IS_ZEBRA_DEBUG_RECV) { 1621 inet_ntop(AF_INET6, &api_nh->gate.ipv6, nhbuf, ** CID 1518662: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /zebra/zebra_fpm_netlink.c: 211 in netlink_route_info_add_nh() ________________________________________________________________________________________________________ *** CID 1518662: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /zebra/zebra_fpm_netlink.c: 211 in netlink_route_info_add_nh() 205 src = &nexthop->src; 206 } 207 208 if (!nhi.gateway && nhi.if_index == 0) 209 return 0; 210 >>> CID 1518662: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "nexthop->flags & (256 /* 1 << 8 */)" is always 0 regardless of the values of its operands. This occurs as the logical operand of "if". 211 if (CHECK_FLAG(nexthop->flags, NEXTHOP_FLAG_EVPN)) { 212 nhi.encap_info.encap_type = FPM_NH_ENCAP_VXLAN; 213 214 /* Extract VNI id for the nexthop SVI interface */ 215 zvrf = zebra_vrf_lookup_by_id(nexthop->vrf_id); 216 if (zvrf) { ** CID 1518661: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /lib/zclient.c: 1833 in zapi_nexthop_from_nexthop() ________________________________________________________________________________________________________ *** CID 1518661: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /lib/zclient.c: 1833 in zapi_nexthop_from_nexthop() 1827 znh->ifindex = nh->ifindex; 1828 znh->gate = nh->gate; 1829 1830 if (CHECK_FLAG(nh->flags, NEXTHOP_FLAG_ONLINK)) 1831 SET_FLAG(znh->flags, ZAPI_NEXTHOP_FLAG_ONLINK); 1832 >>> CID 1518661: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "nh->flags & (256 /* 1 << 8 */)" is always 0 regardless of the values of its operands. This occurs as the logical operand of "if". 1833 if (CHECK_FLAG(nh->flags, NEXTHOP_FLAG_EVPN)) 1834 SET_FLAG(znh->flags, ZAPI_NEXTHOP_FLAG_EVPN); 1835 1836 if (nh->nh_label && (nh->nh_label->num_labels > 0)) { 1837 1838 /* Validate */ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Ubuntu 22 Question
by Fatih Ünlü 18 Jun '22

18 Jun '22

Hello Dear Dev Team, Thank you for great software. My cloud provider provides me arm based server only with Ubuntu 22. Frr on official repo is a bit outdated which is 8.1 Is there any plan from your side to support Ubuntu 22 on your repo? Thank you BR Fatih

1 0

Question about BGP NLRI structure
by johnjdunbar＠disroot.org 10 Jun '22

10 Jun '22

I'm trying to implement https://datatracker.ietf.org/doc/draft-ietf-idr-sdwan-edge-discovery/ into frr/bgpd. Looking through the code I have some questions for which I hope someone can help me RFC 4760 defines the mp_reach_nlri attributes as this +---------------------------------------------------------+ | Address Family Identifier (2 octets) | +---------------------------------------------------------+ | Subsequent Address Family Identifier (1 octet) | +---------------------------------------------------------+ | Length of Next Hop Network Address (1 octet) | +---------------------------------------------------------+ | Network Address of Next Hop (variable) | +---------------------------------------------------------+ | Reserved (1 octet) | +---------------------------------------------------------+ | Network Layer Reachability Information (variable) | +---------------------------------------------------------+ Is the following structure in /bgpd/bgpd.h representing the table above? struct bgp_nlri { /* AFI. */ uint16_t afi; /* iana_afi_t */ /* SAFI. */ uint8_t safi; /* iana_safi_t */ /* Pointer to NLRI byte stream. */ uint8_t *nlri; /* Length of whole NLRI. */ bgp_size_t length; }; If yes, does uint8_t *nlri map to [Network Layer Reachability Information (variable)]? does bgp_size_t length map to [Length of Next Hop Network Address (1 octet)]? If not, can someone please tell me what this structure maps to? I appreciate anyone who has insights to help me out. Thank you, John

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 08 Jun '22

08 Jun '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1518122: Memory - illegal accesses (OVERRUN) /ospfd/ospf_api.c: 676 in new_msg_reachable_change() ________________________________________________________________________________________________________ *** CID 1518122: Memory - illegal accesses (OVERRUN) /ospfd/ospf_api.c: 676 in new_msg_reachable_change() 670 if (nremove > (nmax - nadd)) 671 nremove = (nmax - nadd); 672 673 if (nadd) 674 memcpy(nmsg->router_ids, add, nadd * insz); 675 if (nremove) >>> CID 1518122: Memory - illegal accesses (OVERRUN) >>> Overrunning array of 1536 bytes at byte offset 1536 by dereferencing pointer "&nmsg->router_ids[nadd]". 676 memcpy(&nmsg->router_ids[nadd], remove, nremove * insz); 677 678 nmsg->nadd = htons(nadd); 679 nmsg->nremove = htons(nremove); 680 len = sizeof(*nmsg) + insz * (nadd + nremove); 681 682 return msg_new(MSG_REACHABLE_CHANGE, nmsg, seqnum, len); 683 } 684 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0