July 2022 - dev - lists.frrouting.org

FRR 8.3 Release
by Jafar Al-Gharaibeh 20 Jul '22

20 Jul '22

Dear FRR Community, We are pleased to announce FRR 8.3 release. This release brings a long list of enhancements and fixes with more than 1000 commits from 67 developers. Packages: * Debian Packages - https://deb.frrouting.org/ <https://deb.frrouting.org/> * RPM Packages - https://rpm.frrouting.org/ <https://rpm.frrouting.org/> * Snaps - https://snapcraft.io/frr <https://snapcraft.io/frr> * Docker - https://hub.docker.com/layers/frr/frrouting/frr/v8.3.0/images/sha256-4d1343… <https://hub.docker.com/layers/frr/frrouting/frr/v8.3.0/images/sha256-4d1343…> Major Highlights: * Notification Message support for BGP Graceful Restart (http://docs.frrouting.org/en/latest/bgp.html#clicmd-bgp-graceful-restart-no… <http://docs.frrouting.org/en/latest/bgp.html#clicmd-bgp-graceful-restart-no…>) * BGP Cease Notification Subcode For BFD * Send Hold Timer for BGP * RFC5424 syslog support (http://docs.frrouting.org/en/latest/extlog.html?#clicmd-destination-syslog-… <http://docs.frrouting.org/en/latest/extlog.html?#clicmd-destination-syslog-…>) * PIM passive command (http://docs.frrouting.org/en/latest/pim.html#clicmd-ip-pim-passive <http://docs.frrouting.org/en/latest/pim.html#clicmd-ip-pim-passive>) Breaking Change: * Require librtr >= 0.8.0 for BGP RPKI (available in FRR package repos above) Please see the release notes for the detailed changelog: * Github release: https://github.com/FRRouting/frr/releases/tag/frr-8.3 <https://github.com/FRRouting/frr/releases/tag/frr-8.3> * FRRouting website: https://frrouting.org/release/8.3 <https://frrouting.org/release/8.3> Thanks to all contributors! Cheers, The FRR Development Team!

1 0

Re: [dev] LDPD crashes when hold time configured 65535
by Donatas Abraitis 18 Jul '22

18 Jul '22

Hi, thanks for the report, should be fixed in https://github.com/FRRouting/frr/pull/11631. On Mon, Jul 18, 2022 at 9:35 AM Girish Patoliya via dev < dev(a)lists.frrouting.org> wrote: > > > > ---------- Forwarded message ---------- > From: Girish Patoliya <girishkumar.patoliya(a)mavenir.com> > To: "dev(a)lists.frrouting.org" <dev(a)lists.frrouting.org> > Cc: > Bcc: > Date: Mon, 18 Jul 2022 06:24:03 +0000 > Subject: LDPD crashes when hold time configured 65535 > > Hi > > > > I am running FRR from stable 8.1 HEAD. > > > > LDPD crashes when hold time is configured to 65535: > (gdb) bt > #0 0x00007f8c3fc224bb in raise () from /lib64/libpthread.so.0 > #1 0x00007f8c4138a3dd in core_handler () from /lib64/libfrr.so.0 > #2 <signal handler called> > #3 0x00007f8c3fc1ccc0 in pthread_mutex_lock () from /lib64/libpthread.so.0 > #4 0x00007f8c4139914b in thread_timer_remain_msec () from > /lib64/libfrr.so.0 > #5 0x00007f8c41399209 in thread_timer_remain_second () from > /lib64/libfrr.so.0 > #6 0x000000000040eb19 in adj_to_ctl () > #7 0x0000000000427b38 in ldpe_nbr_ctl () > #8 0x000000000042fd68 in control_dispatch_imsg () > #9 0x00007f8c4139a628 in thread_call () from /lib64/libfrr.so.0 > #10 0x00000000004265fc in ldpe () > #11 0x000000000040a68f in main () > > > > I tried to compile on latest to check if this issue is fixed, but > unfortunately my compilation is failing on master HEAD due to env > dependencies. > > Is anyone aware if this issue is fixed after 8.1 ? > Can someone share details on how to enable gdb option to get full bt, I > tried * --enable-dev-build* but I am getting same bt without local info. > > > > Regards, > > Girish > > > ------------------------------ > > This e-mail message may contain confidential or proprietary information of > Mavenir Systems, Inc. or its affiliates and is intended solely for the use > of the intended recipient(s). If you are not the intended recipient of this > message, you are hereby notified that any review, use or distribution of > this information is absolutely prohibited and we request that you delete > all copies in your control and contact us by e-mailing to > security(a)mavenir.com. This message contains the views of its author and > may not necessarily reflect the views of Mavenir Systems, Inc. or its > affiliates, who employ systems to monitor email messages, but make no > representation that such messages are authorized, secure, uncompromised, or > free from computer viruses, malware, or other defects. Thank You > > > > ---------- Forwarded message ---------- > From: Girish Patoliya via dev <dev(a)lists.frrouting.org> > To: "dev(a)lists.frrouting.org" <dev(a)lists.frrouting.org> > Cc: > Bcc: > Date: Mon, 18 Jul 2022 06:24:03 +0000 > Subject: [dev] LDPD crashes when hold time configured 65535 > _______________________________________________ > dev mailing list > dev(a)lists.frrouting.org > https://lists.frrouting.org/listinfo/dev > -- Donatas

1 0

LDPD crashes when hold time configured 65535
by Girish Patoliya 18 Jul '22

18 Jul '22

Hi I am running FRR from stable 8.1 HEAD. LDPD crashes when hold time is configured to 65535: (gdb) bt #0 0x00007f8c3fc224bb in raise () from /lib64/libpthread.so.0 #1 0x00007f8c4138a3dd in core_handler () from /lib64/libfrr.so.0 #2 <signal handler called> #3 0x00007f8c3fc1ccc0 in pthread_mutex_lock () from /lib64/libpthread.so.0 #4 0x00007f8c4139914b in thread_timer_remain_msec () from /lib64/libfrr.so.0 #5 0x00007f8c41399209 in thread_timer_remain_second () from /lib64/libfrr.so.0 #6 0x000000000040eb19 in adj_to_ctl () #7 0x0000000000427b38 in ldpe_nbr_ctl () #8 0x000000000042fd68 in control_dispatch_imsg () #9 0x00007f8c4139a628 in thread_call () from /lib64/libfrr.so.0 #10 0x00000000004265fc in ldpe () #11 0x000000000040a68f in main () I tried to compile on latest to check if this issue is fixed, but unfortunately my compilation is failing on master HEAD due to env dependencies. Is anyone aware if this issue is fixed after 8.1 ? Can someone share details on how to enable gdb option to get full bt, I tried --enable-dev-build but I am getting same bt without local info. Regards, Girish ________________________________ This e-mail message may contain confidential or proprietary information of Mavenir Systems, Inc. or its affiliates and is intended solely for the use of the intended recipient(s). If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies in your control and contact us by e-mailing to security(a)mavenir.com. This message contains the views of its author and may not necessarily reflect the views of Mavenir Systems, Inc. or its affiliates, who employ systems to monitor email messages, but make no representation that such messages are authorized, secure, uncompromised, or free from computer viruses, malware, or other defects. Thank You

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Jul '22

06 Jul '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1518830: (RESOURCE_LEAK) /bfdd/bfd_packet.c: 1582 in bp_echo_socket() /bfdd/bfd_packet.c: 1572 in bp_echo_socket() ________________________________________________________________________________________________________ *** CID 1518830: (RESOURCE_LEAK) /bfdd/bfd_packet.c: 1582 in bp_echo_socket() 1576 sll.sll_family = AF_PACKET; 1577 sll.sll_protocol = htons(ETH_P_IP); 1578 sll.sll_ifindex = 0; 1579 if (bind(s, (struct sockaddr *)&sll, sizeof(sll)) < 0) { 1580 zlog_warn("Failed to bind echo socket: %s", 1581 safe_strerror(errno)); >>> CID 1518830: (RESOURCE_LEAK) >>> Handle variable "s" going out of scope leaks the handle. 1582 return -1; 1583 } 1584 1585 return s; 1586 } 1587 #else /bfdd/bfd_packet.c: 1572 in bp_echo_socket() 1566 pf.filter = my_filterudp; 1567 pf.len = MY_FILTER_LENGTH; 1568 if (setsockopt(s, SOL_SOCKET, SO_ATTACH_FILTER, &pf, sizeof(pf)) == 1569 -1) { 1570 zlog_warn("%s: setsockopt(SO_ATTACH_FILTER): %s", __func__, 1571 strerror(errno)); >>> CID 1518830: (RESOURCE_LEAK) >>> Handle variable "s" going out of scope leaks the handle. 1572 return -1; 1573 } 1574 1575 1576 sll.sll_family = AF_PACKET; 1577 sll.sll_protocol = htons(ETH_P_IP); ** CID 1518829: Memory - corruptions (BUFFER_SIZE) /bfdd/bfd_packet.c: 222 in ptm_bfd_echo_fp_snd() ________________________________________________________________________________________________________ *** CID 1518829: Memory - corruptions (BUFFER_SIZE) /bfdd/bfd_packet.c: 222 in ptm_bfd_echo_fp_snd() 216 SET_FLAG(bfd->flags, BFD_SESS_FLAG_ECHO_ACTIVE); 217 218 memset(sendbuff, 0, sizeof(sendbuff)); 219 220 /* add eth hdr */ 221 eth = (struct ethhdr *)(sendbuff); >>> CID 1518829: Memory - corruptions (BUFFER_SIZE) >>> You might overrun the 6 byte destination string "eth->h_source" by writing the maximum 20 bytes from "bfd->ifp->hw_addr". 222 memcpy(eth->h_source, bfd->ifp->hw_addr, sizeof(bfd->ifp->hw_addr)); 223 memcpy(eth->h_dest, bfd->peer_hw_addr, sizeof(bfd->peer_hw_addr)); 224 225 total_len += sizeof(struct ethhdr); 226 227 sd = bvrf->bg_echo; ** CID 1518828: Memory - corruptions (OVERRUN) /bfdd/bfd_packet.c: 222 in ptm_bfd_echo_fp_snd() ________________________________________________________________________________________________________ *** CID 1518828: Memory - corruptions (OVERRUN) /bfdd/bfd_packet.c: 222 in ptm_bfd_echo_fp_snd() 216 SET_FLAG(bfd->flags, BFD_SESS_FLAG_ECHO_ACTIVE); 217 218 memset(sendbuff, 0, sizeof(sendbuff)); 219 220 /* add eth hdr */ 221 eth = (struct ethhdr *)(sendbuff); >>> CID 1518828: Memory - corruptions (OVERRUN) >>> Overrunning array "eth->h_source" of 6 bytes by passing it to a function which accesses it at byte offset 19 using argument "20UL". 222 memcpy(eth->h_source, bfd->ifp->hw_addr, sizeof(bfd->ifp->hw_addr)); 223 memcpy(eth->h_dest, bfd->peer_hw_addr, sizeof(bfd->peer_hw_addr)); 224 225 total_len += sizeof(struct ethhdr); 226 227 sd = bvrf->bg_echo; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0