October 2023 - dev - lists.frrouting.org

FRR 9.0.1 and 8.5.3 Releases
by Jafar Al-Gharaibeh 28 Nov '23

28 Nov '23

Dear FRR Community, We are pleased to announce FRR 9.0.1 and FRR 8.5.3 bug fix releases. For release notes please visit: https://frrouting.org/release/ https://github.com/FRRouting/frr/releases Security updates: https://frrouting.org/security Cheers, The FRR Development Team!

1 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 31 Oct '23

31 Oct '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1570864: Incorrect expression (UNINTENDED_INTEGER_DIVISION) /bgpd/bgp_labelpool.c: 656 in bgp_lp_event_zebra_up() ________________________________________________________________________________________________________ *** CID 1570864: Incorrect expression (UNINTENDED_INTEGER_DIVISION) /bgpd/bgp_labelpool.c: 656 in bgp_lp_event_zebra_up() 650 651 lp->next_chunksize <<= 1; 652 } 653 654 /* round up */ 655 if (((float)labels_needed / (float)lp->next_chunksize) > >>> CID 1570864: Incorrect expression (UNINTENDED_INTEGER_DIVISION) >>> Dividing integer expressions "labels_needed" and "lp->next_chunksize", and then converting the integer quotient to type "float". Any remainder, or fractional part of the quotient, is ignored. 656 (labels_needed / lp->next_chunksize)) 657 chunks_needed = (labels_needed / lp->next_chunksize) + 1; 658 else 659 chunks_needed = (labels_needed / lp->next_chunksize); 660 labels_needed = chunks_needed * lp->next_chunksize; 661 ** CID 1570863: Control flow issues (DEADCODE) /zebra/redistribute.c: 138 in zebra_redistribute() ________________________________________________________________________________________________________ *** CID 1570863: Control flow issues (DEADCODE) /zebra/redistribute.c: 138 in zebra_redistribute() 132 && (newre->type != type 133 || newre->instance != instance))) 134 continue; 135 if (!zebra_check_addr(&rn->p)) 136 continue; 137 >>> CID 1570863: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "newre->vrf_id != 0U" inside this statement: "if (type == ZEBRA_ROUTE_ADD...". 138 if (type == ZEBRA_ROUTE_ADD && is_table_direct && 139 newre->vrf_id != VRF_DEFAULT) 140 continue; 141 142 zsend_redistribute_route(ZEBRA_REDISTRIBUTE_ROUTE_ADD, 143 client, rn, newre, is_table_direct); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

FIX FRRouting
by Александр Николаевич 31 Oct '23

31 Oct '23

2 1

Assistance Needed with Pending Pull Request Review
by 彭凯飞 30 Oct '23

30 Oct '23

Hello FRRouting Development Team, I hope this message finds you well. I am reaching out in regard to a pull request I submitted to the FRRouting repository about six months ago, which can be found here: [#12862](https://github.com/FRRouting/frr/pull/12862). The PR has successfully passed the CI tests four months ago and has been awaiting a review since then. My pull request was initially assigned to Mr. David Lamparter for review. I've tried reaching out to him directly, but I suspect he may not be actively checking his email. I hold great respect for his expertise and contributions to the project and would very much value his feedback on my submission. Given the circumstances, I kindly request the community's assistance in either reminding Mr. Lamparter about the review or suggesting an alternative reviewer if he is currently unavailable. I understand everyone has their commitments and priorities, but I'm eager to contribute and would greatly appreciate any guidance or feedback on the pull request. Thank you for your understanding and consideration. I'm looking forward to being a part of the FRRouting project's ongoing development. Best regards, Kaifei Peng https://github.com/ponedo

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Oct '23

24 Oct '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1569357: (OVERRUN) /bgpd/bgp_packet.c: 3310 in bgp_dynamic_capability_fqdn() /bgpd/bgp_packet.c: 3343 in bgp_dynamic_capability_fqdn() ________________________________________________________________________________________________________ *** CID 1569357: (OVERRUN) /bgpd/bgp_packet.c: 3310 in bgp_dynamic_capability_fqdn() 3304 memcpy(&str, data, len); 3305 str[len] = '\0'; 3306 } 3307 data += len; 3308 3309 if (len) { >>> CID 1569357: (OVERRUN) >>> Overrunning array "str" of 65 bytes at byte offset 65 using index "len" (which evaluates to 65). 3310 str[len] = '\0'; 3311 3312 XFREE(MTYPE_BGP_PEER_HOST, peer->hostname); 3313 XFREE(MTYPE_BGP_PEER_HOST, peer->domainname); 3314 3315 peer->hostname = XSTRDUP(MTYPE_BGP_PEER_HOST, str); /bgpd/bgp_packet.c: 3343 in bgp_dynamic_capability_fqdn() 3337 memcpy(&str, data, len); 3338 str[len] = '\0'; 3339 } 3340 data += len; 3341 3342 if (len) { >>> CID 1569357: (OVERRUN) >>> Overrunning array "str" of 65 bytes at byte offset 65 using index "len" (which evaluates to 65). 3343 str[len] = '\0'; 3344 3345 XFREE(MTYPE_BGP_PEER_HOST, peer->domainname); 3346 3347 peer->domainname = XSTRDUP(MTYPE_BGP_PEER_HOST, str); 3348 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

First notice for nominations for candidates for the FRR 2023 TSC elections.
by Alistair Woodman 17 Oct '23

17 Oct '23

All, This is the first request for nominations for candidates for the 2023 TSC elections. Please contact me with nominations or questions. 1) Self-nominations are welcome. 2) All nominees must be active FRR maintainers in order to stand. 3) Present TSC members must opt-out of being auto-nominated. 4) If you plan to nominate someone else, please get their approval first. /a (your friendly FRR community elections officer)

1 2